Add indexRandomForConcurrentSearch method to tests: #11118

jed326 · 2023-11-06T23:03:20Z

IndexStatsIT.java
SearchTimeoutIT.java
NaNSortingIT.java
NestedIT.java
RangeIT.java

Description

Updates the above tests to use multiple segment slices for concurrent segment search

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)
Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2023-11-06T23:32:13Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/29632/
CommitID: b8a4165
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

jed326 · 2023-11-06T23:38:48Z

https://build.ci.opensearch.org/job/gradle-check/29632/

ReindexTestCase.testMultipleSources flaky test #6542

github-actions · 2023-11-06T23:44:36Z

Compatibility status:

Checks if related components are compatible with change abfd13a

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

github-actions · 2023-11-11T00:17:39Z

❌ Gradle check result for 059b7eb: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2023-11-11T00:26:38Z

❌ Gradle check result for d0fe82f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

jed326 · 2023-11-11T00:27:52Z

https://build.ci.opensearch.org/job/gradle-check/29829/

[BUG] test failure ':sandbox:plugins:concurrent-search:test' QueryProfilePhaseTests.testTerminateAfterEarlyTermination #2775

server/src/internalClusterTest/java/org/opensearch/search/SearchTimeoutIT.java

github-actions · 2023-11-11T01:06:17Z

❌ Gradle check result for 53a4866: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2023-11-11T01:24:42Z

❌ Gradle check result for 1c7f942: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2023-11-11T02:44:55Z

❌ Gradle check result for f324e7b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2023-11-11T03:04:15Z

❌ Gradle check result for c3ede5e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

* IndexStatsIT.java * SearchTimeoutIT.java * NaNSortingIT.java * NestedIT.java * RangeIT.java Signed-off-by: Jay Deng <jayd0104@gmail.com>

github-actions · 2023-11-11T06:46:05Z

❕ Gradle check result for abfd13a: UNSTABLE

TEST FAILURES:

      1 org.opensearch.repositories.azure.AzureBlobContainerRetriesTests.testReadNonexistentBlobThrowsNoSuchFileException

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

codecov · 2023-11-11T06:46:40Z

Codecov Report

Merging #11118 (abfd13a) into main (dcb64d8) will increase coverage by 0.07%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main   #11118      +/-   ##
============================================
+ Coverage     71.15%   71.23%   +0.07%     
- Complexity    58804    58813       +9     
============================================
  Files          4883     4883              
  Lines        277144   277144              
  Branches      40281    40281              
============================================
+ Hits         197200   197411     +211     
+ Misses        63509    63276     -233     
- Partials      16435    16457      +22

see 461 files with indirect coverage changes

jed326 · 2023-11-13T01:35:38Z

https://build.ci.opensearch.org/job/gradle-check/29830/

jed326 · 2023-11-13T21:14:35Z

Will backport this manually with #11181

@reta @andrross could you help review + merge this? Thanks!

…ct#11118) * IndexStatsIT.java * SearchTimeoutIT.java * NaNSortingIT.java * NestedIT.java * RangeIT.java Signed-off-by: Jay Deng <jayd0104@gmail.com>

* Add indexRandomForConcurrentSearch method to tests: (#11118) * IndexStatsIT.java * SearchTimeoutIT.java * NaNSortingIT.java * NestedIT.java * RangeIT.java Signed-off-by: Jay Deng <jayd0104@gmail.com> * Add indexRandomForConcurrentSearch for tests: (#11181) * MultiSearchIT.java * SimpleNestedIT.java * SearchPreferenceIT.java * SimpleQueryStringIT.java * ScriptQuerySearchIT.java Signed-off-by: Jay Deng <jayd0104@gmail.com> * Fix tests for concurrent search with IndexRandomForConcurrentSearch follow-up [#11130] (#11212) Signed-off-by: Ganesh Ramadurai <ganeshkrishna2396@gmail.com> Co-authored-by: Ganesh Ramadurai <ganeshkrishna2396@gmail.com> * Fix tests for concurrent search (#11130) Signed-off-by: Ganesh Ramadurai <ganeshkrishna2396@gmail.com> Signed-off-by: Ganesh Ramadurai <gramadur@amazon.com> Co-authored-by: Ganesh Ramadurai <ganeshkrishna2396@gmail.com> * Fixing the tests for concurrent search (#11076) * Fixing the tests for concurrent search Signed-off-by: Bansi Kasundra <kasundra@amazon.com> * Remove changes for non-flaky tests Signed-off-by: Bansi Kasundra <kasundra@amazon.com> --------- Signed-off-by: Bansi Kasundra <kasundra@amazon.com> * Fixed test cases for concurrent search (#11184) Updated flaky and failing test cases after changes to indexRandomForConcurrentSearch Remove unnecessary call to indexRandomForConcurrentSearch in testSearchAndRelocateConcurrently Signed-off-by: Ethan Emoto <eemoto@amazon.com> --------- Signed-off-by: Jay Deng <jayd0104@gmail.com> Signed-off-by: Ganesh Ramadurai <ganeshkrishna2396@gmail.com> Signed-off-by: Ganesh Ramadurai <gramadur@amazon.com> Signed-off-by: Bansi Kasundra <kasundra@amazon.com> Signed-off-by: Ethan Emoto <eemoto@amazon.com> Co-authored-by: Ganesh Krishna Ramadurai <gramadur@icloud.com> Co-authored-by: Ganesh Ramadurai <ganeshkrishna2396@gmail.com> Co-authored-by: Bansi Kasundra <66969140+kasundra07@users.noreply.github.com> Co-authored-by: Ethan Emoto <70109490+e-emoto@users.noreply.github.com>

…ct#11118) * IndexStatsIT.java * SearchTimeoutIT.java * NaNSortingIT.java * NestedIT.java * RangeIT.java Signed-off-by: Jay Deng <jayd0104@gmail.com>

…ct#11118) * IndexStatsIT.java * SearchTimeoutIT.java * NaNSortingIT.java * NestedIT.java * RangeIT.java Signed-off-by: Jay Deng <jayd0104@gmail.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>

jed326 added the skip-changelog label Nov 6, 2023

jed326 marked this pull request as ready for review November 6, 2023 23:53

jed326 force-pushed the cs-slices branch from d0fe82f to 53a4866 Compare November 11, 2023 00:22

neetikasinghal reviewed Nov 11, 2023

View reviewed changes

server/src/internalClusterTest/java/org/opensearch/search/SearchTimeoutIT.java Show resolved Hide resolved

jed326 force-pushed the cs-slices branch from 53a4866 to 1c7f942 Compare November 11, 2023 00:35

jed326 mentioned this pull request Nov 11, 2023

[BUG] SearchQueryIT.testMatchQueryZeroTermsQuery, SearchQueryIT.testSearchEmptyDoc, SearchQueryIT.testMultiMatchQueryZeroTermsQuery & SearchQueryIT.testIssue3177 & SearchQueryIT.testCommonTermsQuery for concurrent search are failing #11074

Closed

jed326 force-pushed the cs-slices branch 2 times, most recently from f324e7b to c3ede5e Compare November 11, 2023 02:20

Add indexRandomForConcurrentSearch method to tests:

abfd13a

* IndexStatsIT.java * SearchTimeoutIT.java * NaNSortingIT.java * NestedIT.java * RangeIT.java Signed-off-by: Jay Deng <jayd0104@gmail.com>

jed326 force-pushed the cs-slices branch from c3ede5e to abfd13a Compare November 11, 2023 05:59

neetikasinghal approved these changes Nov 13, 2023

View reviewed changes

jed326 removed the backport 2.x Backport to 2.x branch label Nov 13, 2023

jed326 mentioned this pull request Nov 13, 2023

Add indexRandomForConcurrentSearch for tests: #11181

Merged

8 tasks

andrross approved these changes Nov 13, 2023

View reviewed changes

andrross merged commit 6c980bc into opensearch-project:main Nov 13, 2023
30 checks passed

jed326 mentioned this pull request Nov 14, 2023

[Backport 2.x] Add indexRandomForConcurrentSearch for tests #11204

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add indexRandomForConcurrentSearch method to tests: #11118

Add indexRandomForConcurrentSearch method to tests: #11118

jed326 commented Nov 6, 2023 •

edited

Loading

github-actions bot commented Nov 6, 2023

jed326 commented Nov 6, 2023

github-actions bot commented Nov 6, 2023 •

edited

Loading

github-actions bot commented Nov 11, 2023

github-actions bot commented Nov 11, 2023

jed326 commented Nov 11, 2023

github-actions bot commented Nov 11, 2023

github-actions bot commented Nov 11, 2023

github-actions bot commented Nov 11, 2023

github-actions bot commented Nov 11, 2023

github-actions bot commented Nov 11, 2023

codecov bot commented Nov 11, 2023

jed326 commented Nov 13, 2023

jed326 commented Nov 13, 2023

Add indexRandomForConcurrentSearch method to tests: #11118

Add indexRandomForConcurrentSearch method to tests: #11118

Conversation

jed326 commented Nov 6, 2023 • edited Loading

Description

Check List

github-actions bot commented Nov 6, 2023

Gradle Check (Jenkins) Run Completed with:

jed326 commented Nov 6, 2023

github-actions bot commented Nov 6, 2023 • edited Loading

Compatibility status:

Incompatible components

Skipped components

Compatible components

github-actions bot commented Nov 11, 2023

github-actions bot commented Nov 11, 2023

jed326 commented Nov 11, 2023

github-actions bot commented Nov 11, 2023

github-actions bot commented Nov 11, 2023

github-actions bot commented Nov 11, 2023

github-actions bot commented Nov 11, 2023

github-actions bot commented Nov 11, 2023

codecov bot commented Nov 11, 2023

Codecov Report

jed326 commented Nov 13, 2023

jed326 commented Nov 13, 2023

jed326 commented Nov 6, 2023 •

edited

Loading

github-actions bot commented Nov 6, 2023 •

edited

Loading