-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add indexRandomForConcurrentSearch for tests: #11181
Conversation
Will backport this manually with #11118 |
server/src/internalClusterTest/java/org/opensearch/search/nested/SimpleNestedIT.java
Show resolved
Hide resolved
Compatibility status:Checks if related components are compatible with change af84e28 Incompatible componentsIncompatible components: [https://github.com/opensearch-project/performance-analyzer.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git] |
❌ Gradle check result for b89a3bd: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
b89a3bd
to
cb700e2
Compare
❌ Gradle check result for cb700e2: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
cb700e2
to
0dc7bed
Compare
Tracking the bugfix for the muted flaky tests here: |
0dc7bed
to
d774636
Compare
❌ Gradle check result for d774636: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
* MultiSearchIT.java * SimpleNestedIT.java * SearchPreferenceIT.java * SimpleQueryStringIT.java * ScriptQuerySearchIT.java Signed-off-by: Jay Deng <jayd0104@gmail.com>
d774636
to
af84e28
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11181 +/- ##
============================================
+ Coverage 71.12% 71.15% +0.02%
- Complexity 58788 58799 +11
============================================
Files 4883 4883
Lines 277152 277152
Branches 40281 40281
============================================
+ Hits 197134 197194 +60
+ Misses 63545 63448 -97
- Partials 16473 16510 +37 ☔ View full report in Codecov by Sentry. |
❕ Gradle check result for af84e28: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
* MultiSearchIT.java * SimpleNestedIT.java * SearchPreferenceIT.java * SimpleQueryStringIT.java * ScriptQuerySearchIT.java Signed-off-by: Jay Deng <jayd0104@gmail.com>
* MultiSearchIT.java * SimpleNestedIT.java * SearchPreferenceIT.java * SimpleQueryStringIT.java * ScriptQuerySearchIT.java Signed-off-by: Jay Deng <jayd0104@gmail.com>
* MultiSearchIT.java * SimpleNestedIT.java * SearchPreferenceIT.java * SimpleQueryStringIT.java * ScriptQuerySearchIT.java Signed-off-by: Jay Deng <jayd0104@gmail.com>
* Add indexRandomForConcurrentSearch method to tests: (#11118) * IndexStatsIT.java * SearchTimeoutIT.java * NaNSortingIT.java * NestedIT.java * RangeIT.java Signed-off-by: Jay Deng <jayd0104@gmail.com> * Add indexRandomForConcurrentSearch for tests: (#11181) * MultiSearchIT.java * SimpleNestedIT.java * SearchPreferenceIT.java * SimpleQueryStringIT.java * ScriptQuerySearchIT.java Signed-off-by: Jay Deng <jayd0104@gmail.com> * Fix tests for concurrent search with IndexRandomForConcurrentSearch follow-up [#11130] (#11212) Signed-off-by: Ganesh Ramadurai <ganeshkrishna2396@gmail.com> Co-authored-by: Ganesh Ramadurai <ganeshkrishna2396@gmail.com> * Fix tests for concurrent search (#11130) Signed-off-by: Ganesh Ramadurai <ganeshkrishna2396@gmail.com> Signed-off-by: Ganesh Ramadurai <gramadur@amazon.com> Co-authored-by: Ganesh Ramadurai <ganeshkrishna2396@gmail.com> * Fixing the tests for concurrent search (#11076) * Fixing the tests for concurrent search Signed-off-by: Bansi Kasundra <kasundra@amazon.com> * Remove changes for non-flaky tests Signed-off-by: Bansi Kasundra <kasundra@amazon.com> --------- Signed-off-by: Bansi Kasundra <kasundra@amazon.com> * Fixed test cases for concurrent search (#11184) Updated flaky and failing test cases after changes to indexRandomForConcurrentSearch Remove unnecessary call to indexRandomForConcurrentSearch in testSearchAndRelocateConcurrently Signed-off-by: Ethan Emoto <eemoto@amazon.com> --------- Signed-off-by: Jay Deng <jayd0104@gmail.com> Signed-off-by: Ganesh Ramadurai <ganeshkrishna2396@gmail.com> Signed-off-by: Ganesh Ramadurai <gramadur@amazon.com> Signed-off-by: Bansi Kasundra <kasundra@amazon.com> Signed-off-by: Ethan Emoto <eemoto@amazon.com> Co-authored-by: Ganesh Krishna Ramadurai <gramadur@icloud.com> Co-authored-by: Ganesh Ramadurai <ganeshkrishna2396@gmail.com> Co-authored-by: Bansi Kasundra <66969140+kasundra07@users.noreply.github.com> Co-authored-by: Ethan Emoto <70109490+e-emoto@users.noreply.github.com>
* MultiSearchIT.java * SimpleNestedIT.java * SearchPreferenceIT.java * SimpleQueryStringIT.java * ScriptQuerySearchIT.java Signed-off-by: Jay Deng <jayd0104@gmail.com>
* MultiSearchIT.java * SimpleNestedIT.java * SearchPreferenceIT.java * SimpleQueryStringIT.java * ScriptQuerySearchIT.java Signed-off-by: Jay Deng <jayd0104@gmail.com>
* MultiSearchIT.java * SimpleNestedIT.java * SearchPreferenceIT.java * SimpleQueryStringIT.java * ScriptQuerySearchIT.java Signed-off-by: Jay Deng <jayd0104@gmail.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
Follow-up to #11065
Muted tests related to nested sorting that are flaky
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.