fix(linter/prefer-array-flat-map): error for .flat(1.0)
#12360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
CodSpeed Instrumentation Performance ReportMerging #12360 will not alter performanceComparing Summary
|
Member
Author
Member
Author
|
Oh bollocks! Looks like both of our solutions are wrong! I'll revise. |
overlookmotel
force-pushed
the
07-17-fix_linter_prefer-array-flat-map_error_for_.flat_1.0_
branch
from
27037cb to
9c415b0
Compare
Member
Author
|
Well that was pretty complicated for a simple lint rule! |
Contributor
Merge activity
|
Previously this rule did not produce an error for `.map(f).flat(1.0)`. This PR fixes that. Also round down the argument and produce errors for e.g. `.map(f).flat(1.9)`. This follows ECMA spec (see comments in code), and I've also verified that all the weird test cases match behavior of `.flat(...)` in NodeJS.
graphite-app
bot
force-pushed
the
07-17-fix_linter_prefer-array-flat-map_error_for_.flat_1.0_
branch
from
9c415b0 to
119d23a
Compare
graphite-app
bot
deleted the
07-17-fix_linter_prefer-array-flat-map_error_for_.flat_1.0_
branch
camc314
added a commit
that referenced
this pull request
Jul 22, 2025
## [1.8.0] - 2025-07-22 ### 🚀 Features - 6d2b549 napi/oxlint: Pass AST in buffer to JS (#12350) (overlookmotel) - 14f0159 linter/exhaustive-deps: Add auto-fixer (#12354) (Don Isaac) ### 🐛 Bug Fixes - 99e105f linter: Correct autofix in `unicorn/prefer-number-properties` for Infinity (#12445) (yefan) - 0b539e3 linter: `unicorn/catch-error-name` wasn't using the ignore property (#12446) (Parbez) - 05fba9b linter: Don't panic on `TSNonNullExpression` in `unicorn/prefer-array-find` (#12400) (Sysix) - 46e33d5 linter: Improve error handling in config file lookup (#12391) (camc314) - 4621872 linter: Parse second script block for `svelte` files (#12390) (Sysix) - fbe7eb4 linter/filename-case: Fix default config when no config is provided (#12389) (camc314) - fea9df4 linter: Report errors with the correct severity for custom plugins (#12362) (camc314) - 652c038 linter: Mark correctly enabled default rules for `--rules` (#12163) (Sysix) - eadc359 linter: Correct source text for vue files having script attributes containig ">" char inside (#12375) (Sysix) - 54d143a linter/exhaustive-deps: More descriptive messages for always-rerender violations (#12336) (Don Isaac) - dac4db9 linter/exhaustive-deps: Better diagnostics for missing dependencies (#12337) (Don Isaac) - 119d23a linter/prefer-array-flat-map: Error for `.flat(1.0)` (#12360) (overlookmotel) ### 🚜 Refactor - 2d9291c linter/prefer-number-properties: Simplify fixer logic (#12451) (camc314) - c5dff1e linter, napi/parser: Add `source_len` field to `RawTransferMetadata` (#12383) (overlookmotel) - 5e3b415 linter: Duplicate `RawTransferMetadata` in `oxc_linter` crate (#12382) (overlookmotel) - 773fd88 linter: Pass `&Allocator` into `Linter::run_external_rules` (#12374) (overlookmotel) - b10ed11 linter: Make unwrap unconditional (#12371) (overlookmotel) - a0631d4 linter: Move running external rules into feature-gated function (#12370) (overlookmotel) - 4fc4e7c linter: Make feature gates for `oxlint2` feature consistent (#12369) (overlookmotel) - 50b1786 linter: Clarify usage of `Allocator` and `AllocatorGuard` (#12332) (overlookmotel) - 26d3a39 linter: Remove `ModuleContentOwner` abstraction (#12331) (overlookmotel) ### 📚 Documentation - 3c21d94 linter: Correct comment on `RawTransferMetadata2` type (#12428) (overlookmotel) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this rule did not produce an error for
.map(f).flat(1.0). This PR fixes that.Also round down the argument and produce errors for e.g.
.map(f).flat(1.9). This follows ECMA spec (see comments in code), and I've also verified that all the weird test cases match behavior of.flat(...)in NodeJS.