refactor(linter): move running external rules into feature-gated function #12370

overlookmotel · 2025-07-17T14:23:00Z

Move running external rules into a separate function and feature gate it. The gate is needed so it can use methods which only exist when the feature is enabled in later PRs.

overlookmotel · 2025-07-17T14:23:16Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2025-07-17T14:29:14Z

CodSpeed Instrumentation Performance Report

Merging #12370 will not alter performance

_{Comparing 07-17-refactor_linter_move_running_external_rules_into_feature-gated_function (a0631d4) with main (f4e06c8)}

Summary

✅ 34 untouched benchmarks

crates/oxc_linter/src/lib.rs

camc314 · 2025-07-17T16:24:03Z

Merge activity

Jul 17, 4:24 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Jul 17, 4:27 PM UTC: camc314 added this pull request to the Graphite merge queue.
Jul 17, 4:30 PM UTC: Merged by the Graphite merge queue.

overlookmotel · 2025-07-17T16:27:12Z

Thanks for reviewing so swiftly @camc314.

These #[cfg(all(feature = "oxlint2", not(feature = "disable_oxlint2")))] attributes are getting out of hand! I guess at least it's a temporary measure. Before too long oxlint2 will become the new oxlint.

…tion (#12370) Move running external rules into a separate function and feature gate it. The gate is needed so it can use methods which only exist when the feature is enabled in later PRs.

camc314 · 2025-07-17T16:28:37Z

We may have to keep them (or a version of them), if we want to allow oxlint to be ran as a pure binary (no node), but that's a decision for a later date.

## [1.8.0] - 2025-07-22 ### 🚀 Features - 6d2b549 napi/oxlint: Pass AST in buffer to JS (#12350) (overlookmotel) - 14f0159 linter/exhaustive-deps: Add auto-fixer (#12354) (Don Isaac) ### 🐛 Bug Fixes - 99e105f linter: Correct autofix in `unicorn/prefer-number-properties` for Infinity (#12445) (yefan) - 0b539e3 linter: `unicorn/catch-error-name` wasn't using the ignore property (#12446) (Parbez) - 05fba9b linter: Don't panic on `TSNonNullExpression` in `unicorn/prefer-array-find` (#12400) (Sysix) - 46e33d5 linter: Improve error handling in config file lookup (#12391) (camc314) - 4621872 linter: Parse second script block for `svelte` files (#12390) (Sysix) - fbe7eb4 linter/filename-case: Fix default config when no config is provided (#12389) (camc314) - fea9df4 linter: Report errors with the correct severity for custom plugins (#12362) (camc314) - 652c038 linter: Mark correctly enabled default rules for `--rules` (#12163) (Sysix) - eadc359 linter: Correct source text for vue files having script attributes containig ">" char inside (#12375) (Sysix) - 54d143a linter/exhaustive-deps: More descriptive messages for always-rerender violations (#12336) (Don Isaac) - dac4db9 linter/exhaustive-deps: Better diagnostics for missing dependencies (#12337) (Don Isaac) - 119d23a linter/prefer-array-flat-map: Error for `.flat(1.0)` (#12360) (overlookmotel) ### 🚜 Refactor - 2d9291c linter/prefer-number-properties: Simplify fixer logic (#12451) (camc314) - c5dff1e linter, napi/parser: Add `source_len` field to `RawTransferMetadata` (#12383) (overlookmotel) - 5e3b415 linter: Duplicate `RawTransferMetadata` in `oxc_linter` crate (#12382) (overlookmotel) - 773fd88 linter: Pass `&Allocator` into `Linter::run_external_rules` (#12374) (overlookmotel) - b10ed11 linter: Make unwrap unconditional (#12371) (overlookmotel) - a0631d4 linter: Move running external rules into feature-gated function (#12370) (overlookmotel) - 4fc4e7c linter: Make feature gates for `oxlint2` feature consistent (#12369) (overlookmotel) - 50b1786 linter: Clarify usage of `Allocator` and `AllocatorGuard` (#12332) (overlookmotel) - 26d3a39 linter: Remove `ModuleContentOwner` abstraction (#12331) (overlookmotel) ### 📚 Documentation - 3c21d94 linter: Correct comment on `RawTransferMetadata2` type (#12428) (overlookmotel) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jul 17, 2025

overlookmotel mentioned this pull request Jul 17, 2025

refactor(linter): make feature gates for oxlint2 feature consistent #12369

Merged

overlookmotel marked this pull request as ready for review July 17, 2025 14:29

overlookmotel requested a review from camc314 as a code owner July 17, 2025 14:29

overlookmotel mentioned this pull request Jul 17, 2025

refactor(linter): make unwrap unconditional #12371

Merged

overlookmotel force-pushed the 07-17-refactor_linter_make_feature_gates_for_oxlint2_feature_consistent branch from 771de2e to 65b160b Compare July 17, 2025 14:40

overlookmotel force-pushed the 07-17-refactor_linter_move_running_external_rules_into_feature-gated_function branch from 0a182e3 to 3ada6f8 Compare July 17, 2025 14:40

graphite-app bot changed the base branch from 07-17-refactor_linter_make_feature_gates_for_oxlint2_feature_consistent to graphite-base/12370 July 17, 2025 14:53

graphite-app bot force-pushed the 07-17-refactor_linter_move_running_external_rules_into_feature-gated_function branch from 3ada6f8 to 6a5be60 Compare July 17, 2025 14:56

graphite-app bot force-pushed the graphite-base/12370 branch from 65b160b to 4fc4e7c Compare July 17, 2025 14:56

graphite-app bot changed the base branch from graphite-base/12370 to main July 17, 2025 14:57

graphite-app bot force-pushed the 07-17-refactor_linter_move_running_external_rules_into_feature-gated_function branch from 6a5be60 to 72f359b Compare July 17, 2025 14:57

overlookmotel force-pushed the 07-17-refactor_linter_move_running_external_rules_into_feature-gated_function branch from 72f359b to cc5b119 Compare July 17, 2025 16:05

graphite-app bot reviewed Jul 17, 2025

View reviewed changes

crates/oxc_linter/src/lib.rs Outdated Show resolved Hide resolved

camc314 added the 0-merge Merge with Graphite Merge Queue label Jul 17, 2025

overlookmotel force-pushed the 07-17-refactor_linter_move_running_external_rules_into_feature-gated_function branch from cc5b119 to 94812c2 Compare July 17, 2025 16:23

refactor(linter): move running external rules into feature-gated func…

a0631d4

…tion (#12370) Move running external rules into a separate function and feature gate it. The gate is needed so it can use methods which only exist when the feature is enabled in later PRs.

graphite-app bot force-pushed the 07-17-refactor_linter_move_running_external_rules_into_feature-gated_function branch from 94812c2 to a0631d4 Compare July 17, 2025 16:28

graphite-app bot merged commit a0631d4 into main Jul 17, 2025
23 checks passed

graphite-app bot deleted the 07-17-refactor_linter_move_running_external_rules_into_feature-gated_function branch July 17, 2025 16:30

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 17, 2025

oxc-bot mentioned this pull request Jul 22, 2025

release(oxlint): v1.8.0 #12452

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

refactor(linter): move running external rules into feature-gated function #12370

refactor(linter): move running external rules into feature-gated function #12370

Uh oh!

overlookmotel commented Jul 17, 2025 •

edited

Loading

Uh oh!

overlookmotel commented Jul 17, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Jul 17, 2025 •

edited

Loading

Uh oh!

Uh oh!

camc314 commented Jul 17, 2025 •

edited by graphite-app bot

Loading

Uh oh!

overlookmotel commented Jul 17, 2025

Uh oh!

camc314 commented Jul 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

refactor(linter): move running external rules into feature-gated function #12370

refactor(linter): move running external rules into feature-gated function #12370

Uh oh!

Conversation

overlookmotel commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

overlookmotel commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Instrumentation Performance Report

Merging #12370 will not alter performance

Summary

Uh oh!

Uh oh!

camc314 commented Jul 17, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

overlookmotel commented Jul 17, 2025

Uh oh!

camc314 commented Jul 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

overlookmotel commented Jul 17, 2025 •

edited

Loading

overlookmotel commented Jul 17, 2025 •

edited

Loading

codspeed-hq bot commented Jul 17, 2025 •

edited

Loading

camc314 commented Jul 17, 2025 •

edited by graphite-app bot

Loading