Skip to content

fix(linter): report errors with the correct severity for custom plugins #12362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2025
Merged

fix(linter): report errors with the correct severity for custom plugins #12362

merged 1 commit into from
Jul 18, 2025

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Jul 17, 2025

No description provided.

@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Jul 17, 2025
@camc314 camc314 force-pushed the c/07-17-fix_linter_report_errors_with_the_correct_severity_for_custom_plugins branch from dae00d2 to 68fc54d Compare July 17, 2025 13:34
@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Jul 17, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 marked this pull request as ready for review July 17, 2025 13:34
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 17, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #12362 will not alter performance

Comparing c/07-17-fix_linter_report_errors_with_the_correct_severity_for_custom_plugins (fea9df4) with main (4528a2e)

Summary

✅ 34 untouched benchmarks

@camc314 camc314 requested a review from overlookmotel July 17, 2025 13:43
@camc314 camc314 force-pushed the c/07-17-fix_linter_report_errors_with_the_correct_severity_for_custom_plugins branch from 68fc54d to 39b70a3 Compare July 18, 2025 09:33
@camc314 camc314 changed the base branch from main to graphite-base/12362 July 18, 2025 09:44
@camc314 camc314 force-pushed the c/07-17-fix_linter_report_errors_with_the_correct_severity_for_custom_plugins branch from 39b70a3 to 2afd861 Compare July 18, 2025 09:44
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jul 18, 2025
@camc314 camc314 changed the base branch from graphite-base/12362 to c/07-17-fix_tests_update_describe_block_to_reflect_correct_cli_context July 18, 2025 09:44
@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Jul 18, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Jul 18, 9:44 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jul 18, 9:45 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jul 18, 10:00 AM UTC: camc314 added this pull request to the Graphite merge queue.
  • Jul 18, 10:10 AM UTC: Merged by the Graphite merge queue.

@camc314 camc314 mentioned this pull request Jul 18, 2025
Merged
@camc314 camc314 force-pushed the c/07-17-fix_linter_report_errors_with_the_correct_severity_for_custom_plugins branch from 2afd861 to d4e5d2a Compare July 18, 2025 09:45
@graphite-app graphite-app bot changed the base branch from c/07-17-fix_tests_update_describe_block_to_reflect_correct_cli_context to graphite-base/12362 July 18, 2025 09:45
@camc314 camc314 changed the base branch from graphite-base/12362 to c/07-17-fix_tests_update_describe_block_to_reflect_correct_cli_context July 18, 2025 09:45
Base automatically changed from c/07-17-fix_tests_update_describe_block_to_reflect_correct_cli_context to main July 18, 2025 09:53
@graphite-app graphite-app bot force-pushed the c/07-17-fix_linter_report_errors_with_the_correct_severity_for_custom_plugins branch from d4e5d2a to c17f66a Compare July 18, 2025 09:53
@graphite-app graphite-app bot force-pushed the c/07-17-fix_linter_report_errors_with_the_correct_severity_for_custom_plugins branch from c17f66a to fea9df4 Compare July 18, 2025 10:02
@graphite-app graphite-app bot merged commit fea9df4 into main Jul 18, 2025
24 checks passed
@graphite-app graphite-app bot deleted the c/07-17-fix_linter_report_errors_with_the_correct_severity_for_custom_plugins branch July 18, 2025 10:10
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 18, 2025
@oxc-bot oxc-bot mentioned this pull request Jul 22, 2025
Merged
camc314 added a commit that referenced this pull request Jul 22, 2025
@oxc-bot @camc314
release(oxlint): v1.8.0 (#12452)
0b17927 
## [1.8.0] - 2025-07-22

### 🚀 Features

- 6d2b549 napi/oxlint: Pass AST in buffer to JS (#12350) (overlookmotel)
- 14f0159 linter/exhaustive-deps: Add auto-fixer (#12354) (Don Isaac)

### 🐛 Bug Fixes

- 99e105f linter: Correct autofix in `unicorn/prefer-number-properties`
for Infinity (#12445) (yefan)
- 0b539e3 linter: `unicorn/catch-error-name` wasn't using the ignore
property (#12446) (Parbez)
- 05fba9b linter: Don't panic on `TSNonNullExpression` in
`unicorn/prefer-array-find` (#12400) (Sysix)
- 46e33d5 linter: Improve error handling in config file lookup (#12391)
(camc314)
- 4621872 linter: Parse second script block for `svelte` files (#12390)
(Sysix)
- fbe7eb4 linter/filename-case: Fix default config when no config is
provided (#12389) (camc314)
- fea9df4 linter: Report errors with the correct severity for custom
plugins (#12362) (camc314)
- 652c038 linter: Mark correctly enabled default rules for `--rules`
(#12163) (Sysix)
- eadc359 linter: Correct source text for vue files having script
attributes containig ">" char inside (#12375) (Sysix)
- 54d143a linter/exhaustive-deps: More descriptive messages for
always-rerender violations (#12336) (Don Isaac)
- dac4db9 linter/exhaustive-deps: Better diagnostics for missing
dependencies (#12337) (Don Isaac)
- 119d23a linter/prefer-array-flat-map: Error for `.flat(1.0)` (#12360)
(overlookmotel)

### 🚜 Refactor

- 2d9291c linter/prefer-number-properties: Simplify fixer logic (#12451)
(camc314)
- c5dff1e linter, napi/parser: Add `source_len` field to
`RawTransferMetadata` (#12383) (overlookmotel)
- 5e3b415 linter: Duplicate `RawTransferMetadata` in `oxc_linter` crate
(#12382) (overlookmotel)
- 773fd88 linter: Pass `&Allocator` into `Linter::run_external_rules`
(#12374) (overlookmotel)
- b10ed11 linter: Make unwrap unconditional (#12371) (overlookmotel)
- a0631d4 linter: Move running external rules into feature-gated
function (#12370) (overlookmotel)
- 4fc4e7c linter: Make feature gates for `oxlint2` feature consistent
(#12369) (overlookmotel)
- 50b1786 linter: Clarify usage of `Allocator` and `AllocatorGuard`
(#12332) (overlookmotel)
- 26d3a39 linter: Remove `ModuleContentOwner` abstraction (#12331)
(overlookmotel)

### 📚 Documentation

- 3c21d94 linter: Correct comment on `RawTransferMetadata2` type
(#12428) (overlookmotel)

Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@overlookmotel overlookmotel Awaiting requested review from overlookmotel

Assignees

No one assigned

Labels

A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@camc314