feat(napi/oxlint): pass AST in buffer to JS #12350

overlookmotel · 2025-07-17T04:16:27Z

First working prototype of JS linter plugins.

Rust now passes the AST to JS via buffer, and lint rule runner uses the JS rule's provided visitor to traverse the AST using lazy deserialization.

Only a single rule is supported at present.

Before anyone gets too excited, this is very much unfinished! It's incomplete, the AST is not compliant with ESTree, and it's not well tested. Really this is a proof of concept more than a usable feature at present. But we'll get there...

overlookmotel · 2025-07-17T04:16:45Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2025-07-18T02:51:17Z

CodSpeed Instrumentation Performance Report

Merging #12350 will not alter performance

_{Comparing 07-17-feat_napi_oxlint_pass_ast_in_buffer_to_js (6d2b549) with main (c5dff1e)}

Summary

✅ 34 untouched benchmarks

camc314 · 2025-07-18T09:31:35Z

Merge activity

Jul 18, 9:31 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Jul 18, 9:31 AM UTC: camc314 added this pull request to the Graphite merge queue.
Jul 18, 9:40 AM UTC: Merged by the Graphite merge queue.

First working prototype of JS linter plugins. Rust now passes the AST to JS via buffer, and lint rule runner uses the JS rule's provided visitor to traverse the AST using lazy deserialization. Only a single rule is supported at present. Before anyone gets too excited, this is very much unfinished! It's incomplete, the AST is not compliant with ESTree, and it's not well tested. Really this is a proof of concept more than a usable feature at present. But we'll get there...

## [1.8.0] - 2025-07-22 ### 🚀 Features - 6d2b549 napi/oxlint: Pass AST in buffer to JS (#12350) (overlookmotel) - 14f0159 linter/exhaustive-deps: Add auto-fixer (#12354) (Don Isaac) ### 🐛 Bug Fixes - 99e105f linter: Correct autofix in `unicorn/prefer-number-properties` for Infinity (#12445) (yefan) - 0b539e3 linter: `unicorn/catch-error-name` wasn't using the ignore property (#12446) (Parbez) - 05fba9b linter: Don't panic on `TSNonNullExpression` in `unicorn/prefer-array-find` (#12400) (Sysix) - 46e33d5 linter: Improve error handling in config file lookup (#12391) (camc314) - 4621872 linter: Parse second script block for `svelte` files (#12390) (Sysix) - fbe7eb4 linter/filename-case: Fix default config when no config is provided (#12389) (camc314) - fea9df4 linter: Report errors with the correct severity for custom plugins (#12362) (camc314) - 652c038 linter: Mark correctly enabled default rules for `--rules` (#12163) (Sysix) - eadc359 linter: Correct source text for vue files having script attributes containig ">" char inside (#12375) (Sysix) - 54d143a linter/exhaustive-deps: More descriptive messages for always-rerender violations (#12336) (Don Isaac) - dac4db9 linter/exhaustive-deps: Better diagnostics for missing dependencies (#12337) (Don Isaac) - 119d23a linter/prefer-array-flat-map: Error for `.flat(1.0)` (#12360) (overlookmotel) ### 🚜 Refactor - 2d9291c linter/prefer-number-properties: Simplify fixer logic (#12451) (camc314) - c5dff1e linter, napi/parser: Add `source_len` field to `RawTransferMetadata` (#12383) (overlookmotel) - 5e3b415 linter: Duplicate `RawTransferMetadata` in `oxc_linter` crate (#12382) (overlookmotel) - 773fd88 linter: Pass `&Allocator` into `Linter::run_external_rules` (#12374) (overlookmotel) - b10ed11 linter: Make unwrap unconditional (#12371) (overlookmotel) - a0631d4 linter: Move running external rules into feature-gated function (#12370) (overlookmotel) - 4fc4e7c linter: Make feature gates for `oxlint2` feature consistent (#12369) (overlookmotel) - 50b1786 linter: Clarify usage of `Allocator` and `AllocatorGuard` (#12332) (overlookmotel) - 26d3a39 linter: Remove `ModuleContentOwner` abstraction (#12331) (overlookmotel) ### 📚 Documentation - 3c21d94 linter: Correct comment on `RawTransferMetadata2` type (#12428) (overlookmotel) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

This was referenced Jul 17, 2025

test(napi/oxlint): add test case with many files #12342

Merged

fix(napi/oxlint): use process.exitCode #12344

Merged

github-actions bot added A-linter Area - Linter A-ast-tools Area - AST tools C-enhancement Category - New feature or request labels Jul 17, 2025

overlookmotel mentioned this pull request Jul 17, 2025

refactor(linter): pass &Allocator into Linter::run #12349

Closed

graphite-app bot force-pushed the 07-16-refactor_linter_pass_allocator_into_linter_run_ branch from 85db259 to 822eb6c Compare July 17, 2025 09:22

graphite-app bot force-pushed the 07-17-feat_napi_oxlint_pass_ast_in_buffer_to_js branch from 57c093f to 6a8df5d Compare July 17, 2025 09:23

This was referenced Jul 17, 2025

refactor(linter): move running external rules into feature-gated function #12370

Merged

refactor(linter): make feature gates for oxlint2 feature consistent #12369

Merged

refactor(linter): make unwrap unconditional #12371

Merged

graphite-app bot force-pushed the 07-16-refactor_linter_pass_allocator_into_linter_run_ branch from 822eb6c to c6941c8 Compare July 17, 2025 15:00

overlookmotel changed the base branch from 07-16-refactor_linter_pass_allocator_into_linter_run_ to graphite-base/12350 July 18, 2025 02:47

overlookmotel force-pushed the 07-17-feat_napi_oxlint_pass_ast_in_buffer_to_js branch from 6a8df5d to 4cecb6b Compare July 18, 2025 02:47

overlookmotel force-pushed the graphite-base/12350 branch from c6941c8 to 77b2953 Compare July 18, 2025 02:47

overlookmotel changed the base branch from graphite-base/12350 to 07-17-refactor_linter_napi_parser_add_source_len_field_to_rawtransfermetadata_ July 18, 2025 02:47

overlookmotel marked this pull request as ready for review July 18, 2025 02:56

overlookmotel requested a review from camc314 as a code owner July 18, 2025 02:56

overlookmotel force-pushed the 07-17-feat_napi_oxlint_pass_ast_in_buffer_to_js branch from 4cecb6b to 1192531 Compare July 18, 2025 02:58

graphite-app bot changed the base branch from 07-17-refactor_linter_napi_parser_add_source_len_field_to_rawtransfermetadata_ to graphite-base/12350 July 18, 2025 09:02

graphite-app bot force-pushed the graphite-base/12350 branch from 77b2953 to c5dff1e Compare July 18, 2025 09:16

graphite-app bot force-pushed the 07-17-feat_napi_oxlint_pass_ast_in_buffer_to_js branch from 1192531 to e5603c1 Compare July 18, 2025 09:16

graphite-app bot changed the base branch from graphite-base/12350 to main July 18, 2025 09:17

graphite-app bot force-pushed the 07-17-feat_napi_oxlint_pass_ast_in_buffer_to_js branch from e5603c1 to 8b4d616 Compare July 18, 2025 09:17

camc314 added the 0-merge Merge with Graphite Merge Queue label Jul 18, 2025

graphite-app bot force-pushed the 07-17-feat_napi_oxlint_pass_ast_in_buffer_to_js branch from 8b4d616 to 6d2b549 Compare July 18, 2025 09:32

graphite-app bot merged commit 6d2b549 into main Jul 18, 2025
26 checks passed

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 18, 2025

graphite-app bot deleted the 07-17-feat_napi_oxlint_pass_ast_in_buffer_to_js branch July 18, 2025 09:40

Boshen mentioned this pull request Jul 19, 2025

☂️ Oxlint Custom JavaScript Plugin Milestone 1 #9905

Closed

This was referenced Jul 20, 2025

release(crates): v0.77.3 #12407

Merged

release(oxlint): v1.8.0 #12452

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(napi/oxlint): pass AST in buffer to JS #12350

feat(napi/oxlint): pass AST in buffer to JS #12350

Uh oh!

overlookmotel commented Jul 17, 2025 •

edited

Loading

Uh oh!

overlookmotel commented Jul 17, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Jul 18, 2025 •

edited

Loading

Uh oh!

camc314 commented Jul 18, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

feat(napi/oxlint): pass AST in buffer to JS #12350

feat(napi/oxlint): pass AST in buffer to JS #12350

Uh oh!

Conversation

overlookmotel commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

overlookmotel commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Instrumentation Performance Report

Merging #12350 will not alter performance

Summary

Uh oh!

camc314 commented Jul 18, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

overlookmotel commented Jul 17, 2025 •

edited

Loading

overlookmotel commented Jul 17, 2025 •

edited

Loading

codspeed-hq bot commented Jul 18, 2025 •

edited

Loading

camc314 commented Jul 18, 2025 •

edited by graphite-app bot

Loading