Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Sep 9, 2025

Pure refactor. Move all code related to AllocatorPool into a directory together, in preparation for further changes.

@github-actions github-actions bot added A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Sep 9, 2025
Copy link
Member Author

overlookmotel commented Sep 9, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 9, 2025

CodSpeed Instrumentation Performance Report

Merging #13619 will degrade performances by 3.32%

Comparing 09-09-refactor_allocator_pool_move_allocatorpool_into_own_directory (a0d7389) with main (f9bff64)1

Summary

❌ 1 regressions
✅ 36 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
minifier[cal.com.tsx] 31 ms 32 ms -3.32%

Footnotes

  1. No successful run was found on main (a0d7389) during the generation of this report, so f9bff64 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@graphite-app graphite-app bot changed the base branch from 09-09-refactor_all_remove_pub_from_modules_with_no_exports to graphite-base/13619 September 10, 2025 02:39
@graphite-app graphite-app bot force-pushed the graphite-base/13619 branch from ce04759 to babbaca Compare September 10, 2025 02:45
@graphite-app graphite-app bot force-pushed the 09-09-refactor_allocator_pool_move_allocatorpool_into_own_directory branch from 49ba3fd to 6196929 Compare September 10, 2025 02:45
@graphite-app graphite-app bot changed the base branch from graphite-base/13619 to main September 10, 2025 02:46
@graphite-app graphite-app bot force-pushed the 09-09-refactor_allocator_pool_move_allocatorpool_into_own_directory branch from 6196929 to cbef849 Compare September 10, 2025 02:46
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Sep 10, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 10, 2025

Merge activity

…3619)

Pure refactor. Move all code related to `AllocatorPool` into a directory together, in preparation for further changes.
Copilot AI review requested due to automatic review settings September 10, 2025 04:03
@graphite-app graphite-app bot force-pushed the 09-09-refactor_allocator_pool_move_allocatorpool_into_own_directory branch from cbef849 to a0d7389 Compare September 10, 2025 04:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@graphite-app graphite-app bot merged commit a0d7389 into main Sep 10, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 09-09-refactor_allocator_pool_move_allocatorpool_into_own_directory branch September 10, 2025 04:08
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants