refactor(allocator/pool): AllocatorPool::new always create standard pool
#13624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
C-cleanup
This was referenced Sep 9, 2025
Member
Author
This was referenced Sep 9, 2025
overlookmotel
force-pushed
the
09-09-refactor_allocator_pool_allocatorpool_new_always_create_standard_pool
branch
from
e66de41 to
b71acf1
Compare
CodSpeed Instrumentation Performance ReportMerging #13624 will not alter performanceComparing Summary
Footnotes |
camc314
approved these changes
Sep 10, 2025
graphite-app
bot
force-pushed
the
09-09-refactor_linter_plugins_use_fixed-size_allocators_when_externallinter_exists
branch
from
90ff7e9 to
f9bf3d5
Compare
graphite-app
bot
force-pushed
the
09-09-refactor_allocator_pool_allocatorpool_new_always_create_standard_pool
branch
from
b71acf1 to
37fca6b
Compare
Contributor
Merge activity
|
graphite-app
bot
force-pushed
the
09-09-refactor_linter_plugins_use_fixed-size_allocators_when_externallinter_exists
branch
from
f9bf3d5 to
9e5dcbd
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Sep 10, 2025
… pool (#13624) #13622 added `AllocatorPool::new_fixed_size` method to create a fixed-size allocator pool. #13623 switched the linter over to using this method when a fixed-size allocator is required. So now we can make `AllocatorPool::new` do what it's intended to do, and create a standard allocator pool. Strictly speaking this is a breaking change, but I don't think anyone is using the `fixed_size` feature, except for the linter. Without that, this change makes no difference to behavior.
graphite-app
bot
force-pushed
the
09-09-refactor_allocator_pool_allocatorpool_new_always_create_standard_pool
branch
from
37fca6b to
e81da5a
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Sep 10, 2025
…13625) #13622 and #13624 altered what happens when the `fixed_size` Cargo feature is enabled. Previously, enabling that feature altered behavior of `AllocatorPool`. Now the feature is additive - it does nothing on it's own, but only adds additional APIs, and *those APIs* can be used to alter behavior. The purpose of the `disable_fixed_size` Cargo feature was to prevent the `fixed_size` feature being activated when tests are run with `--all-features`. Now that enabling `fixed_size` feature doesn't alter behavior, we don't need to worry about it being enabled in tests. Therefore `disable_fixed_size` feature can be removed. This removes a bunch of `#[cfg]` boilerplate, and ugly hacks which were previously required to workaround feature unification.
… pool (#13624) #13622 added `AllocatorPool::new_fixed_size` method to create a fixed-size allocator pool. #13623 switched the linter over to using this method when a fixed-size allocator is required. So now we can make `AllocatorPool::new` do what it's intended to do, and create a standard allocator pool. Strictly speaking this is a breaking change, but I don't think anyone is using the `fixed_size` feature, except for the linter. Without that, this change makes no difference to behavior.
graphite-app
bot
force-pushed
the
09-09-refactor_linter_plugins_use_fixed-size_allocators_when_externallinter_exists
branch
from
9e5dcbd to
ff9e4fb
Compare
graphite-app
bot
force-pushed
the
09-09-refactor_allocator_pool_allocatorpool_new_always_create_standard_pool
branch
from
e81da5a to
b9bef25
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Sep 10, 2025
…13625) #13622 and #13624 altered what happens when the `fixed_size` Cargo feature is enabled. Previously, enabling that feature altered behavior of `AllocatorPool`. Now the feature is additive - it does nothing on it's own, but only adds additional APIs, and *those APIs* can be used to alter behavior. The purpose of the `disable_fixed_size` Cargo feature was to prevent the `fixed_size` feature being activated when tests are run with `--all-features`. Now that enabling `fixed_size` feature doesn't alter behavior, we don't need to worry about it being enabled in tests. Therefore `disable_fixed_size` feature can be removed. This removes a bunch of `#[cfg]` boilerplate, and ugly hacks which were previously required to workaround feature unification.
Base automatically changed from
09-09-refactor_linter_plugins_use_fixed-size_allocators_when_externallinter_exists
to
main
September 10, 2025 04:22
graphite-app
bot
deleted the
09-09-refactor_allocator_pool_allocatorpool_new_always_create_standard_pool
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#13622 added
AllocatorPool::new_fixed_sizemethod to create a fixed-size allocator pool. #13623 switched the linter over to using this method when a fixed-size allocator is required. So now we can makeAllocatorPool::newdo what it's intended to do, and create a standard allocator pool.Strictly speaking this is a breaking change, but I don't think anyone is using the
fixed_sizefeature, except for the linter. Without that, this change makes no difference to behavior.