refactor(allocator/pool)!: remove `disable_fixed_size` Cargo feature #13625

overlookmotel · 2025-09-09T16:36:42Z

#13622 and #13624 altered what happens when the fixed_size Cargo feature is enabled. Previously, enabling that feature altered behavior of AllocatorPool. Now the feature is additive - it does nothing on it's own, but only adds additional APIs, and those APIs can be used to alter behavior.

The purpose of the disable_fixed_size Cargo feature was to prevent the fixed_size feature being activated when tests are run with --all-features. Now that enabling fixed_size feature doesn't alter behavior, we don't need to worry about it being enabled in tests. Therefore disable_fixed_size feature can be removed.

This removes a bunch of #[cfg] boilerplate, and ugly hacks which were previously required to workaround feature unification.

overlookmotel · 2025-09-09T16:37:06Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2025-09-09T16:46:03Z

CodSpeed Instrumentation Performance Report

Merging #13625 will not alter performance

_{Comparing 09-09-refactor_allocator_pool_remove_disable_fixed_size_cargo_feature (edc70ea) with main (3d27c5b)¹}

Summary

✅ 37 untouched benchmarks

No successful run was found on main (edc70ea) during the generation of this report, so 3d27c5b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

graphite-app · 2025-09-10T04:00:13Z

Merge activity

Sep 10, 4:00 AM UTC: overlookmotel added this pull request to the Graphite merge queue.
Sep 10, 4:23 AM UTC: Merged by the Graphite merge queue.

…13625) #13622 and #13624 altered what happens when the `fixed_size` Cargo feature is enabled. Previously, enabling that feature altered behavior of `AllocatorPool`. Now the feature is additive - it does nothing on it's own, but only adds additional APIs, and *those APIs* can be used to alter behavior. The purpose of the `disable_fixed_size` Cargo feature was to prevent the `fixed_size` feature being activated when tests are run with `--all-features`. Now that enabling `fixed_size` feature doesn't alter behavior, we don't need to worry about it being enabled in tests. Therefore `disable_fixed_size` feature can be removed. This removes a bunch of `#[cfg]` boilerplate, and ugly hacks which were previously required to workaround feature unification.

) Similar to #13625. Remove the `disable_oxlint2` Cargo feature in `oxlint` and `oxc_linter` crates. It's no longer required.

…13625) #13622 and #13624 altered what happens when the `fixed_size` Cargo feature is enabled. Previously, enabling that feature altered behavior of `AllocatorPool`. Now the feature is additive - it does nothing on it's own, but only adds additional APIs, and *those APIs* can be used to alter behavior. The purpose of the `disable_fixed_size` Cargo feature was to prevent the `fixed_size` feature being activated when tests are run with `--all-features`. Now that enabling `fixed_size` feature doesn't alter behavior, we don't need to worry about it being enabled in tests. Therefore `disable_fixed_size` feature can be removed. This removes a bunch of `#[cfg]` boilerplate, and ugly hacks which were previously required to workaround feature unification.

) Similar to #13625. Remove the `disable_oxlint2` Cargo feature in `oxlint` and `oxc_linter` crates. It's no longer required.

## [1.15.0] - 2025-09-11 ### 💥 BREAKING CHANGES - edc70ea allocator/pool: [**BREAKING**] Remove `disable_fixed_size` Cargo feature (#13625) (overlookmotel) ### 🚀 Features - b20b56d linter: Add `vue/no-multiple-slot-args` rule (#13579) (Sysix) - aafe08c linter: Add `vue/define-emits-declaration` rule (#13567) (Sysix) - 2ed5059 linter: Add `vue/define-props-declaration` rule (#13566) (Sysix) - a718c23 linter: Add `vue/valid-define-props` rule (#13565) (Sysix) - 75a673e editor: Support relative path for `oxc.path.server` (#13542) (Sysix) - 4af886b linter: Add `unicorn/no-array-reverse` rule (#13530) (yefan) - 2db32eb data_structures: Add `boxed_slice!` and `boxed_array!` macros (#13596) (overlookmotel) ### 🐛 Bug Fixes - fb9d0f4 language_server: Don't resend diagnostic on save, when `typeAware` is disabled and run is onType (#13604) (YongSeok Jang (장용석)) - 2f36350 editor: Add notice for a possible restart when fixing `filename-case` (#13557) (Sysix) - e17fccc linter: Update `RuleRunner` impl after merge (#13642) (camc314) - 3d27c5b linter/no-unused-private-class-members: False positive with spread expr (#13634) (yefan) - 8314ed5 linter/tsgolint: Correct comment (#13589) (camc314) - 198243b semantic: Dont parse `@` as jsdoc tags inside quotes (#13571) (Gwenn Le Bihan) - 89084d7 linter/custom-plugins: Enforce exact matching for disable directives (#13538) (Copilot) - 277c5e1 linter: Output `eslint-plugin-vue` for vue diagnostics (#13564) (Sysix) - 34d3cde rust: Fix clippy issues (#13540) (Boshen) - 5fccafc linter: `unicorn/prefer-array-flat-map` ignore `React.Children` (#13534) (Sysix) - 7e78e39 linter: Don't panic when parsing regex with multiple parentheses (#13524) (Sysix) - 0d867b1 linter: Skip running tsgolint when no files need type aware linting (#13502) (Copilot) - b677376 language_server: Include the diagnostic of the other linter (#13490) (Sysix) - e87d7bd linter: Parse regex inside `new RegExp()` with parentheses (#13448) (Sysix) - 5990f17 linter: Change `typescript/no-confusing-void-expression` to pedantic (#13473) (Boshen) ### 🚜 Refactor - 7775c21 linter/plugins: Remove `oxlint2` Cargo feature (#13648) (overlookmotel) - 8f37e88 linter: Update tsgolint payload (#13547) (camchenry) - 2d53203 linter/plugins: Move `tokio` usage from `oxc_linter` to `napi/oxlint2` (#13647) (overlookmotel) - 6cd6be2 linter: Add `--experimental-js-plugins` CLI arg (#13658) (overlookmotel) - 476729b linter: Simplify `RuleRunner` trait definition (#13637) (camchenry) - 2f02ac6 linter/plugins: Remove `disable_oxlint2` Cargo feature (#13626) (overlookmotel) - ff9e4fb linter/plugins: Use fixed-size allocators when `ExternalLinter` exists (#13623) (overlookmotel) - f9bff64 linter_codegen: Improve code style for collecting nodes (#13636) (camchenry) - babbaca all: Remove `pub` from modules with no exports (#13618) (overlookmotel) - 91759c6 linter/plugins: Only use `RawTransferFileSystem` if JS plugins registered (#13599) (overlookmotel) - 118020c linter/plugins: Discard `ExternalLinter` if no JS plugins registered (#13598) (overlookmotel) - 8d30bce linter/tsgolint: Report an error if the tsgolint exe could not be found (#13590) (camc314) - bccc276 eslint/for-direction: Clean up implementation and improve documentation (#13532) (Antoine Zanardi) - 1425da2 eslint/default-case-last: Simplify default case last check in switch statement (#13529) (Antoine Zanardi) - d245376 oxlint: Remove unused `runner` module (#13561) (camc314) - 53f2fc1 eslint/default-case: Simplify implementation and enhance readability (#13430) (Antoine Zanardi) - 6f15060 eslint/block-scoped-var: Clean up implementation and improve documentation (#13417) (Antoine Zanardi) - 671e0fd language_server: Only store one instance of a diagnostic (#13514) (Sysix) - 1b425d6 eslint/default-case-last: Simplify implementation and enhance readability (#13515) (Antoine Zanardi) - e4bbbce eslint/default-param-last: Simplify implementation and enhance readability (#13516) (Antoine Zanardi) - e0396fd linter: Remove `static` lifetime from disable directives function argument (#13492) (camc314) ### 📚 Documentation - eb1f167 linter: Note which rules require type info to run on rule page (#13675) (camc314) - e66f93b linter: Fix backtick formatting in no-return-wrap (#13633) (camc314) ### ⚡ Performance - e6a25e7 linter: Remove unnecessary `should_run` check (#13639) (camchenry) - f6a9687 linter: Store rules by AST type in a boxed array (#13578) (overlookmotel) - b81f081 linter: Reduce indirection (#13574) (overlookmotel) - a744aff linter: Skip rules that do not have any relevant node types (#13138) (camchenry) ### 🎨 Styling - e110476 linter: Reformat code (#13573) (overlookmotel) ### 🧪 Testing - 58e6c94 oxlint: Add test for ignorePatterns whitelist (#13372) (Sysix) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

github-actions bot added A-cli Area - CLI C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Sep 9, 2025

This was referenced Sep 9, 2025

refactor(allocator/pool): AllocatorPool::new always create standard pool #13624

Merged

refactor(linter/plugins): remove disable_oxlint2 Cargo feature #13626

Merged

overlookmotel force-pushed the 09-09-refactor_allocator_pool_allocatorpool_new_always_create_standard_pool branch from e66de41 to b71acf1 Compare September 9, 2025 16:45

overlookmotel force-pushed the 09-09-refactor_allocator_pool_remove_disable_fixed_size_cargo_feature branch from 9f155ce to 0444abf Compare September 9, 2025 16:45

overlookmotel marked this pull request as ready for review September 9, 2025 16:59

overlookmotel requested a review from camc314 as a code owner September 9, 2025 16:59

camc314 approved these changes Sep 10, 2025

View reviewed changes

graphite-app bot force-pushed the 09-09-refactor_allocator_pool_allocatorpool_new_always_create_standard_pool branch from b71acf1 to 37fca6b Compare September 10, 2025 02:48

graphite-app bot requested review from Dunqing and leaysgur as code owners September 10, 2025 02:48

graphite-app bot force-pushed the 09-09-refactor_allocator_pool_remove_disable_fixed_size_cargo_feature branch from 0444abf to 933acde Compare September 10, 2025 02:48

graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Sep 10, 2025

overlookmotel removed request for Dunqing and leaysgur September 10, 2025 04:00

graphite-app bot force-pushed the 09-09-refactor_allocator_pool_allocatorpool_new_always_create_standard_pool branch from 37fca6b to e81da5a Compare September 10, 2025 04:05

graphite-app bot force-pushed the 09-09-refactor_allocator_pool_remove_disable_fixed_size_cargo_feature branch from 933acde to 9a2f383 Compare September 10, 2025 04:06

graphite-app bot pushed a commit that referenced this pull request Sep 10, 2025

refactor(linter/plugins): remove disable_oxlint2 Cargo feature (#13626

605010c

) Similar to #13625. Remove the `disable_oxlint2` Cargo feature in `oxlint` and `oxc_linter` crates. It's no longer required.

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 10, 2025

graphite-app bot force-pushed the 09-09-refactor_allocator_pool_allocatorpool_new_always_create_standard_pool branch from e81da5a to b9bef25 Compare September 10, 2025 04:15

graphite-app bot force-pushed the 09-09-refactor_allocator_pool_remove_disable_fixed_size_cargo_feature branch from 9a2f383 to edc70ea Compare September 10, 2025 04:15

graphite-app bot pushed a commit that referenced this pull request Sep 10, 2025

refactor(linter/plugins): remove disable_oxlint2 Cargo feature (#13626

2f02ac6

) Similar to #13625. Remove the `disable_oxlint2` Cargo feature in `oxlint` and `oxc_linter` crates. It's no longer required.

Base automatically changed from 09-09-refactor_allocator_pool_allocatorpool_new_always_create_standard_pool to main September 10, 2025 04:23

graphite-app bot merged commit edc70ea into main Sep 10, 2025
29 checks passed

graphite-app bot deleted the 09-09-refactor_allocator_pool_remove_disable_fixed_size_cargo_feature branch September 10, 2025 04:23

oxc-bot mentioned this pull request Sep 11, 2025

release(oxlint): v1.15.0 #13685

Merged

Boshen mentioned this pull request Sep 15, 2025

release(crates): v0.88.0 #13765

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

refactor(allocator/pool)!: remove `disable_fixed_size` Cargo feature #13625

refactor(allocator/pool)!: remove `disable_fixed_size` Cargo feature #13625

Uh oh!

overlookmotel commented Sep 9, 2025 •

edited

Loading

Uh oh!

overlookmotel commented Sep 9, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Sep 9, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Sep 10, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

refactor(allocator/pool)!: remove disable_fixed_size Cargo feature #13625

refactor(allocator/pool)!: remove disable_fixed_size Cargo feature #13625

Uh oh!

Conversation

overlookmotel commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

overlookmotel commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Instrumentation Performance Report

Merging #13625 will not alter performance

Summary

Footnotes

Uh oh!

graphite-app bot commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

refactor(allocator/pool)!: remove `disable_fixed_size` Cargo feature #13625

refactor(allocator/pool)!: remove `disable_fixed_size` Cargo feature #13625

overlookmotel commented Sep 9, 2025 •

edited

Loading

overlookmotel commented Sep 9, 2025 •

edited

Loading

codspeed-hq bot commented Sep 9, 2025 •

edited

Loading

graphite-app bot commented Sep 10, 2025 •

edited

Loading