fix(rust): fix clippy issues #13540

Boshen · 2025-09-04T06:50:29Z

No description provided.

Boshen · 2025-09-04T06:50:46Z

fix(rust): fix clippy issues #13540 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull Request Overview

This PR fixes various clippy warnings by improving documentation formatting, adding descriptive messages to ignored tests, and updating clippy configuration settings.

Standardized documentation formatting to use consistent bullet points and block quotes
Added descriptive reasons to all #[ignore] test attributes per clippy requirements
Updated Cargo.toml to enable previously disabled clippy lints with explanatory comments

Reviewed Changes

Copilot reviewed 14 out of 25 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
crates/oxc_transformer/src/typescript/class.rs	Fixed documentation formatting to use proper block quote continuation
crates/oxc_transformer/src/plugins/styled_components.rs	Fixed documentation formatting to use proper block quote continuation
crates/oxc_transformer/src/es2020/optional_chaining.rs	Fixed documentation formatting to use proper block quote continuation
crates/oxc_parser/src/lexer/search.rs	Converted documentation examples to use bullet points
crates/oxc_parser/src/js/function.rs	Converted documentation to use bullet points for method types
crates/oxc_minifier/tests/peephole/statement_fusion.rs	Added descriptive reason to ignored test
crates/oxc_minifier/tests/peephole/minimize_exit_points.rs	Added descriptive reasons to multiple ignored tests
crates/oxc_minifier/src/peephole/substitute_alternate_syntax.rs	Added descriptive reason to ignored test
crates/oxc_minifier/src/peephole/replace_known_methods.rs	Added descriptive reasons to multiple ignored tests
crates/oxc_minifier/src/peephole/minimize_conditions.rs	Added descriptive reasons to multiple ignored tests
crates/oxc_data_structures/src/code_buffer.rs	Added missing blank line in documentation
crates/oxc_codegen/tests/integration/esbuild.rs	Added descriptive reasons to ignored tests
Cargo.toml	Updated clippy configuration to enable more lints with explanatory comments
.claude/settings.local.json	Added Claude AI configuration file

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

codspeed-hq · 2025-09-04T06:55:29Z

CodSpeed Instrumentation Performance Report

Merging #13540 will not alter performance

_{Comparing 09-04-fix_rust_fix_clippy_issues (34d3cde) with main (5fccafc)¹}

Summary

✅ 37 untouched benchmarks

No successful run was found on main (34d3cde) during the generation of this report, so 5fccafc was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

graphite-app · 2025-09-04T07:00:03Z

Merge activity

Sep 4, 7:00 AM UTC: Boshen added this pull request to the Graphite merge queue.
Sep 4, 7:05 AM UTC: Merged by the Graphite merge queue.

## [1.15.0] - 2025-09-11 ### 💥 BREAKING CHANGES - edc70ea allocator/pool: [**BREAKING**] Remove `disable_fixed_size` Cargo feature (#13625) (overlookmotel) ### 🚀 Features - b20b56d linter: Add `vue/no-multiple-slot-args` rule (#13579) (Sysix) - aafe08c linter: Add `vue/define-emits-declaration` rule (#13567) (Sysix) - 2ed5059 linter: Add `vue/define-props-declaration` rule (#13566) (Sysix) - a718c23 linter: Add `vue/valid-define-props` rule (#13565) (Sysix) - 75a673e editor: Support relative path for `oxc.path.server` (#13542) (Sysix) - 4af886b linter: Add `unicorn/no-array-reverse` rule (#13530) (yefan) - 2db32eb data_structures: Add `boxed_slice!` and `boxed_array!` macros (#13596) (overlookmotel) ### 🐛 Bug Fixes - fb9d0f4 language_server: Don't resend diagnostic on save, when `typeAware` is disabled and run is onType (#13604) (YongSeok Jang (장용석)) - 2f36350 editor: Add notice for a possible restart when fixing `filename-case` (#13557) (Sysix) - e17fccc linter: Update `RuleRunner` impl after merge (#13642) (camc314) - 3d27c5b linter/no-unused-private-class-members: False positive with spread expr (#13634) (yefan) - 8314ed5 linter/tsgolint: Correct comment (#13589) (camc314) - 198243b semantic: Dont parse `@` as jsdoc tags inside quotes (#13571) (Gwenn Le Bihan) - 89084d7 linter/custom-plugins: Enforce exact matching for disable directives (#13538) (Copilot) - 277c5e1 linter: Output `eslint-plugin-vue` for vue diagnostics (#13564) (Sysix) - 34d3cde rust: Fix clippy issues (#13540) (Boshen) - 5fccafc linter: `unicorn/prefer-array-flat-map` ignore `React.Children` (#13534) (Sysix) - 7e78e39 linter: Don't panic when parsing regex with multiple parentheses (#13524) (Sysix) - 0d867b1 linter: Skip running tsgolint when no files need type aware linting (#13502) (Copilot) - b677376 language_server: Include the diagnostic of the other linter (#13490) (Sysix) - e87d7bd linter: Parse regex inside `new RegExp()` with parentheses (#13448) (Sysix) - 5990f17 linter: Change `typescript/no-confusing-void-expression` to pedantic (#13473) (Boshen) ### 🚜 Refactor - 7775c21 linter/plugins: Remove `oxlint2` Cargo feature (#13648) (overlookmotel) - 8f37e88 linter: Update tsgolint payload (#13547) (camchenry) - 2d53203 linter/plugins: Move `tokio` usage from `oxc_linter` to `napi/oxlint2` (#13647) (overlookmotel) - 6cd6be2 linter: Add `--experimental-js-plugins` CLI arg (#13658) (overlookmotel) - 476729b linter: Simplify `RuleRunner` trait definition (#13637) (camchenry) - 2f02ac6 linter/plugins: Remove `disable_oxlint2` Cargo feature (#13626) (overlookmotel) - ff9e4fb linter/plugins: Use fixed-size allocators when `ExternalLinter` exists (#13623) (overlookmotel) - f9bff64 linter_codegen: Improve code style for collecting nodes (#13636) (camchenry) - babbaca all: Remove `pub` from modules with no exports (#13618) (overlookmotel) - 91759c6 linter/plugins: Only use `RawTransferFileSystem` if JS plugins registered (#13599) (overlookmotel) - 118020c linter/plugins: Discard `ExternalLinter` if no JS plugins registered (#13598) (overlookmotel) - 8d30bce linter/tsgolint: Report an error if the tsgolint exe could not be found (#13590) (camc314) - bccc276 eslint/for-direction: Clean up implementation and improve documentation (#13532) (Antoine Zanardi) - 1425da2 eslint/default-case-last: Simplify default case last check in switch statement (#13529) (Antoine Zanardi) - d245376 oxlint: Remove unused `runner` module (#13561) (camc314) - 53f2fc1 eslint/default-case: Simplify implementation and enhance readability (#13430) (Antoine Zanardi) - 6f15060 eslint/block-scoped-var: Clean up implementation and improve documentation (#13417) (Antoine Zanardi) - 671e0fd language_server: Only store one instance of a diagnostic (#13514) (Sysix) - 1b425d6 eslint/default-case-last: Simplify implementation and enhance readability (#13515) (Antoine Zanardi) - e4bbbce eslint/default-param-last: Simplify implementation and enhance readability (#13516) (Antoine Zanardi) - e0396fd linter: Remove `static` lifetime from disable directives function argument (#13492) (camc314) ### 📚 Documentation - eb1f167 linter: Note which rules require type info to run on rule page (#13675) (camc314) - e66f93b linter: Fix backtick formatting in no-return-wrap (#13633) (camc314) ### ⚡ Performance - e6a25e7 linter: Remove unnecessary `should_run` check (#13639) (camchenry) - f6a9687 linter: Store rules by AST type in a boxed array (#13578) (overlookmotel) - b81f081 linter: Reduce indirection (#13574) (overlookmotel) - a744aff linter: Skip rules that do not have any relevant node types (#13138) (camchenry) ### 🎨 Styling - e110476 linter: Reformat code (#13573) (overlookmotel) ### 🧪 Testing - 58e6c94 oxlint: Add test for ignorePatterns whitelist (#13372) (Sysix) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

Copilot AI review requested due to automatic review settings September 4, 2025 06:50

Boshen requested review from Dunqing, camc314 and overlookmotel as code owners September 4, 2025 06:50

github-actions bot added A-linter Area - Linter A-parser Area - Parser A-minifier Area - Minifier A-transformer Area - Transformer / Transpiler A-codegen Area - Code Generation A-ast-tools Area - AST tools C-bug Category - Bug labels Sep 4, 2025

Copilot AI reviewed Sep 4, 2025

View reviewed changes

Boshen force-pushed the 09-04-fix_rust_fix_clippy_issues branch from a5b49b9 to 1a72212 Compare September 4, 2025 06:54

fix(rust): fix clippy issues (#13540)

34d3cde

graphite-app bot force-pushed the 09-04-fix_rust_fix_clippy_issues branch from 1a72212 to 34d3cde Compare September 4, 2025 07:00

graphite-app bot merged commit 34d3cde into main Sep 4, 2025
25 checks passed

graphite-app bot deleted the 09-04-fix_rust_fix_clippy_issues branch September 4, 2025 07:05

oxc-bot mentioned this pull request Sep 8, 2025

release(crates): v0.87.0 #13587

Merged

Copilot AI pushed a commit that referenced this pull request Sep 8, 2025

fix(rust): fix clippy issues (#13540)

99ce36a

oxc-bot mentioned this pull request Sep 11, 2025

release(oxlint): v1.15.0 #13685

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(rust): fix clippy issues #13540

fix(rust): fix clippy issues #13540

Uh oh!

Boshen commented Sep 4, 2025

Uh oh!

Boshen commented Sep 4, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

codspeed-hq bot commented Sep 4, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Sep 4, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

fix(rust): fix clippy issues #13540

fix(rust): fix clippy issues #13540

Uh oh!

Conversation

Boshen commented Sep 4, 2025

Uh oh!

Boshen commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

codspeed-hq bot commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Instrumentation Performance Report

Merging #13540 will not alter performance

Summary

Footnotes

Uh oh!

graphite-app bot commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Boshen commented Sep 4, 2025 •

edited

Loading

codspeed-hq bot commented Sep 4, 2025 •

edited

Loading

graphite-app bot commented Sep 4, 2025 •

edited

Loading