refactor(linter_codegen): improve code style for collecting nodes #13636

camchenry · 2025-09-10T03:39:27Z

Almost pure refactor. There are some slight styling changes in the rule runner impls file, but other than that, this is just some clean up.

Make the rule runner template string a multiline string, so it is easier to read and edit
Move functions into the if-else detector so we don't need to pass around mutable sets of strings
Replaced BTreeSet with a NodeTypeSet that abstracts over the set manipulation somewhat and offers more utilities specific to the linter codegen

camchenry · 2025-09-10T03:39:42Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

socket-security · 2025-09-10T03:39:49Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@next/eslint-plugin-next@15.5.2
	eslint-plugin-vitest@0.5.4
	@typescript-eslint/eslint-plugin@8.43.0
	eslint-plugin-react-perf@3.3.3
	eslint-plugin-promise@7.2.1
	eslint-plugin-import@2.32.0
	eslint-plugin-jsx-a11y@6.10.2
	eslint-plugin-react@7.37.5
	eslint-plugin-regexp@2.10.0
	eslint-plugin-vue@10.4.0
	eslint-plugin-jest@29.0.1
	eslint-plugin-n@17.21.3
	eslint-plugin-unicorn@61.0.2
	eslint-plugin-react-hooks@5.2.0
	eslint-plugin-jsdoc@55.1.2
	eslint@2.13.1 ⏵ 9.35.0				⁺¹

View full report

codspeed-hq · 2025-09-10T03:43:28Z

CodSpeed Instrumentation Performance Report

Merging #13636 will not alter performance

_{Comparing 09-09-refactor_linter_codegen_improve_code_style_for_collecting_nodes (f9bff64) with main (9fa551a)¹}

Summary

✅ 37 untouched benchmarks

No successful run was found on main (f9bff64) during the generation of this report, so 9fa551a was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

Copilot

Pull Request Overview

This PR refactors the linter codegen module to improve code readability and organization. The changes focus on cleaning up how node types are collected and managed during rule analysis.

Introduces a NodeTypeSet abstraction to replace raw BTreeSet<String> usage
Refactors the if-else detector to encapsulate node type collection logic within the detector itself
Improves code formatting by using multiline template strings for generated code

Reviewed Changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated 2 comments.

File	Description
tasks/linter_codegen/src/main.rs	Introduces `NodeTypeSet` struct, refactors detection logic into methods, and improves template formatting
tasks/linter_codegen/Cargo.toml	Adds `rustc-hash` dependency for `FxHashSet`

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

tasks/linter_codegen/src/main.rs

camc314 · 2025-09-10T03:55:21Z

Merge activity

Sep 10, 3:55 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Sep 10, 3:55 AM UTC: camc314 added this pull request to the Graphite merge queue.
Sep 10, 4:02 AM UTC: Merged by the Graphite merge queue.

…3636) Almost pure refactor. There are some slight styling changes in the rule runner impls file, but other than that, this is just some clean up. - Make the rule runner template string a multiline string, so it is easier to read and edit - Move functions into the if-else detector so we don't need to pass around mutable sets of strings - Replaced BTreeSet with a `NodeTypeSet` that abstracts over the set manipulation somewhat and offers more utilities specific to the linter codegen

…3636) Almost pure refactor. There are some slight styling changes in the rule runner impls file, but other than that, this is just some clean up. - Make the rule runner template string a multiline string, so it is easier to read and edit - Move functions into the if-else detector so we don't need to pass around mutable sets of strings - Replaced BTreeSet with a `NodeTypeSet` that abstracts over the set manipulation somewhat and offers more utilities specific to the linter codegen Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

## [1.15.0] - 2025-09-11 ### 💥 BREAKING CHANGES - edc70ea allocator/pool: [**BREAKING**] Remove `disable_fixed_size` Cargo feature (#13625) (overlookmotel) ### 🚀 Features - b20b56d linter: Add `vue/no-multiple-slot-args` rule (#13579) (Sysix) - aafe08c linter: Add `vue/define-emits-declaration` rule (#13567) (Sysix) - 2ed5059 linter: Add `vue/define-props-declaration` rule (#13566) (Sysix) - a718c23 linter: Add `vue/valid-define-props` rule (#13565) (Sysix) - 75a673e editor: Support relative path for `oxc.path.server` (#13542) (Sysix) - 4af886b linter: Add `unicorn/no-array-reverse` rule (#13530) (yefan) - 2db32eb data_structures: Add `boxed_slice!` and `boxed_array!` macros (#13596) (overlookmotel) ### 🐛 Bug Fixes - fb9d0f4 language_server: Don't resend diagnostic on save, when `typeAware` is disabled and run is onType (#13604) (YongSeok Jang (장용석)) - 2f36350 editor: Add notice for a possible restart when fixing `filename-case` (#13557) (Sysix) - e17fccc linter: Update `RuleRunner` impl after merge (#13642) (camc314) - 3d27c5b linter/no-unused-private-class-members: False positive with spread expr (#13634) (yefan) - 8314ed5 linter/tsgolint: Correct comment (#13589) (camc314) - 198243b semantic: Dont parse `@` as jsdoc tags inside quotes (#13571) (Gwenn Le Bihan) - 89084d7 linter/custom-plugins: Enforce exact matching for disable directives (#13538) (Copilot) - 277c5e1 linter: Output `eslint-plugin-vue` for vue diagnostics (#13564) (Sysix) - 34d3cde rust: Fix clippy issues (#13540) (Boshen) - 5fccafc linter: `unicorn/prefer-array-flat-map` ignore `React.Children` (#13534) (Sysix) - 7e78e39 linter: Don't panic when parsing regex with multiple parentheses (#13524) (Sysix) - 0d867b1 linter: Skip running tsgolint when no files need type aware linting (#13502) (Copilot) - b677376 language_server: Include the diagnostic of the other linter (#13490) (Sysix) - e87d7bd linter: Parse regex inside `new RegExp()` with parentheses (#13448) (Sysix) - 5990f17 linter: Change `typescript/no-confusing-void-expression` to pedantic (#13473) (Boshen) ### 🚜 Refactor - 7775c21 linter/plugins: Remove `oxlint2` Cargo feature (#13648) (overlookmotel) - 8f37e88 linter: Update tsgolint payload (#13547) (camchenry) - 2d53203 linter/plugins: Move `tokio` usage from `oxc_linter` to `napi/oxlint2` (#13647) (overlookmotel) - 6cd6be2 linter: Add `--experimental-js-plugins` CLI arg (#13658) (overlookmotel) - 476729b linter: Simplify `RuleRunner` trait definition (#13637) (camchenry) - 2f02ac6 linter/plugins: Remove `disable_oxlint2` Cargo feature (#13626) (overlookmotel) - ff9e4fb linter/plugins: Use fixed-size allocators when `ExternalLinter` exists (#13623) (overlookmotel) - f9bff64 linter_codegen: Improve code style for collecting nodes (#13636) (camchenry) - babbaca all: Remove `pub` from modules with no exports (#13618) (overlookmotel) - 91759c6 linter/plugins: Only use `RawTransferFileSystem` if JS plugins registered (#13599) (overlookmotel) - 118020c linter/plugins: Discard `ExternalLinter` if no JS plugins registered (#13598) (overlookmotel) - 8d30bce linter/tsgolint: Report an error if the tsgolint exe could not be found (#13590) (camc314) - bccc276 eslint/for-direction: Clean up implementation and improve documentation (#13532) (Antoine Zanardi) - 1425da2 eslint/default-case-last: Simplify default case last check in switch statement (#13529) (Antoine Zanardi) - d245376 oxlint: Remove unused `runner` module (#13561) (camc314) - 53f2fc1 eslint/default-case: Simplify implementation and enhance readability (#13430) (Antoine Zanardi) - 6f15060 eslint/block-scoped-var: Clean up implementation and improve documentation (#13417) (Antoine Zanardi) - 671e0fd language_server: Only store one instance of a diagnostic (#13514) (Sysix) - 1b425d6 eslint/default-case-last: Simplify implementation and enhance readability (#13515) (Antoine Zanardi) - e4bbbce eslint/default-param-last: Simplify implementation and enhance readability (#13516) (Antoine Zanardi) - e0396fd linter: Remove `static` lifetime from disable directives function argument (#13492) (camc314) ### 📚 Documentation - eb1f167 linter: Note which rules require type info to run on rule page (#13675) (camc314) - e66f93b linter: Fix backtick formatting in no-return-wrap (#13633) (camc314) ### ⚡ Performance - e6a25e7 linter: Remove unnecessary `should_run` check (#13639) (camchenry) - f6a9687 linter: Store rules by AST type in a boxed array (#13578) (overlookmotel) - b81f081 linter: Reduce indirection (#13574) (overlookmotel) - a744aff linter: Skip rules that do not have any relevant node types (#13138) (camchenry) ### 🎨 Styling - e110476 linter: Reformat code (#13573) (overlookmotel) ### 🧪 Testing - 58e6c94 oxlint: Add test for ignorePatterns whitelist (#13372) (Sysix) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Sep 10, 2025

camchenry mentioned this pull request Sep 10, 2025

refactor(linter): simplify RuleRunner trait definition #13637

Merged

camchenry force-pushed the 09-09-refactor_linter_codegen_improve_code_style_for_collecting_nodes branch from 40c0d68 to cd42793 Compare September 10, 2025 03:42

camchenry force-pushed the 09-09-refactor_linter_codegen_improve_code_style_for_collecting_nodes branch from cd42793 to 16a2b49 Compare September 10, 2025 03:46

camchenry marked this pull request as ready for review September 10, 2025 03:52

Copilot AI review requested due to automatic review settings September 10, 2025 03:52

camchenry requested a review from camc314 as a code owner September 10, 2025 03:52

Copilot AI reviewed Sep 10, 2025

View reviewed changes

tasks/linter_codegen/src/main.rs Show resolved Hide resolved

tasks/linter_codegen/src/main.rs Outdated Show resolved Hide resolved

camc314 approved these changes Sep 10, 2025

View reviewed changes

camc314 added the 0-merge Merge with Graphite Merge Queue label Sep 10, 2025

graphite-app bot force-pushed the 09-09-refactor_linter_codegen_improve_code_style_for_collecting_nodes branch from 16a2b49 to 5718dfe Compare September 10, 2025 03:56

camc314 force-pushed the 09-09-refactor_linter_codegen_improve_code_style_for_collecting_nodes branch from 5718dfe to 54e4969 Compare September 10, 2025 03:56

camc314 force-pushed the 09-09-refactor_linter_codegen_improve_code_style_for_collecting_nodes branch from 54e4969 to f9bff64 Compare September 10, 2025 03:57

camchenry mentioned this pull request Sep 10, 2025

perf(linter): remove unnecessary should_run check #13639

Merged

graphite-app bot merged commit f9bff64 into main Sep 10, 2025
28 checks passed

graphite-app bot deleted the 09-09-refactor_linter_codegen_improve_code_style_for_collecting_nodes branch September 10, 2025 04:02

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 10, 2025

oxc-bot mentioned this pull request Sep 11, 2025

release(oxlint): v1.15.0 #13685

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

refactor(linter_codegen): improve code style for collecting nodes #13636

refactor(linter_codegen): improve code style for collecting nodes #13636

Uh oh!

camchenry commented Sep 10, 2025 •

edited

Loading

Uh oh!

camchenry commented Sep 10, 2025 •

edited

Loading

Uh oh!

socket-security bot commented Sep 10, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Sep 10, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

camc314 commented Sep 10, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

refactor(linter_codegen): improve code style for collecting nodes #13636

refactor(linter_codegen): improve code style for collecting nodes #13636

Uh oh!

Conversation

camchenry commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

camchenry commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

socket-security bot commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codspeed-hq bot commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Instrumentation Performance Report

Merging #13636 will not alter performance

Summary

Footnotes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

camc314 commented Sep 10, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

camchenry commented Sep 10, 2025 •

edited

Loading

camchenry commented Sep 10, 2025 •

edited

Loading

socket-security bot commented Sep 10, 2025 •

edited

Loading

codspeed-hq bot commented Sep 10, 2025 •

edited

Loading

camc314 commented Sep 10, 2025 •

edited by graphite-app bot

Loading