fix(semantic): dont parse @ as jsdoc tags inside quotes

[gwennlbh]

Fixes #13570

[graphite-app]

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

[gwennlbh]

just ready passes locally, except for

• sourcemap::stacktrace_is_correct, there's my local full path from the C: drive in the .new snapshot
• lint::test::ignore_patterns_with_symlink, false negative, says that "debugger is not allowed' when it should return no errors

I highly suspect that those two fail because of Windows shenanigans, here's a patch for the Justfile in case it's useful

Justfile

commit 05673760f9847ccae0375e4da4e26acd06d3fdd5
Author: Gwenn Le Bihan <gwenn.lebihan7@gmail.com>
Date:   Sun Sep 7 00:43:36 2025 +0200

    chore(just): disable windows-borked tests on windows

diff --git a/justfile b/justfile
index 5c6f00131..6f5a604e6 100755
--- a/justfile
+++ b/justfile
@@ -74,9 +74,14 @@ check:
   cargo ck
 
 # Run all the tests
+[unix]
 test:
   cargo test --all-features
 
+[windows]
+test:
+  cargo test --all-features -- --skip sourcemap::stacktrace_is_correct --skip lint::test::ignore_patterns_with_symlink
+
 # Lint the whole project
 lint:
   cargo lint -- --deny warnings

There's also a small failure while checking docs, because there's a URL without angle brackets in some doc-comment, again, another patch:

crates/oxc_diagnostics/src/service.rs

commit f18813815ec075b18e21f3a3c295b40684e6097a
Author: Gwenn Le Bihan <gwenn.lebihan7@gmail.com>
Date:   Sun Sep 7 00:58:15 2025 +0200

    chore(doc): fix missing <> around hyperlink

diff --git a/crates/oxc_diagnostics/src/service.rs b/crates/oxc_diagnostics/src/service.rs
index e2422de58..bf9fe0595 100644
--- a/crates/oxc_diagnostics/src/service.rs
+++ b/crates/oxc_diagnostics/src/service.rs
@@ -296,7 +296,7 @@ fn from_file_path<A: AsRef<Path>>(path: A) -> Option<String> {
 }
 
 /// On Windows, rewrites the wide path prefix `\\?\C:` to `C:`
-/// Source: https://stackoverflow.com/a/70970317
+/// Source: <https://stackoverflow.com/a/70970317>
 #[inline]
 #[cfg(windows)]
 fn strict_canonicalize<P: AsRef<Path>>(path: P) -> std::io::Result<PathBuf> {

I also smoketested my new test (it fails without my change to oxc_semantics)

[Copilot]

Pull Request Overview

This PR fixes an issue where the JSDoc parser incorrectly identified @ characters inside quoted strings as JSDoc tags. The fix ensures that @ characters within single or double quotes are ignored when parsing JSDoc comments.

• Adds quote tracking to the JSDoc parser to prevent parsing @ symbols inside quoted strings
• Updates the parsing condition to exclude quote contexts from tag detection
• Adds test coverage for the specific case of @import statements with quoted package names

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
crates/oxc_semantic/src/jsdoc/parser/parse.rs	Implements quote tracking logic to prevent @ parsing inside quoted strings
crates/oxc_linter/src/rules/jsdoc/check_tag_names.rs	Adds test case for @import with quoted package name to verify the fix

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[gwennlbh]

just in case, the three patches I commented are available on https://github.com/gwennlbh/oxc/tree/otherfixes

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #13571 will not alter performance

_{Comparing gwennlbh:main (17ac6c4) with main (5648b31)}

Summary

✅ 37 untouched benchmarks

[camc314]

https://github.com/microsoft/typescript-go/blob/1182233f6baba67c4e0421bbbbadd1c0045070ad/internal/parser/jsdoc.go#L445-L446

interestingly, TS has specific handling for each of the diff jsdoc attributes

[camc314]

thank you!