feat(linter): add `vue/no-multiple-slot-args` rule #13579

Sysix · 2025-09-07T11:52:18Z

https://eslint.vuejs.org/rules/no-multiple-slot-args.html

The original rule starts from a MemberExpression and checks later if the parent is a CallExpression.
This implementation checks for a CallExpression and tries to check MemberExpression.

All 22 tests are getting diagnosed, even the weird use case:

let children
children = this.$scopedSlots.foo
 if (children) children(...foo)

Sysix · 2025-09-07T11:52:38Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2025-09-07T11:58:44Z

CodSpeed Instrumentation Performance Report

Merging #13579 will not alter performance

_{Comparing 09-07-feat_linter_add_vue_no-multiple-slot-args_rule (b20b56d) with main (a718c23)¹}

Summary

✅ 37 untouched benchmarks

No successful run was found on main (b20b56d) during the generation of this report, so a718c23 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

Copilot

Pull Request Overview

This PR adds a new Vue.js linter rule vue/no-multiple-slot-args that disallows passing multiple arguments to scoped slots. The rule helps enforce Vue.js best practices by ensuring slot functions receive only a single argument, which improves API usability since users don't need to declare unused parameters in a fixed order.

Implements the vue/no-multiple-slot-args rule with comprehensive pattern matching for various slot invocation styles
Adds detection for both multiple arguments and spread arguments in slot function calls
Includes test coverage with 22 test cases covering different syntax patterns including optional chaining and variable assignments

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.

File	Description
crates/oxc_linter/src/rules/vue/no_multiple_slot_args.rs	Main implementation of the rule with comprehensive pattern matching logic
crates/oxc_linter/src/rules.rs	Registration of the new rule in the linter module system
crates/oxc_linter/src/snapshots/vue_no_multiple_slot_args.snap	Test snapshots showing expected diagnostic output for all test cases

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

crates/oxc_linter/src/rules/vue/no_multiple_slot_args.rs

camc314 · 2025-09-11T08:50:47Z

Merge activity

Sep 11, 8:50 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Sep 11, 8:50 AM UTC: camc314 added this pull request to the Graphite merge queue.
Sep 11, 8:58 AM UTC: Merged by the Graphite merge queue.

related #11440 https://eslint.vuejs.org/rules/no-multiple-slot-args.html The original rule starts from a `MemberExpression` and checks later if the parent is a `CallExpression`. This implementation checks for a `CallExpression` and tries to check `MemberExpression`. All 22 tests are getting diagnosed, even the weird use case: ``` let children children = this.$scopedSlots.foo if (children) children(...foo) ```

## [1.15.0] - 2025-09-11 ### 💥 BREAKING CHANGES - edc70ea allocator/pool: [**BREAKING**] Remove `disable_fixed_size` Cargo feature (#13625) (overlookmotel) ### 🚀 Features - b20b56d linter: Add `vue/no-multiple-slot-args` rule (#13579) (Sysix) - aafe08c linter: Add `vue/define-emits-declaration` rule (#13567) (Sysix) - 2ed5059 linter: Add `vue/define-props-declaration` rule (#13566) (Sysix) - a718c23 linter: Add `vue/valid-define-props` rule (#13565) (Sysix) - 75a673e editor: Support relative path for `oxc.path.server` (#13542) (Sysix) - 4af886b linter: Add `unicorn/no-array-reverse` rule (#13530) (yefan) - 2db32eb data_structures: Add `boxed_slice!` and `boxed_array!` macros (#13596) (overlookmotel) ### 🐛 Bug Fixes - fb9d0f4 language_server: Don't resend diagnostic on save, when `typeAware` is disabled and run is onType (#13604) (YongSeok Jang (장용석)) - 2f36350 editor: Add notice for a possible restart when fixing `filename-case` (#13557) (Sysix) - e17fccc linter: Update `RuleRunner` impl after merge (#13642) (camc314) - 3d27c5b linter/no-unused-private-class-members: False positive with spread expr (#13634) (yefan) - 8314ed5 linter/tsgolint: Correct comment (#13589) (camc314) - 198243b semantic: Dont parse `@` as jsdoc tags inside quotes (#13571) (Gwenn Le Bihan) - 89084d7 linter/custom-plugins: Enforce exact matching for disable directives (#13538) (Copilot) - 277c5e1 linter: Output `eslint-plugin-vue` for vue diagnostics (#13564) (Sysix) - 34d3cde rust: Fix clippy issues (#13540) (Boshen) - 5fccafc linter: `unicorn/prefer-array-flat-map` ignore `React.Children` (#13534) (Sysix) - 7e78e39 linter: Don't panic when parsing regex with multiple parentheses (#13524) (Sysix) - 0d867b1 linter: Skip running tsgolint when no files need type aware linting (#13502) (Copilot) - b677376 language_server: Include the diagnostic of the other linter (#13490) (Sysix) - e87d7bd linter: Parse regex inside `new RegExp()` with parentheses (#13448) (Sysix) - 5990f17 linter: Change `typescript/no-confusing-void-expression` to pedantic (#13473) (Boshen) ### 🚜 Refactor - 7775c21 linter/plugins: Remove `oxlint2` Cargo feature (#13648) (overlookmotel) - 8f37e88 linter: Update tsgolint payload (#13547) (camchenry) - 2d53203 linter/plugins: Move `tokio` usage from `oxc_linter` to `napi/oxlint2` (#13647) (overlookmotel) - 6cd6be2 linter: Add `--experimental-js-plugins` CLI arg (#13658) (overlookmotel) - 476729b linter: Simplify `RuleRunner` trait definition (#13637) (camchenry) - 2f02ac6 linter/plugins: Remove `disable_oxlint2` Cargo feature (#13626) (overlookmotel) - ff9e4fb linter/plugins: Use fixed-size allocators when `ExternalLinter` exists (#13623) (overlookmotel) - f9bff64 linter_codegen: Improve code style for collecting nodes (#13636) (camchenry) - babbaca all: Remove `pub` from modules with no exports (#13618) (overlookmotel) - 91759c6 linter/plugins: Only use `RawTransferFileSystem` if JS plugins registered (#13599) (overlookmotel) - 118020c linter/plugins: Discard `ExternalLinter` if no JS plugins registered (#13598) (overlookmotel) - 8d30bce linter/tsgolint: Report an error if the tsgolint exe could not be found (#13590) (camc314) - bccc276 eslint/for-direction: Clean up implementation and improve documentation (#13532) (Antoine Zanardi) - 1425da2 eslint/default-case-last: Simplify default case last check in switch statement (#13529) (Antoine Zanardi) - d245376 oxlint: Remove unused `runner` module (#13561) (camc314) - 53f2fc1 eslint/default-case: Simplify implementation and enhance readability (#13430) (Antoine Zanardi) - 6f15060 eslint/block-scoped-var: Clean up implementation and improve documentation (#13417) (Antoine Zanardi) - 671e0fd language_server: Only store one instance of a diagnostic (#13514) (Sysix) - 1b425d6 eslint/default-case-last: Simplify implementation and enhance readability (#13515) (Antoine Zanardi) - e4bbbce eslint/default-param-last: Simplify implementation and enhance readability (#13516) (Antoine Zanardi) - e0396fd linter: Remove `static` lifetime from disable directives function argument (#13492) (camc314) ### 📚 Documentation - eb1f167 linter: Note which rules require type info to run on rule page (#13675) (camc314) - e66f93b linter: Fix backtick formatting in no-return-wrap (#13633) (camc314) ### ⚡ Performance - e6a25e7 linter: Remove unnecessary `should_run` check (#13639) (camchenry) - f6a9687 linter: Store rules by AST type in a boxed array (#13578) (overlookmotel) - b81f081 linter: Reduce indirection (#13574) (overlookmotel) - a744aff linter: Skip rules that do not have any relevant node types (#13138) (camchenry) ### 🎨 Styling - e110476 linter: Reformat code (#13573) (overlookmotel) ### 🧪 Testing - 58e6c94 oxlint: Add test for ignorePatterns whitelist (#13372) (Sysix) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Sep 7, 2025

Sysix force-pushed the 09-07-feat_linter_add_vue_no-multiple-slot-args_rule branch 2 times, most recently from 74aa2c4 to 671f42c Compare September 8, 2025 11:17

Sysix force-pushed the 09-06-feat_linter_add_vue_define-emits-declaration_rule branch 2 times, most recently from 03991dc to 202961a Compare September 8, 2025 11:32

Sysix force-pushed the 09-07-feat_linter_add_vue_no-multiple-slot-args_rule branch 2 times, most recently from 5bfdff1 to 86bbc74 Compare September 8, 2025 14:51

Sysix marked this pull request as ready for review September 8, 2025 14:55

Sysix requested a review from camc314 as a code owner September 8, 2025 14:55

Sysix requested a review from Copilot September 8, 2025 14:56

Copilot AI reviewed Sep 8, 2025

View reviewed changes

crates/oxc_linter/src/rules/vue/no_multiple_slot_args.rs Show resolved Hide resolved

crates/oxc_linter/src/rules/vue/no_multiple_slot_args.rs Outdated Show resolved Hide resolved

crates/oxc_linter/src/rules/vue/no_multiple_slot_args.rs Outdated Show resolved Hide resolved

Sysix force-pushed the 09-07-feat_linter_add_vue_no-multiple-slot-args_rule branch from 86bbc74 to 0e08855 Compare September 8, 2025 15:34

Sysix force-pushed the 09-06-feat_linter_add_vue_define-emits-declaration_rule branch from 202961a to c7abea9 Compare September 10, 2025 17:41

Sysix force-pushed the 09-07-feat_linter_add_vue_no-multiple-slot-args_rule branch from 0e08855 to 7d513ea Compare September 10, 2025 17:41

graphite-app bot reviewed Sep 10, 2025

View reviewed changes

crates/oxc_linter/src/rules/vue/no_multiple_slot_args.rs Outdated Show resolved Hide resolved

Sysix force-pushed the 09-07-feat_linter_add_vue_no-multiple-slot-args_rule branch 2 times, most recently from 5703bcb to b40d3af Compare September 10, 2025 18:26

camc314 approved these changes Sep 11, 2025

View reviewed changes

camc314 added the 0-merge Merge with Graphite Merge Queue label Sep 11, 2025

graphite-app bot force-pushed the 09-06-feat_linter_add_vue_define-emits-declaration_rule branch from c7abea9 to aafe08c Compare September 11, 2025 08:53

graphite-app bot force-pushed the 09-07-feat_linter_add_vue_no-multiple-slot-args_rule branch from b40d3af to b20b56d Compare September 11, 2025 08:53

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 11, 2025

Base automatically changed from 09-06-feat_linter_add_vue_define-emits-declaration_rule to main September 11, 2025 08:57

graphite-app bot merged commit b20b56d into main Sep 11, 2025
26 checks passed

graphite-app bot deleted the 09-07-feat_linter_add_vue_no-multiple-slot-args_rule branch September 11, 2025 08:58

oxc-bot mentioned this pull request Sep 11, 2025

release(oxlint): v1.15.0 #13685

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(linter): add `vue/no-multiple-slot-args` rule #13579

feat(linter): add `vue/no-multiple-slot-args` rule #13579

Uh oh!

Sysix commented Sep 7, 2025 •

edited

Loading

Uh oh!

Sysix commented Sep 7, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Sep 7, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

camc314 commented Sep 11, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

feat(linter): add vue/no-multiple-slot-args rule #13579

feat(linter): add vue/no-multiple-slot-args rule #13579

Uh oh!

Conversation

Sysix commented Sep 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sysix commented Sep 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Sep 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Instrumentation Performance Report

Merging #13579 will not alter performance

Summary

Footnotes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

camc314 commented Sep 11, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat(linter): add `vue/no-multiple-slot-args` rule #13579

feat(linter): add `vue/no-multiple-slot-args` rule #13579

Sysix commented Sep 7, 2025 •

edited

Loading

Sysix commented Sep 7, 2025 •

edited

Loading

codspeed-hq bot commented Sep 7, 2025 •

edited

Loading

camc314 commented Sep 11, 2025 •

edited by graphite-app bot

Loading