Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Oct 3, 2025

Pure refactor. Follow-on after #14312.

Simplify the raw transfer codegen. This change does not alter content of the generated functions, only the order in which they're output in generated code.

@github-actions github-actions bot added A-parser Area - Parser A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Oct 3, 2025
Copy link
Member Author

overlookmotel commented Oct 3, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review October 3, 2025 12:55
@overlookmotel overlookmotel self-assigned this Oct 3, 2025
@overlookmotel overlookmotel force-pushed the 10-03-refactor_napi_parser_simplify_raw_transfer_deserializer_codegen branch from 4beca41 to 8683735 Compare October 3, 2025 13:31
@overlookmotel overlookmotel force-pushed the 10-03-refactor_napi_parser_use_minifier_to_generate_js_ts_raw_transfer_deserializers_from_single_source branch from 0b616e8 to 1fbda58 Compare October 3, 2025 13:31
@overlookmotel overlookmotel force-pushed the 10-03-refactor_napi_parser_simplify_raw_transfer_deserializer_codegen branch from 8683735 to 9856923 Compare October 4, 2025 12:36
@overlookmotel overlookmotel force-pushed the 10-03-refactor_napi_parser_use_minifier_to_generate_js_ts_raw_transfer_deserializers_from_single_source branch from 1fbda58 to 77bc09c Compare October 4, 2025 12:36
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Oct 4, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 4, 2025

Merge activity

@graphite-app graphite-app bot changed the base branch from 10-03-refactor_napi_parser_use_minifier_to_generate_js_ts_raw_transfer_deserializers_from_single_source to graphite-base/14313 October 4, 2025 14:12
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 4, 2025
@graphite-app graphite-app bot changed the base branch from graphite-base/14313 to main October 4, 2025 14:17
@github-actions github-actions bot added the A-ast Area - AST label Oct 4, 2025
@overlookmotel overlookmotel force-pushed the 10-03-refactor_napi_parser_simplify_raw_transfer_deserializer_codegen branch from 9856923 to 7bbe4a5 Compare October 4, 2025 15:42
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Oct 4, 2025
…4313)

Pure refactor. Follow-on after #14312.

Simplify the raw transfer codegen. This change does not alter content of the generated functions, only the order in which they're output in generated code.
@graphite-app graphite-app bot force-pushed the 10-03-refactor_napi_parser_simplify_raw_transfer_deserializer_codegen branch from 7bbe4a5 to 073167a Compare October 4, 2025 15:47
@graphite-app graphite-app bot merged commit 073167a into main Oct 4, 2025
17 checks passed
@graphite-app graphite-app bot deleted the 10-03-refactor_napi_parser_simplify_raw_transfer_deserializer_codegen branch October 4, 2025 15:52
@Boshen Boshen mentioned this pull request Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast Area - AST A-ast-tools Area - AST tools A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants