refactor(napi/parser): use minifier to generate JS/TS raw transfer deserializers from single source

[overlookmotel]

Pure refactor. Makes only minor cosmetic changes to the generated raw transfer deserializer code, mainly just alters how that code is generated.

Previously we generated the source for the 2 different deserializers (JS and TS) separately, with the JS deserializer leaving out some fields e.g. typeAnnotation.

Instead, generate only 1 base implementation, with TS-only fields gated by IS_TS. IS_TS is defined as a const at top of the file.

const IS_TS = true;

function deserializeFunction(pos) {
  const params = deserializeBoxFormalParameters(pos + 56);
  if (IS_TS) {
    const thisParam = deserializeOptionBoxTSThisParameter(pos + 48);
    if (thisParam !== null) params.unshift(thisParam);
  }

  return {
    type: deserializeFunctionType(pos + 84),
    params,
    ...(IS_TS && {
      declare: deserializeBool(pos + 87),
      typeParameters: deserializeOptionBoxTSTypeParameterDeclaration(pos + 40),
    }),
    // ... etc ...
  };
}

Then we generate both the JS and TS deserializers from this same file, by setting the IS_TS const to true or false, and using minifier to shake out the dead code.

This:

1. Simplifies custom deserializers.
2. Opens the door to add more const flags, e.g. RANGES to switch on/off including range field in AST nodes.

[overlookmotel]

• feat(linter/plugins): include range field in AST #14321
• feat(napi/parser): raw transfer support range field #14319
• fix(napi/parser): fix JSDoc comments #14318
• refactor(napi/parser): simplify raw transfer deserializer codegen #14313
• refactor(napi/parser): use minifier to generate JS/TS raw transfer deserializers from single source #14312 👈 (View in Graphite)
• refactor(napi/parser): minify syntax in raw transfer deserializers #14308
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #14312 will not alter performance

_{Comparing 10-03-refactor_napi_parser_use_minifier_to_generate_js_ts_raw_transfer_deserializers_from_single_source (34e1c0b) with main (f37b211)¹}

Summary

✅ 37 untouched

Footnotes

1. No successful run was found on main (34e1c0b) during the generation of this report, so f37b211 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[overlookmotel]

Merge activity

• Oct 4, 2:11 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Oct 4, 2:11 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
• Oct 4, 2:17 PM UTC: Merged by the Graphite merge queue.