Skip to content

Conversation

@leaysgur
Copy link
Member

@leaysgur leaysgur commented Oct 7, 2025

It's the same approach as oxlint.

It uses the schemars::JsonSchema, generating a snapshot and configuration_schema.json.

@leaysgur leaysgur requested a review from Dunqing as a code owner October 7, 2025 06:21
@github-actions github-actions bot added A-formatter Area - Formatter C-enhancement Category - New feature or request labels Oct 7, 2025
Copy link
Member Author

leaysgur commented Oct 7, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@leaysgur leaysgur force-pushed the 10-07-feat_oxfmt_provide_json_schema_for_.oxfmtrc.json branch from 8291aaf to 03bdd33 Compare October 7, 2025 06:24
@leaysgur leaysgur changed the title feat(oxfmt): Provide JSON schema for .oxfmtrc.json feat(oxfmt): Provide JSON schema for .oxfmtrc.json Oct 7, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 7, 2025

CodSpeed Performance Report

Merging #14399 will not alter performance

Comparing 10-07-feat_oxfmt_provide_json_schema_for_.oxfmtrc.json (8077f9b) with 10-07-feat_oxfmt_support_oxfmt.json (51ddfa8)

Summary

✅ 37 untouched

@leaysgur leaysgur force-pushed the 10-07-feat_oxfmt_provide_json_schema_for_.oxfmtrc.json branch from 03bdd33 to 31817e8 Compare October 8, 2025 01:12
@leaysgur leaysgur force-pushed the 10-07-feat_oxfmt_support_oxfmt.json branch from 2c70171 to d7b2775 Compare October 8, 2025 01:12
@leaysgur leaysgur changed the base branch from 10-07-feat_oxfmt_support_oxfmt.json to graphite-base/14399 October 8, 2025 01:15
@leaysgur leaysgur force-pushed the 10-07-feat_oxfmt_provide_json_schema_for_.oxfmtrc.json branch from 31817e8 to 5b970e5 Compare October 8, 2025 01:15
@leaysgur leaysgur force-pushed the graphite-base/14399 branch from d7b2775 to 86c4e1d Compare October 8, 2025 01:15
@leaysgur leaysgur changed the base branch from graphite-base/14399 to 10-07-feat_oxfmt_support_oxfmt.json October 8, 2025 01:15
@leaysgur leaysgur force-pushed the 10-07-feat_oxfmt_provide_json_schema_for_.oxfmtrc.json branch from 5b970e5 to 5ee24d5 Compare October 9, 2025 05:01
@leaysgur leaysgur force-pushed the 10-07-feat_oxfmt_support_oxfmt.json branch from 86c4e1d to f0c19eb Compare October 9, 2025 05:01
@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Oct 9, 2025
Copy link
Member

Dunqing commented Oct 9, 2025

Merge activity

It's the same approach as `oxlint`.

It uses the `schemars::JsonSchema`, generating a snapshot and `configuration_schema.json`.
@graphite-app graphite-app bot force-pushed the 10-07-feat_oxfmt_support_oxfmt.json branch from f0c19eb to 51ddfa8 Compare October 9, 2025 06:22
@graphite-app graphite-app bot force-pushed the 10-07-feat_oxfmt_provide_json_schema_for_.oxfmtrc.json branch from 5ee24d5 to 8077f9b Compare October 9, 2025 06:23
Base automatically changed from 10-07-feat_oxfmt_support_oxfmt.json to main October 9, 2025 06:28
@graphite-app graphite-app bot merged commit 8077f9b into main Oct 9, 2025
30 checks passed
@graphite-app graphite-app bot deleted the 10-07-feat_oxfmt_provide_json_schema_for_.oxfmtrc.json branch October 9, 2025 06:29
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 9, 2025
@Boshen Boshen mentioned this pull request Oct 14, 2025
leaysgur added a commit that referenced this pull request Oct 14, 2025
## [0.5.0] - 2025-10-14

### 🚀 Features

- 8077f9b oxfmt: Provide JSON schema for `.oxfmtrc.json` (#14399)
(leaysgur)
- 51ddfa8 oxfmt: Support `.oxfmtrc.json(c)` config file (#14398)
(leaysgur)

### 🐛 Bug Fixes

- c4e12df formatter: Correct checking comments around the return
argument (#14585) (Dunqing)
- 454303b formatter: Check empty lines between arguments incorrectly
(#14584) (Dunqing)
- a5554a8 formatter: Print a line break incorrectly for directives
(#14577) (Dunqing)
- 5db9774 formatter: Correct printing comments that are around the
`StaticMemberExpression` (#14543) (Dunqing)
- 620dbac formatter: No need to wrap a parenthesis for
`TSConditionalType` and `TSFunctionType` when its parent is
`TSUnionType` and it only has one element (#14540) (Dunqing)
- 1aec74f formatter: Missing parenthesis for `ComputedMemberExpression`
when its parent is an `NewExpression` (#14530) (Dunqing)
- 59f1d8f formatter: Missing parenthesis for `PrivateInExpression` when
its parent is an `UnaryExpression` (#14529) (Dunqing)
- b06059e formatter: Correct printing comments for logical expression
(#14500) (Dunqing)
- be38095 formatter: Should break even if the right side of the
assignment is a require when it has a leading own line comment (#14499)
(Dunqing)
- 4d55654 formatter: Correct printing comments for the end of union type
(#14498) (Dunqing)
- 4994872 formatter: Correct printing comments for `try` statement
(#14497) (Dunqing)
- 9a4da3d formatter: Should expand the parent if the member chain will
break (#14487) (Dunqing)
- bba9689 formatter: Correct printing comments around the expression of
`ComputedMemberExpression` (#14486) (Dunqing)
- dc5e08a formatter: Correct printing yield argument (#14485) (Dunqing)
- b8a0905 formatter: No need to wrap with parentheses for a type cast
node (#14484) (Dunqing)
- b159215 formatter: Ignore the leading line break for the first
argument of the call expression (#14483) (Dunqing)
- ea8f9ed formatter: Correct checking comments between the operator and
the right side for assignment like nodes (#14482) (Dunqing)
- 4f19504 formatter: Block comments without a leading linebreak that are
around the operator of the conditional expression should be printed
as-is (#14474) (Dunqing)
- ef77997 formatter: Correct printing comments for `for` statements
(#14473) (Dunqing)
- 31595c3 formatter: Correct printing comments for assignment pattern
(#14469) (Dunqing)
- 0f19be0 oxfmt: Normalize path delimiter on Windows (#14463) (leaysgur)
- 5856bc9 oxc_formatter: Fix arrow_parentheses: 'avoid' > 'as-needed'
(#14462) (leaysgur)

### 🚜 Refactor

- 7bc86f4 formatter: Simplify foramtting import and export (#14576)
(Dunqing)
- 29c3cf2 formatter: Remove `SiblingNode` (#14551) (Dunqing)
- 893bdac formatter: Improve printing comments for special nodes
(#14544) (Dunqing)
- 97bb964 formatter: Improve line break detaching logic in SourceText
(#14539) (Dunqing)

### 🧪 Testing

- bb43dc5 formatter: Add snapshot-based test infrastructure (#14400)
(Dunqing)

Co-authored-by: leaysgur <6259812+leaysgur@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-formatter Area - Formatter C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants