fix(formatter): missing parenthesis for `ComputedMemberExpression` when its parent is an `NewExpression` #14530

Dunqing · 2025-10-12T12:39:42Z

close formatter: Missing parens for ComputedMemberExpression #14453

Dunqing · 2025-10-12T12:40:18Z

fix(formatter): print a line break incorrectly for directives #14577
refactor(formatter): simplify foramtting import and export #14576
refactor(formatter): remove SiblingNode #14551
refactor(formatter): improve printing comments for special nodes #14544
fix(formatter): correct printing comments that are around the StaticMemberExpression #14543
fix(formatter): no need to wrap a parenthesis for TSConditionalType and TSFunctionType when its parent is TSUnionType and it only has one element #14540
refactor(formatter): improve line break detaching logic in SourceText #14539
fix(formatter): missing parenthesis for ComputedMemberExpression when its parent is an NewExpression #14530 👈 (View in Graphite)
fix(formatter): missing parenthesis for PrivateInExpression when its parent is an UnaryExpression #14529
fix(formatter): correct printing comments for logical expression #14500
fix(formatter): should break even if the right side of the assignment is a require when it has a leading own line comment #14499
fix(formatter): correct printing comments for the end of union type #14498
fix(formatter): correct printing comments for try statement #14497
fix(formatter): should expand the parent if the member chain will break #14487
fix(formatter): correct printing comments around the expression of ComputedMemberExpression #14486
fix(formatter): correct printing yield argument #14485
fix(formatter): no need to wrap with parentheses for a type cast node #14484
fix(formatter): ignore the leading line break for the first argument of the call expression #14483
fix(formatter): correct checking comments between the operator and the right side for assignment like nodes #14482
fix(formatter): block comments without a leading linebreak that are around the operator of the conditional expression should be printed as-is #14474
fix(formatter): correct printing comments for for statements #14473
fix(formatter): correct printing comments for assignment pattern #14469
test(formatter): add snapshot-based test infrastructure #14400
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2025-10-12T12:44:23Z

CodSpeed Performance Report

Merging #14530 will not alter performance

_{Comparing 10-12-fix_formatter_missing_parenthesis_for_computedmemberexpression_when_its_parent_is_an_newexpression (1aec74f) with main (59f1d8f)¹}

Summary

✅ 33 untouched
⏩ 4 skipped²

No successful run was found on main (59f1d8f) during the generation of this report, so 59f1d8f was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Dunqing · 2025-10-12T12:46:12Z

All of the issues that the PRs fix in this stack are found in monitor-oxc, and I added a related minimal test case. Now I am going to merge this stack because it has become larger. Feel free to review later or send a PR to improve it directly. @leaysgur cc

Dunqing · 2025-10-12T12:47:07Z

Merge activity

Oct 12, 12:47 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Oct 12, 4:12 PM UTC: Dunqing added this pull request to the Graphite merge queue.
Oct 12, 4:40 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #14498.
Oct 12, 4:40 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #14498.
Oct 13, 6:31 AM UTC: Dunqing added this pull request to the Graphite merge queue.
Oct 13, 6:38 AM UTC: Merged by the Graphite merge queue.

…en its parent is an `NewExpression` (#14530) * close #14453

## [0.5.0] - 2025-10-14 ### 🚀 Features - 8077f9b oxfmt: Provide JSON schema for `.oxfmtrc.json` (#14399) (leaysgur) - 51ddfa8 oxfmt: Support `.oxfmtrc.json(c)` config file (#14398) (leaysgur) ### 🐛 Bug Fixes - c4e12df formatter: Correct checking comments around the return argument (#14585) (Dunqing) - 454303b formatter: Check empty lines between arguments incorrectly (#14584) (Dunqing) - a5554a8 formatter: Print a line break incorrectly for directives (#14577) (Dunqing) - 5db9774 formatter: Correct printing comments that are around the `StaticMemberExpression` (#14543) (Dunqing) - 620dbac formatter: No need to wrap a parenthesis for `TSConditionalType` and `TSFunctionType` when its parent is `TSUnionType` and it only has one element (#14540) (Dunqing) - 1aec74f formatter: Missing parenthesis for `ComputedMemberExpression` when its parent is an `NewExpression` (#14530) (Dunqing) - 59f1d8f formatter: Missing parenthesis for `PrivateInExpression` when its parent is an `UnaryExpression` (#14529) (Dunqing) - b06059e formatter: Correct printing comments for logical expression (#14500) (Dunqing) - be38095 formatter: Should break even if the right side of the assignment is a require when it has a leading own line comment (#14499) (Dunqing) - 4d55654 formatter: Correct printing comments for the end of union type (#14498) (Dunqing) - 4994872 formatter: Correct printing comments for `try` statement (#14497) (Dunqing) - 9a4da3d formatter: Should expand the parent if the member chain will break (#14487) (Dunqing) - bba9689 formatter: Correct printing comments around the expression of `ComputedMemberExpression` (#14486) (Dunqing) - dc5e08a formatter: Correct printing yield argument (#14485) (Dunqing) - b8a0905 formatter: No need to wrap with parentheses for a type cast node (#14484) (Dunqing) - b159215 formatter: Ignore the leading line break for the first argument of the call expression (#14483) (Dunqing) - ea8f9ed formatter: Correct checking comments between the operator and the right side for assignment like nodes (#14482) (Dunqing) - 4f19504 formatter: Block comments without a leading linebreak that are around the operator of the conditional expression should be printed as-is (#14474) (Dunqing) - ef77997 formatter: Correct printing comments for `for` statements (#14473) (Dunqing) - 31595c3 formatter: Correct printing comments for assignment pattern (#14469) (Dunqing) - 0f19be0 oxfmt: Normalize path delimiter on Windows (#14463) (leaysgur) - 5856bc9 oxc_formatter: Fix arrow_parentheses: 'avoid' > 'as-needed' (#14462) (leaysgur) ### 🚜 Refactor - 7bc86f4 formatter: Simplify foramtting import and export (#14576) (Dunqing) - 29c3cf2 formatter: Remove `SiblingNode` (#14551) (Dunqing) - 893bdac formatter: Improve printing comments for special nodes (#14544) (Dunqing) - 97bb964 formatter: Improve line break detaching logic in SourceText (#14539) (Dunqing) ### 🧪 Testing - bb43dc5 formatter: Add snapshot-based test infrastructure (#14400) (Dunqing) Co-authored-by: leaysgur <6259812+leaysgur@users.noreply.github.com>

github-actions bot added A-formatter Area - Formatter C-bug Category - Bug labels Oct 12, 2025

Dunqing mentioned this pull request Oct 12, 2025

fix(formatter): missing parenthesis for PrivateInExpression when its parent is an UnaryExpression #14529

Merged

Dunqing marked this pull request as ready for review October 12, 2025 12:40

Dunqing assigned leaysgur Oct 12, 2025

Dunqing requested a review from leaysgur October 12, 2025 12:46

Dunqing added the 0-merge Merge with Graphite Merge Queue label Oct 12, 2025

graphite-app bot force-pushed the 10-12-fix_formatter_missing_parenthesis_for_privateinexpression_when_its_parent_is_an_unaryexpression branch from 4a5ad45 to af13bff Compare October 12, 2025 16:20

graphite-app bot requested a review from overlookmotel as a code owner October 12, 2025 16:20

graphite-app bot pushed a commit that referenced this pull request Oct 12, 2025

fix(formatter): missing parenthesis for ComputedMemberExpression wh…

21b5f37

…en its parent is an `NewExpression` (#14530) * close #14453

graphite-app bot force-pushed the 10-12-fix_formatter_missing_parenthesis_for_computedmemberexpression_when_its_parent_is_an_newexpression branch from 6bc2b0a to 21b5f37 Compare October 12, 2025 16:21

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 12, 2025

Dunqing added a commit that referenced this pull request Oct 13, 2025

fix(formatter): missing parenthesis for ComputedMemberExpression wh…

0c8e93c

…en its parent is an `NewExpression` (#14530) * close #14453

Dunqing force-pushed the 10-12-fix_formatter_missing_parenthesis_for_computedmemberexpression_when_its_parent_is_an_newexpression branch from 21b5f37 to 0c8e93c Compare October 13, 2025 02:13

Dunqing force-pushed the 10-12-fix_formatter_missing_parenthesis_for_privateinexpression_when_its_parent_is_an_unaryexpression branch from af13bff to d6c7af7 Compare October 13, 2025 02:13

graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Oct 13, 2025

Dunqing mentioned this pull request Oct 13, 2025

refactor(formatter): improve printing comments for special nodes #14544

Merged

graphite-app bot force-pushed the 10-12-fix_formatter_missing_parenthesis_for_privateinexpression_when_its_parent_is_an_unaryexpression branch 2 times, most recently from fb774b6 to 59f1d8f Compare October 13, 2025 06:24

Base automatically changed from 10-12-fix_formatter_missing_parenthesis_for_privateinexpression_when_its_parent_is_an_unaryexpression to main October 13, 2025 06:32

fix(formatter): missing parenthesis for ComputedMemberExpression wh…

1aec74f

…en its parent is an `NewExpression` (#14530) * close #14453

graphite-app bot force-pushed the 10-12-fix_formatter_missing_parenthesis_for_computedmemberexpression_when_its_parent_is_an_newexpression branch from 0c8e93c to 1aec74f Compare October 13, 2025 06:32

graphite-app bot merged commit 1aec74f into main Oct 13, 2025
27 checks passed

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 13, 2025

graphite-app bot deleted the 10-12-fix_formatter_missing_parenthesis_for_computedmemberexpression_when_its_parent_is_an_newexpression branch October 13, 2025 06:38

Dunqing mentioned this pull request Oct 13, 2025

refactor(formatter): remove SiblingNode #14551

Merged

leaysgur mentioned this pull request Oct 14, 2025

formatter: Missing parens for ComputedMemberExpression #14453

Closed

This was referenced Oct 14, 2025

refactor(formatter): simplify foramtting import and export #14576

Merged

fix(formatter): print a line break incorrectly for directives #14577

Merged

Boshen mentioned this pull request Oct 14, 2025

release(oxfmt): v0.5.0 #14586

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(formatter): missing parenthesis for `ComputedMemberExpression` when its parent is an `NewExpression` #14530

fix(formatter): missing parenthesis for `ComputedMemberExpression` when its parent is an `NewExpression` #14530

Dunqing commented Oct 12, 2025 •

edited

Loading

Uh oh!

Dunqing commented Oct 12, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Oct 12, 2025 •

edited

Loading

Uh oh!

Dunqing commented Oct 12, 2025

Uh oh!

Dunqing commented Oct 12, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

fix(formatter): missing parenthesis for ComputedMemberExpression when its parent is an NewExpression #14530

fix(formatter): missing parenthesis for ComputedMemberExpression when its parent is an NewExpression #14530

Conversation

Dunqing commented Oct 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Dunqing commented Oct 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Oct 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #14530 will not alter performance

Summary

Footnotes

Uh oh!

Dunqing commented Oct 12, 2025

Uh oh!

Dunqing commented Oct 12, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix(formatter): missing parenthesis for `ComputedMemberExpression` when its parent is an `NewExpression` #14530

fix(formatter): missing parenthesis for `ComputedMemberExpression` when its parent is an `NewExpression` #14530

Dunqing commented Oct 12, 2025 •

edited

Loading

Dunqing commented Oct 12, 2025 •

edited

Loading

codspeed-hq bot commented Oct 12, 2025 •

edited

Loading

Dunqing commented Oct 12, 2025 •

edited by graphite-app bot

Loading