fix(oxfmt): Normalize path delimiter on Windows #14463

leaysgur · 2025-10-09T09:54:45Z

Fixes CI fails on main branch. 🙇🏻

leaysgur · 2025-10-09T09:55:04Z

fix(oxfmt): Normalize path delimiter on Windows #14463 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull Request Overview

This PR fixes path delimiter normalization issues on Windows in the oxfmt tool by ensuring all backslashes are converted to forward slashes before path processing, and enables Windows testing in CI for all branches.

Adds path normalization to convert backslashes to forward slashes in test output
Enables Windows CI testing for all branches instead of just main

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
apps/oxfmt/tests/tester.rs	Adds path delimiter normalization before existing path processing
.github/workflows/ci.yml	Enables Windows testing for all branches by commenting out branch restriction

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

apps/oxfmt/tests/tester.rs

codspeed-hq · 2025-10-09T10:11:57Z

CodSpeed Performance Report

Merging #14463 will not alter performance

_{Comparing 10-09-fix_oxfmt_normalize_path_delimiter_on_windows (0f19be0) with main (368829b)}

Summary

✅ 33 untouched
⏩ 4 skipped¹

4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

leaysgur · 2025-10-09T10:32:10Z

Merge activity

Oct 9, 10:32 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Oct 9, 10:36 AM UTC: leaysgur added this pull request to the Graphite merge queue.
Oct 9, 10:42 AM UTC: Merged by the Graphite merge queue.

Fixes CI fails on `main` branch. 🙇🏻

## [0.5.0] - 2025-10-14 ### 🚀 Features - 8077f9b oxfmt: Provide JSON schema for `.oxfmtrc.json` (#14399) (leaysgur) - 51ddfa8 oxfmt: Support `.oxfmtrc.json(c)` config file (#14398) (leaysgur) ### 🐛 Bug Fixes - c4e12df formatter: Correct checking comments around the return argument (#14585) (Dunqing) - 454303b formatter: Check empty lines between arguments incorrectly (#14584) (Dunqing) - a5554a8 formatter: Print a line break incorrectly for directives (#14577) (Dunqing) - 5db9774 formatter: Correct printing comments that are around the `StaticMemberExpression` (#14543) (Dunqing) - 620dbac formatter: No need to wrap a parenthesis for `TSConditionalType` and `TSFunctionType` when its parent is `TSUnionType` and it only has one element (#14540) (Dunqing) - 1aec74f formatter: Missing parenthesis for `ComputedMemberExpression` when its parent is an `NewExpression` (#14530) (Dunqing) - 59f1d8f formatter: Missing parenthesis for `PrivateInExpression` when its parent is an `UnaryExpression` (#14529) (Dunqing) - b06059e formatter: Correct printing comments for logical expression (#14500) (Dunqing) - be38095 formatter: Should break even if the right side of the assignment is a require when it has a leading own line comment (#14499) (Dunqing) - 4d55654 formatter: Correct printing comments for the end of union type (#14498) (Dunqing) - 4994872 formatter: Correct printing comments for `try` statement (#14497) (Dunqing) - 9a4da3d formatter: Should expand the parent if the member chain will break (#14487) (Dunqing) - bba9689 formatter: Correct printing comments around the expression of `ComputedMemberExpression` (#14486) (Dunqing) - dc5e08a formatter: Correct printing yield argument (#14485) (Dunqing) - b8a0905 formatter: No need to wrap with parentheses for a type cast node (#14484) (Dunqing) - b159215 formatter: Ignore the leading line break for the first argument of the call expression (#14483) (Dunqing) - ea8f9ed formatter: Correct checking comments between the operator and the right side for assignment like nodes (#14482) (Dunqing) - 4f19504 formatter: Block comments without a leading linebreak that are around the operator of the conditional expression should be printed as-is (#14474) (Dunqing) - ef77997 formatter: Correct printing comments for `for` statements (#14473) (Dunqing) - 31595c3 formatter: Correct printing comments for assignment pattern (#14469) (Dunqing) - 0f19be0 oxfmt: Normalize path delimiter on Windows (#14463) (leaysgur) - 5856bc9 oxc_formatter: Fix arrow_parentheses: 'avoid' > 'as-needed' (#14462) (leaysgur) ### 🚜 Refactor - 7bc86f4 formatter: Simplify foramtting import and export (#14576) (Dunqing) - 29c3cf2 formatter: Remove `SiblingNode` (#14551) (Dunqing) - 893bdac formatter: Improve printing comments for special nodes (#14544) (Dunqing) - 97bb964 formatter: Improve line break detaching logic in SourceText (#14539) (Dunqing) ### 🧪 Testing - bb43dc5 formatter: Add snapshot-based test infrastructure (#14400) (Dunqing) Co-authored-by: leaysgur <6259812+leaysgur@users.noreply.github.com>

Copilot AI review requested due to automatic review settings October 9, 2025 09:54

github-actions bot added A-cli Area - CLI A-formatter Area - Formatter C-bug Category - Bug labels Oct 9, 2025

Copilot AI reviewed Oct 9, 2025

View reviewed changes

apps/oxfmt/tests/tester.rs Show resolved Hide resolved

leaysgur force-pushed the 10-09-fix_oxfmt_normalize_path_delimiter_on_windows branch from 38b3d5d to fa10544 Compare October 9, 2025 10:06

leaysgur requested a review from Dunqing as a code owner October 9, 2025 10:06

leaysgur force-pushed the 10-09-fix_oxfmt_normalize_path_delimiter_on_windows branch from fa10544 to 88e5805 Compare October 9, 2025 10:07

leaysgur force-pushed the 10-09-fix_oxfmt_normalize_path_delimiter_on_windows branch 2 times, most recently from 1d37e86 to e2981d5 Compare October 9, 2025 10:31

leaysgur added the 0-merge Merge with Graphite Merge Queue label Oct 9, 2025

fix(oxfmt): Normalize path delimiter on Windows (#14463)

0f19be0

Fixes CI fails on `main` branch. 🙇🏻

graphite-app bot force-pushed the 10-09-fix_oxfmt_normalize_path_delimiter_on_windows branch from e2981d5 to 0f19be0 Compare October 9, 2025 10:37

graphite-app bot merged commit 0f19be0 into main Oct 9, 2025
27 checks passed

graphite-app bot deleted the 10-09-fix_oxfmt_normalize_path_delimiter_on_windows branch October 9, 2025 10:42

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 9, 2025

Boshen mentioned this pull request Oct 14, 2025

release(oxfmt): v0.5.0 #14586

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(oxfmt): Normalize path delimiter on Windows #14463

fix(oxfmt): Normalize path delimiter on Windows #14463

Uh oh!

leaysgur commented Oct 9, 2025 •

edited

Loading

Uh oh!

leaysgur commented Oct 9, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

codspeed-hq bot commented Oct 9, 2025 •

edited

Loading

Uh oh!

leaysgur commented Oct 9, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

fix(oxfmt): Normalize path delimiter on Windows #14463

fix(oxfmt): Normalize path delimiter on Windows #14463

Uh oh!

Conversation

leaysgur commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

leaysgur commented Oct 9, 2025

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

codspeed-hq bot commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #14463 will not alter performance

Summary

Footnotes

Uh oh!

leaysgur commented Oct 9, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

leaysgur commented Oct 9, 2025 •

edited

Loading

codspeed-hq bot commented Oct 9, 2025 •

edited

Loading

leaysgur commented Oct 9, 2025 •

edited by graphite-app bot

Loading