Skip to content

fix(formatter): no need to wrap a parenthesis for TSConditionalType and TSFunctionType when its parent is TSUnionType and it only has one element #14540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2025
Merged

fix(formatter): no need to wrap a parenthesis for TSConditionalType and TSFunctionType when its parent is TSUnionType and it only has one element #14540

merged 1 commit into from
Oct 13, 2025
+18 −2

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Oct 13, 2025

No description provided.

@Dunqing Dunqing mentioned this pull request Oct 13, 2025
Merged
@github-actions github-actions bot added A-formatter Area - Formatter C-bug Category - Bug labels Oct 13, 2025
This was referenced Oct 13, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@Dunqing Graphite App
Copy link
Member Author

Dunqing commented Oct 13, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing mentioned this pull request Oct 13, 2025
Merged
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 13, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #14540 will not alter performance

Comparing 10-13-fix_formatter_no_need_to_wrap_a_parenthesis_for_tsconditionaltype_and_tsfunctiontype_when_its_parent_is_tsuniontype_and_it_only_has_one_element (620dbac) with main (59f1d8f)1

Summary

✅ 33 untouched
⏩ 4 skipped2

Footnotes

  1. No successful run was found on main (97bb964) during the generation of this report, so 59f1d8f was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@Dunqing Dunqing mentioned this pull request Oct 13, 2025
Merged
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Oct 13, 2025
@Dunqing Dunqing mentioned this pull request Oct 13, 2025
Merged
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 13, 2025 •
edited
Loading

Merge activity

@Dunqing
fix(formatter): no need to wrap a parenthesis for TSConditionalType…
620dbac 
… and `TSFunctionType` when its parent is `TSUnionType` and it only has one element (#14540)
@graphite-app graphite-app bot force-pushed the 10-13-refactor_formatter_improve_line_break_detaching_logic_in_sourcetext branch from c2ee306 to 97bb964 Compare October 13, 2025 06:33
@graphite-app graphite-app bot force-pushed the 10-13-fix_formatter_no_need_to_wrap_a_parenthesis_for_tsconditionaltype_and_tsfunctiontype_when_its_parent_is_tsuniontype_and_it_only_has_one_element branch from 1b77734 to 620dbac Compare October 13, 2025 06:34
Base automatically changed from 10-13-refactor_formatter_improve_line_break_detaching_logic_in_sourcetext to main October 13, 2025 06:39
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 13, 2025
@graphite-app graphite-app bot merged commit 620dbac into main Oct 13, 2025
27 checks passed
@graphite-app graphite-app bot deleted the 10-13-fix_formatter_no_need_to_wrap_a_parenthesis_for_tsconditionaltype_and_tsfunctiontype_when_its_parent_is_tsuniontype_and_it_only_has_one_element branch October 13, 2025 06:39
This was referenced Oct 13, 2025
Merged
Merged
Merged
@Boshen Boshen mentioned this pull request Oct 14, 2025
Merged
leaysgur added a commit that referenced this pull request Oct 14, 2025
@Boshen @leaysgur
release(oxfmt): v0.5.0 (#14586)
cf9f56c 
## [0.5.0] - 2025-10-14

### 🚀 Features

- 8077f9b oxfmt: Provide JSON schema for `.oxfmtrc.json` (#14399)
(leaysgur)
- 51ddfa8 oxfmt: Support `.oxfmtrc.json(c)` config file (#14398)
(leaysgur)

### 🐛 Bug Fixes

- c4e12df formatter: Correct checking comments around the return
argument (#14585) (Dunqing)
- 454303b formatter: Check empty lines between arguments incorrectly
(#14584) (Dunqing)
- a5554a8 formatter: Print a line break incorrectly for directives
(#14577) (Dunqing)
- 5db9774 formatter: Correct printing comments that are around the
`StaticMemberExpression` (#14543) (Dunqing)
- 620dbac formatter: No need to wrap a parenthesis for
`TSConditionalType` and `TSFunctionType` when its parent is
`TSUnionType` and it only has one element (#14540) (Dunqing)
- 1aec74f formatter: Missing parenthesis for `ComputedMemberExpression`
when its parent is an `NewExpression` (#14530) (Dunqing)
- 59f1d8f formatter: Missing parenthesis for `PrivateInExpression` when
its parent is an `UnaryExpression` (#14529) (Dunqing)
- b06059e formatter: Correct printing comments for logical expression
(#14500) (Dunqing)
- be38095 formatter: Should break even if the right side of the
assignment is a require when it has a leading own line comment (#14499)
(Dunqing)
- 4d55654 formatter: Correct printing comments for the end of union type
(#14498) (Dunqing)
- 4994872 formatter: Correct printing comments for `try` statement
(#14497) (Dunqing)
- 9a4da3d formatter: Should expand the parent if the member chain will
break (#14487) (Dunqing)
- bba9689 formatter: Correct printing comments around the expression of
`ComputedMemberExpression` (#14486) (Dunqing)
- dc5e08a formatter: Correct printing yield argument (#14485) (Dunqing)
- b8a0905 formatter: No need to wrap with parentheses for a type cast
node (#14484) (Dunqing)
- b159215 formatter: Ignore the leading line break for the first
argument of the call expression (#14483) (Dunqing)
- ea8f9ed formatter: Correct checking comments between the operator and
the right side for assignment like nodes (#14482) (Dunqing)
- 4f19504 formatter: Block comments without a leading linebreak that are
around the operator of the conditional expression should be printed
as-is (#14474) (Dunqing)
- ef77997 formatter: Correct printing comments for `for` statements
(#14473) (Dunqing)
- 31595c3 formatter: Correct printing comments for assignment pattern
(#14469) (Dunqing)
- 0f19be0 oxfmt: Normalize path delimiter on Windows (#14463) (leaysgur)
- 5856bc9 oxc_formatter: Fix arrow_parentheses: 'avoid' > 'as-needed'
(#14462) (leaysgur)

### 🚜 Refactor

- 7bc86f4 formatter: Simplify foramtting import and export (#14576)
(Dunqing)
- 29c3cf2 formatter: Remove `SiblingNode` (#14551) (Dunqing)
- 893bdac formatter: Improve printing comments for special nodes
(#14544) (Dunqing)
- 97bb964 formatter: Improve line break detaching logic in SourceText
(#14539) (Dunqing)

### 🧪 Testing

- bb43dc5 formatter: Add snapshot-based test infrastructure (#14400)
(Dunqing)

Co-authored-by: leaysgur <6259812+leaysgur@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-formatter Area - Formatter C-bug Category - Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Dunqing