-
-
Notifications
You must be signed in to change notification settings - Fork 30
refactor: allow suggestions/fixes to be generated lazily #313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
graphite-app
merged 1 commit into
main
from
10-22-refactor_allow_suggestions_fixes_to_be_generated_lazily
Oct 29, 2025
Merged
refactor: allow suggestions/fixes to be generated lazily #313
graphite-app
merged 1 commit into
main
from
10-22-refactor_allow_suggestions_fixes_to_be_generated_lazily
Oct 29, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
1cf1733 to
94dafd6
Compare
94dafd6 to
71f9af8
Compare
This was referenced Oct 24, 2025
71f9af8 to
e38f138
Compare
This was referenced Oct 27, 2025
e38f138 to
11f985e
Compare
Member
Author
Merge activity
|
Changes the type of the `ReportNode*` functions to accept a function that returns fixes or suggestions, rather than directly returning the slice of fixes/suggestions. This allows us to conditionally call this function in the future when fixes are desired. Otherwise, we can skip generating fixes and save some time. At present, this is a no-op as we just call it all of the time.
11f985e to
ea27947
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Changes the type of the
ReportNode*functions to accept a function that returns fixes or suggestions, rather than directly returning the slice of fixes/suggestions. This allows us to conditionally call this function in the future when fixes are desired. Otherwise, we can skip generating fixes and save some time.At present, this is a no-op as we just call it all of the time.