Skip to content

Conversation

@camchenry
Copy link
Member

@camchenry camchenry commented Oct 23, 2025

Changes the type of the ReportNode* functions to accept a function that returns fixes or suggestions, rather than directly returning the slice of fixes/suggestions. This allows us to conditionally call this function in the future when fixes are desired. Otherwise, we can skip generating fixes and save some time.

At present, this is a no-op as we just call it all of the time.

Copy link
Member Author

camchenry commented Oct 23, 2025

@camchenry camchenry force-pushed the 10-22-refactor_allow_suggestions_fixes_to_be_generated_lazily branch from 1cf1733 to 94dafd6 Compare October 24, 2025 01:03
@camchenry camchenry force-pushed the 10-22-refactor_allow_suggestions_fixes_to_be_generated_lazily branch from 94dafd6 to 71f9af8 Compare October 24, 2025 14:38
@camchenry camchenry marked this pull request as ready for review October 24, 2025 14:56
@camchenry camchenry requested a review from camc314 October 27, 2025 17:20
@camchenry camchenry force-pushed the 10-22-refactor_allow_suggestions_fixes_to_be_generated_lazily branch from 71f9af8 to e38f138 Compare October 27, 2025 23:32
@camchenry camchenry force-pushed the 10-22-refactor_allow_suggestions_fixes_to_be_generated_lazily branch from e38f138 to 11f985e Compare October 29, 2025 01:29
Copy link
Member Author

camchenry commented Oct 29, 2025

Merge activity

Changes the type of the `ReportNode*` functions to accept a function that returns fixes or suggestions, rather than directly returning the slice of fixes/suggestions. This allows us to conditionally call this function in the future when fixes are desired. Otherwise, we can skip generating fixes and save some time.

At present, this is a no-op as we just call it all of the time.
@graphite-app graphite-app bot force-pushed the 10-22-refactor_allow_suggestions_fixes_to_be_generated_lazily branch from 11f985e to ea27947 Compare October 29, 2025 01:52
@graphite-app graphite-app bot merged commit ea27947 into main Oct 29, 2025
6 checks passed
@graphite-app graphite-app bot deleted the 10-22-refactor_allow_suggestions_fixes_to_be_generated_lazily branch October 29, 2025 02:02
@graphite-app graphite-app bot removed the 0-merge label Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants