feat!: make fixes/suggestions opt-in #317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
camchenry
changed the base branch from
10-22-refactor_allow_suggestions_fixes_to_be_generated_lazily
to
graphite-base/317
camchenry
force-pushed
the
10-23-feat_make_fixes_suggestions_opt-in
branch
from
5177d4a to
fe274cb
Compare
camchenry
force-pushed
the
graphite-base/317
branch
from
94dafd6 to
71f9af8
Compare
camchenry
changed the base branch from
graphite-base/317
to
10-22-refactor_allow_suggestions_fixes_to_be_generated_lazily
This was referenced Oct 24, 2025
camchenry
force-pushed
the
10-23-feat_make_fixes_suggestions_opt-in
branch
2 times, most recently
from
83aede2 to
b8bdfdf
Compare
camchenry
changed the title
camchenry
changed the base branch from
10-22-refactor_allow_suggestions_fixes_to_be_generated_lazily
to
graphite-base/317
camchenry
force-pushed
the
graphite-base/317
branch
from
71f9af8 to
e38f138
Compare
camchenry
force-pushed
the
10-23-feat_make_fixes_suggestions_opt-in
branch
from
fa558f6 to
4c4dace
Compare
camchenry
changed the base branch from
graphite-base/317
to
10-22-refactor_allow_suggestions_fixes_to_be_generated_lazily
This was referenced Oct 27, 2025
camchenry
force-pushed
the
10-22-refactor_allow_suggestions_fixes_to_be_generated_lazily
branch
from
e38f138 to
11f985e
Compare
camchenry
force-pushed
the
10-23-feat_make_fixes_suggestions_opt-in
branch
from
4c4dace to
a0e26f3
Compare
graphite-app
bot
changed the base branch from
10-22-refactor_allow_suggestions_fixes_to_be_generated_lazily
to
graphite-base/317
graphite-app
bot
force-pushed
the
graphite-base/317
branch
from
11f985e to
ea27947
Compare
graphite-app
bot
force-pushed
the
10-23-feat_make_fixes_suggestions_opt-in
branch
from
a0e26f3 to
0c58d3f
Compare
graphite-app
bot
force-pushed
the
10-23-feat_make_fixes_suggestions_opt-in
branch
from
0c58d3f to
d8a7d52
Compare
camchenry
force-pushed
the
10-23-feat_make_fixes_suggestions_opt-in
branch
from
d8a7d52 to
e857d26
Compare
This was referenced Oct 29, 2025
graphite-app bot
pushed a commit
to oxc-project/oxc
that referenced
this pull request
Oct 29, 2025
In preparation for oxc-project/tsgolint#317. Enables oxlint to support missing fixes/suggestions in the payload from tsgolint.
camc314
approved these changes
Oct 29, 2025
Contributor
camc314
left a comment
camc314
left a comment
There was a problem hiding this comment.
thanks for working on this, apologies have been OOO since beginning of this week
Contributor
Merge activity
|
Adds a `-fix`and `-fix-suggestions` option to headless mode to enable generating fixes and suggestions which will be returned in the payload. If there are no fixes or suggestions, we omit the field entirely instead of returning an empty array.
graphite-app
bot
force-pushed
the
10-23-feat_make_fixes_suggestions_opt-in
branch
from
e857d26 to
f430beb
Compare
graphite-app bot
pushed a commit
to oxc-project/oxc
that referenced
this pull request
Oct 30, 2025
With oxc-project/tsgolint#317, tsgolint fixes will become opt-in. So, we need to pass the `-fix` and `-fix-suggestions` when fixes are enabled in oxlint. @camc314 This will need to be added in oxlint with, or before switching to the next version of tsgolint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
-fixand-fix-suggestionsoption to headless mode to enable generating fixes and suggestions which will be returned in the payload. If there are no fixes or suggestions, we omit the field entirely instead of returning an empty array.