-
-
Notifications
You must be signed in to change notification settings - Fork 30
perf: no-confusing-void-expression: only generate fixes and suggestions when fixing
#321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
graphite-app
merged 1 commit into
main
from
10-23-perf_no-confusing-void-expression_only_generate_fixes_and_suggestions_when_fixing
Oct 29, 2025
Merged
perf: no-confusing-void-expression: only generate fixes and suggestions when fixing
#321
graphite-app
merged 1 commit into
main
from
10-23-perf_no-confusing-void-expression_only_generate_fixes_and_suggestions_when_fixing
Oct 29, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 24, 2025
Member
Author
2f8a2e7 to
f947f70
Compare
0a50b1e to
bf5ac51
Compare
bf5ac51 to
9af99fd
Compare
f947f70 to
84b4223
Compare
This was referenced Oct 27, 2025
camc314
approved these changes
Oct 29, 2025
Merge activity
|
84b4223 to
459c98a
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Oct 29, 2025
…ions when fixing (#321) No need to allocate and generate fixes unless they are requested.
9af99fd to
f6cb66d
Compare
459c98a to
589352b
Compare
Base automatically changed from
10-23-perf_no-array-delete_only_get_token_ranges_when_fixing
to
main
October 29, 2025 22:15
…ions when fixing (#321) No need to allocate and generate fixes unless they are requested.
f6cb66d to
d2ab1e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

No need to allocate and generate fixes unless they are requested.