Skip to content

perf: no-array-delete: only get token ranges when fixing #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2025
Merged

perf: no-array-delete: only get token ranges when fixing #320

merged 1 commit into from
Oct 29, 2025

Conversation

@camchenry
Copy link
Member

@camchenry camchenry commented Oct 24, 2025 •
edited
Loading

Less work when not fixing: only get the token ranges when fixes should be generated, rather than doing it everytime.

This was referenced Oct 24, 2025
Merged
Merged
@camchenry Graphite App
Copy link
Member Author

camchenry commented Oct 24, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add the label 0-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camchenry camchenry mentioned this pull request Oct 24, 2025
Merged
@camchenry camchenry changed the base branch from 10-23-feat_make_fixes_suggestions_opt-in to graphite-base/320 October 24, 2025 14:57
@camchenry camchenry force-pushed the 10-23-perf_no-array-delete_only_get_token_ranges_when_fixing branch from 2f8a2e7 to f947f70 Compare October 24, 2025 15:47
@camchenry camchenry changed the base branch from graphite-base/320 to 10-23-feat_make_fixes_suggestions_opt-in October 24, 2025 15:47
@camchenry camchenry marked this pull request as ready for review October 24, 2025 17:25
@camchenry camchenry mentioned this pull request Oct 25, 2025
Merged
@camchenry camchenry changed the base branch from 10-23-feat_make_fixes_suggestions_opt-in to graphite-base/320 October 27, 2025 23:32
@camchenry camchenry force-pushed the 10-23-perf_no-array-delete_only_get_token_ranges_when_fixing branch from f947f70 to 84b4223 Compare October 27, 2025 23:32
@camchenry camchenry changed the base branch from graphite-base/320 to 10-23-feat_make_fixes_suggestions_opt-in October 27, 2025 23:32
This was referenced Oct 27, 2025
Merged
Merged
Merged
Merged
Closed
@camchenry camchenry changed the base branch from 10-23-feat_make_fixes_suggestions_opt-in to graphite-base/320 October 29, 2025 01:29
@graphite-app
Copy link

graphite-app bot commented Oct 29, 2025 •
edited
Loading

Merge activity

  • Oct 29, 9:33 PM UTC: camc314 added this pull request to the Graphite merge queue.
  • Oct 29, 9:52 PM UTC: camc314 removed this pull request from the Graphite merge queue.
  • Oct 29, 9:56 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 29, 9:57 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 29, 9:57 PM UTC: The merge label '0-merge' was removed. This PR will no longer be merged by the Graphite merge queue
  • Oct 29, 10:15 PM UTC: camc314 added this pull request to the Graphite merge queue.
  • Oct 29, 10:15 PM UTC: Merged by the Graphite merge queue.

graphite-app bot pushed a commit that referenced this pull request Oct 29, 2025
@camchenry
perf: no-array-delete: only get token ranges when fixing (#320)
459c98a 
Less work when not fixing: only get the token ranges when fixes should be generated, rather than doing it everytime.
@graphite-app graphite-app bot force-pushed the 10-23-perf_no-array-delete_only_get_token_ranges_when_fixing branch from 84b4223 to 459c98a Compare October 29, 2025 21:37
@graphite-app graphite-app bot changed the base branch from graphite-base/320 to 10-23-feat_make_fixes_suggestions_opt-in October 29, 2025 21:38
Base automatically changed from 10-23-feat_make_fixes_suggestions_opt-in to main October 29, 2025 21:46
@camchenry @camc314
perf: no-array-delete: only get token ranges when fixing (#320)
589352b 
Less work when not fixing: only get the token ranges when fixes should be generated, rather than doing it everytime.
@camc314 camc314 force-pushed the 10-23-perf_no-array-delete_only_get_token_ranges_when_fixing branch from 459c98a to 589352b Compare October 29, 2025 21:55
@camc314 camc314 added 0-merge and removed 0-merge labels Oct 29, 2025
@graphite-app graphite-app bot merged commit 589352b into main Oct 29, 2025
6 checks passed
@graphite-app graphite-app bot deleted the 10-23-perf_no-array-delete_only_get_token_ranges_when_fixing branch October 29, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camc314 camc314 camc314 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@camchenry @camc314