Custom Shifts #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsaacElenbaas
force-pushed
the
as_custom_shifts_keyrepeat
branch
from
8c99deb
to
01a7688
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Working on some stuff with the functions to make you need less and them give more info. |
IsaacElenbaas
force-pushed
the
as_custom_shifts_keyrepeat
branch
from
2f72a7c
to
882fb4f
Compare
|
I'm happy with where it's at now, but leaving as draft at least until/if cleanup is merged. Still open to ideas to better the functions, and I'm not sure if the docs are clear/concise enough. |
IsaacElenbaas
force-pushed
the
as_custom_shifts_keyrepeat
branch
from
a468dab
to
bb0e850
Compare
|
Well, I tried to resolve the conflicts here as well, but now GitHub just says they're "too complex to resolve in the web editor" lol |
8 tasks
|
With tap-hold action support being added here, I don't see a use for |
Update readme.md
* Initial work for consolidation of board files and default ChibiOS configs. * Migrate F401/F411 black pills for testing. * Add early init bootloader jump flag. * Add support for I2C in order to use i2c_scanner keymap. * Add F401/F411 HSE bypass to get things booting. * Exempt "hooked" ChibiOS conf files from updater script. * Fix up ordering for bootloader_defs file check. * Match previous $(KEYBOARD_PATHS) value for Proton-C, updated for all board configs.
… inline functions (qmk#9055)
* Change analogRead calls to analogReadPin * Add ChangeLog * Update docs, remove mention of `analogRead()` * Retarget changelog for next round
Mousekey scrolling should have a separate repeat variable to keep track of scrolling acceleration, instead of being tied to mouse movement scolling in mousekeys. The send function should record when the last movement was made since this is when movement is actually sent. Doing this fixes the bug where the initial press of a mousekey scroll button causes a double scroll. Signed-off-by: Daniel Hong <daniel.hong@live.com>
… charge RC circuit. (qmk#8778)
* Add change log * Change combo index from uint8_t to uint16_t
* Re-fix the dual-bank bootloader stuff. * Use wait_ms() instead of using nop's for a delay, as ChibiOS is actually running at the time of bootloader jump.
* Disable NKRO on V-USB controllers * not _currently_ supported text Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: Ryan <fauxpark@gmail.com>
When processing a different keypress record, register the outstanding key from the auto-shift.
Update the auto shift docs to reflect that repeats now work.
- Functions working how I want them to - Fixed press->press->(release first) releasing both AS keys - Updated docs, though I'm not sure if they're clear enough
IsaacElenbaas
force-pushed
the
as_custom_shifts_keyrepeat
branch
from
96fd35f
to
eb96a3b
Compare
p00ya
force-pushed
the
pull-auto-shift
branch
2 times, most recently
from
2e114f8
to
83a090d
Compare
p00ya
force-pushed
the
pull-auto-shift
branch
from
83a090d
to
c1923a8
Compare
p00ya
pushed a commit
that referenced
this pull request
Nov 14, 2020
* Add Initial layout configuration. * Set arduino pro micro's built in RX LED as Numlock * Enable Autoshift feautre. * Remove DVORAK layout. * Add Numpad, update default layer. * Update AutoShift timeout. * Beautify ASCII Art. * Update keymap. * Add Initial verison of RGB lighting. * Add Tap dance, hungarian letters. .Xmodmap example: geripgeri/dotfiles@09f0587 * Update RGB to use only noeeprom functions. * Change default rgb led color. * Add `pragma once`. * Emojis added. * Add tap dance for hungarian letters, multimedia control, slash/backslash. * Remove audio related code. * Add Gaming layer. * Remove unnecessary code, update copyright. * Add readme.md * Implement code review suggestions. * Implement code review suggestions #2 * Remove Auto Shift feature. * Remove Gaming layer.
p00ya
force-pushed
the
pull-auto-shift
branch
from
c1923a8
to
70dc57e
Compare
13 tasks
p00ya
force-pushed
the
pull-auto-shift
branch
from
94a59d7
to
4c7f736
Compare
|
Will be reopened into develop. |
14 tasks
p00ya
pushed a commit
that referenced
this pull request
Jan 14, 2023
) * Replace Tapping Force Hold feature with Quick Tap Term * Replace keyboard level TAPPING_FORCE_HOLD with QUICK_TAP_TERM 0 * Deprecate force hold in info_config.json * Before and after quick tap term unit tests * Quick tap unit tests iteration * Keymap config.h correction * Remove TAPPING_FORCE_HOLD_PER_KEY macros that were missed * Add two more test cases for quick tap * Replace TAPPING_FORCE_HOLD with QUICK_TAP_TERM in configs #2 * Replace TAPPING_FORCE_HOLD_PER_KEY with QUICK_TAP_TERM_PER_KEY in configs #2 * Add function declaration for get_quick_tap_term Co-authored-by: Stefan Kerkmann <karlk90@pm.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1. The pressing and releasing of autoshift keys is done with two functions, passed a keycode and whether they should be shifted (release needs it for if you have a different base key for the shifted value). There is also a function to simply add keys to AS, which can also be used for other things (required for mod-taps that autoshift, for example) if needed.