Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add asymmetric encryption to TS provider #295

Closed

Conversation

ionut-arm
Copy link
Member

This commit adds asymmetric encryption functionality in the TS
provider. It also moves the TS protobuf code in a new module given
that it now contains a bunch of hand written code as well.

Signed-off-by: Ionut Mihalcea ionut.mihalcea@arm.com

ionut-arm and others added 12 commits November 6, 2020 10:49
Adding components for creating an FFI wrapper and protobuf code, a
Cargo feature, and a Docker image.

Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
Create base of Trusted Service provider - it connects to the service
and can be instantiated in the service.

Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
This commit adds functionality for generating and destroying
keys in the Trusted Service provider.

Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
Add generate and destroy key to TS provider
This commit adds functionality to the Trusted Service provider
allowing it to sign and verify hashes.

Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
Add asymmetric sign and verify to TS provider
This commit implements import and export public key for the Trusted
Service provider.

Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
This commit adds documentation to the structures and methods in the new
Trusted Service provider. A few small fixes are also added, along with a
finer-grained approach to zeroizing the key data in import_key.

Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
@ionut-arm ionut-arm added enhancement New feature or request firmware framework Issues related to compatibility with Arm FF-A labels Nov 27, 2020
@ionut-arm ionut-arm self-assigned this Nov 27, 2020
@ionut-arm
Copy link
Member Author

  1. I forgot to add documentation, will go through the whole code again on Monday.

  2. I tested it out locally and there seems to be an issue within the Trusted Service with handling the salt. They've been made aware of this.

@ionut-arm
Copy link
Member Author

Will wait to get CI working first

ionut-arm and others added 5 commits November 30, 2020 15:29
This commit imports the TS code as a submodule and uses it to
build and test the provider on the CI.

Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
This commit implements proper error handling for errors originating
from the TS Context.

Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
This commit modifies the stress test and the stress test client to only
check asymmetric encryption/decryption when they're supported by the
provider.

Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
This commit adds asymmetric encryption functionality in the TS
provider. It also moves the TS protobuf code in a new module given
that it now contains a bunch of hand written code as well.

Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
@ionut-arm
Copy link
Member Author

CI will fail because of some issues with the TS implementation, will keep this parked until those get resolved.

@ionut-arm ionut-arm closed this Jan 19, 2021
@ionut-arm ionut-arm deleted the ts-asym-encr branch January 19, 2021 14:15
@ionut-arm ionut-arm restored the ts-asym-encr branch January 19, 2021 14:16
@ionut-arm ionut-arm reopened this Jan 19, 2021
@ionut-arm
Copy link
Member Author

Sorry, ended up deleting the branch without realising :]

@ionut-arm ionut-arm force-pushed the trusted-service-provider branch 4 times, most recently from 543aaf9 to d78e3a3 Compare January 29, 2021 12:11
@ionut-arm ionut-arm closed this Jan 29, 2021
@ionut-arm ionut-arm deleted the branch parallaxsecond:trusted-service-provider January 29, 2021 13:57
@ionut-arm ionut-arm removed the on-hold label Jul 6, 2021
@ionut-arm ionut-arm added this to the Parsec Release 0.8.0 milestone Jul 6, 2021
@ionut-arm ionut-arm deleted the ts-asym-encr branch July 22, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request firmware framework Issues related to compatibility with Arm FF-A
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant