Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

polkompanion 6667: past session slashing #2160

Merged
merged 17 commits into from
May 26, 2023
Merged

polkompanion 6667: past session slashing #2160

merged 17 commits into from
May 26, 2023

Conversation

ordian
Copy link
Member

@ordian ordian commented Feb 3, 2023 •
edited
Loading

paritytech/polkadot#6667.

Questions:

  • Not sure if I should be adding these methods to RelayChainRpcClient considering they are not supposed to be called by the collators.

@ordian ordian added B0-silent Changes should not be mentioned in any release notes A0-please_review Pull request needs code review. A4-companion A PR that should be considered alongside another (usually more comprehensive and detailed) PR. C1-low PR touches the given topic and has a low impact on builders. T3-relay_chain This PR/Issue is related to the Relay Chain. T1-runtime This PR/Issue is related to the topic “runtime”. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Feb 3, 2023
@ordian ordian mentioned this pull request Feb 3, 2023
Merged
@mrcnski mrcnski self-requested a review February 5, 2023 11:16
@ordian
Merge branch 'master' into ao-past-session-slashing-companion
a1df3e8 
* master: (35 commits)
  add turboflakes system-chains bootnodes (#2223)
  Companion for #13349 (#2217)
  bump `zombienet` version to v1.3.35 (#2226)
  [ci] Return benchmark to bm machines (#2225)
  Collectives chain xcm filter (#2222)
  Add metaspan.io parachain boot nodes (#2218)
  Companion for #13390 (#2189)
  `BlockId` removal: `BlockBuilderProvider::new_block_at` (#2219)
  Benchmarks script improvements (#2214)
  `BlockId` removal: refactor of runtime API (#2190)
  Rename .feature extension to .zndsl (#2215)
  Companion for paritytech/polkadot#6744: Retire `OldV1SessionInfo` (#2213)
  WIP: Fix templates (#2204)
  Add stake.plus bootnodes to collectives-westend and bridge-hub-kusama (#2201)
  Polkadot companion #6603: Use a `BoundedVec` in `ValidationResult` (#2161)
  Bump clap from 4.1.4 to 4.1.6 (#2193)
  Bump toml from 0.6.0 to 0.7.2 (#2170)
  companion for paritytech/polkadot#6161 (#2151)
  Bump serde_json from 1.0.92 to 1.0.93 (#2175)
  add warp_sync_params (#1909)
  ...
@ordian
Merge branch 'master' into ao-past-session-slashing-companion
1ba14e8 
* master: (44 commits)
  Companion for #13287 (#2155)
  timestamp ci job logs (#2327)
  Release parachain host API v4 (#2325)
  Bump clap from 4.1.6 to 4.1.8 (#2272)
  Enabled `polkadot-parachain` build for `runtime-benchmarks`, e.g.: (#2324)
  Bump tokio from 1.25.0 to 1.26.0 (#2273)
  Bump async-trait from 0.1.64 to 0.1.66 (#2318)
  ReadMe followup for  #2313 (#2317)
  Fix runtime api import path (#2319)
  Update Westend collectives chainspec (#2311)
  README: Document usage of RPC node (#2313)
  Companion for paritytech/substrate#13592 (#2310)
  Update orchestra and metered-channel (#2304)
  Backport: Brigehub: Add in force upgrade xcm version (into master) (#2289)
  [Backport] version bumps from 9380 (#2309)
  Bump proc-macro2 from 1.0.50 to 1.0.52 (#2312)
  Remove use of trait Store (#2286)
  Companion for #13482 (#2303)
  add amforc bootnodes (#2246)
  Cleanup dependencies + dead code (#2302)
  ...
@ordian
fix incorrect merge
29b9157
@ordian
Merge branch 'master' into ao-past-session-slashing-companion
29be66e 
* master:
  Companion for #13624 (#2354)
  Introduce Fellowship into Collectives (#2186)
  NFTs 2.0 on Statemine (#2314)
  Bump assert_cmd from 2.0.8 to 2.0.10 (#2341)
  Bump clap from 4.1.8 to 4.1.11 (#2352)
  Companion for substrate #13312: Rename `Deterministic` to `Enforce` (#2350)
  [Companion #13634] keystore overhaul (iter) (#2345)
  Revert #2304 (#2349)
  Deprecate Currency: Companion for #12951 (#2334)
  Bump ci-linux image for rust 1.68
  Always pass port to jsonrpsee WebSocket client (#2339)
  bump zombienet to v1.3.40 (#2348)
  Improve build times by disabling wasm-builder in `no_std` (#2308)
  Bump toml from 0.7.2 to 0.7.3 (#2340)
  Bump serde from 1.0.152 to 1.0.156 (#2329)
  Parachains should charge for proof size weight (#2326)
  dmp-queue: Store messages if already processed more than the maximum (#2343)
  [Companion  #13615] Keystore overhaul (#2336)
  Bump quote from 1.0.23 to 1.0.26 (#2331)
@ordian
Merge branch 'master' into ao-past-session-slashing-companion
e9327cd 
* master:
  Add Support for Foreign Assets (#2133)
  XCM V2 weight template (#2344)
  Companion for polkadot#6928 (#2356)
  move back to ci-linux@production image
@ordian
Merge branch 'master' into ao-past-session-slashing-companion
2313a82 
* master:
  Bump thiserror from 1.0.38 to 1.0.40 (#2396)
  Companion: wasm-builder support stable Rust (#2393)
  Bump serde_json from 1.0.94 to 1.0.95 (#2387)
  Bump scale-info from 2.3.1 to 2.4.0 (#2386)
  Remove HeaderBackend from RelayChainRPCClient (#2385)
  Bump clap from 4.1.11 to 4.1.13 (#2388)
  Bump futures from 0.3.26 to 0.3.27 (#2359)
  Bump serde_json from 1.0.93 to 1.0.94 (#2279)
  Bump async-trait from 0.1.66 to 0.1.68 (#2381)
  bump timestamp script to v0.2 (#2379)
  Companion for #13683 (#2371)
  Co #13637: Remove Weight::without_{ref_time, proof_size} (#2346)
@ordian
Merge branch 'master' into ao-past-session-slashing-companion
d217533 
* master: (58 commits)
  Bump h2 from 0.3.9 to 0.3.17 (#2451)
  Bump actions/cache from 3.2.3 to 3.3.1 (#2488)
  Bump actions/upload-artifact from 3.1.1 to 3.1.2 (#2487)
  Bump chevdor/srtool-actions from 0.6.0 to 0.7.0 (#2486)
  Bump actions/download-artifact from 3.0.1 to 3.0.2 (#2485)
  Companion for substrate#13565 (#2306)
  Bump actions/cache from 3.0.11 to 3.2.3 (#2082)
  Bump actions/upload-artifact from 3.1.0 to 3.1.1 (#1799)
  Bump actions/download-artifact from 3.0.0 to 3.0.1 (#1798)
  Bump ruby/setup-ruby from 1.146.0 to 1.147.0 (#2484)
  Bump ruby/setup-ruby from 1.133.2 to 1.146.0 (#2466)
  Bump enumflags2 from 0.7.5 to 0.7.7 (#2481)
  [ci] Update buildah command and version (#2479)
  Align BridgeHub runtimes with other SP runtimes + reused test for teleport native tokens + some nits (#2449)
  [Polkadot Companion] for 7101 (#2470)
  Parachain node should not recover blocks while syncing (#2462)
  Companion for substrate#13771 (#2410)
  Bump Swatinem/rust-cache from 2.2.0 to 2.2.1 (#2456)
  Bump clap from 4.1.14 to 4.2.3 (#2465)
  Optimize level monitor reconstruction (#2461)
  ...
@ordian
Merge branch 'master' into ao-past-session-slashing-companion
e43ce93 
* master: (75 commits)
  Add Foreign Assets to Statemint (#2540)
  Bump casey from 0.3.3 to 0.4.0 (#2619)
  Companion for substrate#14188 (Add genesis config to Glutton pallet) (#2612)
  Use default for test relay runtimes (#2616)
  use `WasmExecutionMethod::default()` (#2622)
  Bump Swatinem/rust-cache from 2.3.0 to 2.4.0 (#2617)
  Do not assume `AssetId`s are `Copy` (companion for substrate#14158) (#2586)
  NFT Fractionalization on Westmint (#2600)
  Try-runtime proper return types (#2615)
  Nfts on Statemint (#2595)
  Update substrate/polkadot + needed changes to compile (#2613)
  Chainspecs: Fix bootnode address (#2611)
  Bump Swatinem/rust-cache from 2.2.1 to 2.3.0 (#2582)
  Bump ruby/setup-ruby from 1.148.0 to 1.149.0 (#2581)
  update WasmExecutionMethod (#2599)
  Switch to `relay_dispatch_queue_remaining_capacity` (#2608)
  Update syn (#2605)
  Update README.md (#2603)
  [Feature] XCM-Emulator (#2447)
  Removed Cargo.lock from subtreee (#2604)
  ...
@ordian
Merge branch 'master' into ao-past-session-slashing-companion
ddfc961 
* master:
  Companion for #14178: Update cargo.lock to point to substrate (#2623)
  Change SA for Rococo/Statemine_1000 + removed `CheckedExtrinsic` (#2627)
@ordian ordian marked this pull request as ready for review May 24, 2023 10:31
@ordian ordian requested a review from eskimor May 24, 2023 10:32
@ordian
Merge branch 'master' into ao-past-session-slashing-companion
8036142 
* master:
  Bump criterion from 0.4.0 to 0.5.0 (#2628)
  add statemine emulator tests (#2630)
  Updated README.md for bridges (#2629)
@ordian ordian requested a review from skunert May 24, 2023 12:55
@skunert
Copy link
Contributor

skunert commented May 25, 2023

Not sure if I should be adding these methods to RelayChainRpcClient considering they are not supposed to be called by the collators.

I think it would be preferable to have these implemented. Basically the RuntimeApiSubsystemClient is the interface that tells us which runtime calls are potentially executed by the runtime API subsystem. Whether or not it is actually called on the code paths should not be relevant to the cumulus side.

@ordian ordian marked this pull request as draft May 25, 2023 08:25
@ordian ordian marked this pull request as ready for review May 25, 2023 09:27
@ordian
Merge branch 'master' into ao-past-session-slashing-companion
625eeb5 
* master:
  fix typo (#2635)
  Companion for: Substrate#13869 (#2631)
  Bump clap from 4.2.7 to 4.3.0 (#2634)
  Update & revamp e2e tests (#2614)
@ordian
Merge branch 'master' into ao-past-session-slashing-companion
579a20d 
* master:
  Companion for polkadot#7234 (XCM: Tools for uniquely referencing messages) (#2601)
  bump substrate version (#2640)
  bump zombienet version (#2637)
@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit c608131 into master May 26, 2023
@paritytech-processbot paritytech-processbot bot deleted the ao-past-session-slashing-companion branch May 26, 2023 10:13
@ordian ordian mentioned this pull request Aug 31, 2023
Merged
@ordian ordian mentioned this pull request Sep 28, 2023
Merged
@crystalin crystalin mentioned this pull request Oct 20, 2023
Closed
@JesseAbram JesseAbram mentioned this pull request Oct 26, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@skunert skunert skunert approved these changes

@tdimitrov tdimitrov tdimitrov approved these changes

@mrcnski mrcnski Awaiting requested review from mrcnski

@eskimor eskimor Awaiting requested review from eskimor

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. A4-companion A PR that should be considered alongside another (usually more comprehensive and detailed) PR. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T1-runtime This PR/Issue is related to the topic “runtime”. T3-relay_chain This PR/Issue is related to the Relay Chain.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ordian @skunert @tdimitrov