Resolving Compile Errors in Core Time Prep Tests #1793

BradleyOlson64 · 2023-10-04T21:33:23Z

This leaves one build error I wasn't sure how to handle in builder.rs.

No guarantees all the tests still pass, but I did my best to swap in the new types without altering any logic.

This reverts commit b749ff2 (#1745).

# Description This PR introduces two changes: - the previous `Tracing` trait has been modified to accept contract address instead of code hash (seems to be way more convenient) - a new trait `CallInterceptor` that allows intercepting contract calls; in particular the default implementation for `()` will just proceed in a standard way (after compilation optimizations, there will be no footprint of that); however, implementing type might decide to mock invocation and return `ExecResult` instead Note: one might try merging `before_call` and `intercept_call`. However, IMHO this would be bad, since it would mix two completely different abstractions - tracing without any effects and actual intervention into execution process. This will unblock working on mocking contracts utility in drink and similar tools (inkdevhub/drink#33) # Checklist - [x] My PR includes a detailed description as outlined in the "Description" section above - [ ] My PR follows the [labeling requirements](https://github.com/paritytech/polkadot-sdk/blob/master/docs/CONTRIBUTING.md#process) of this project (at minimum one label for `T` required) - [x] I have made corresponding changes to the documentation (if applicable) - [x] I have added tests that prove my fix is effective or that my feature works (if applicable)

This PR is part of [Sync 2.0](#534) refactoring aimed at making `ChainSync` a pure state machine. Resolves #501.

closes #158. partially addresses #226. Instead of fragile calculation of current balance by looking at `free balance - ED`, Nomination Pool now freezes ED in the pool reward account to restrict an account from going below minimum balance. This also has a nice side effect that if ED changes, we know how much is the imbalance in ED frozen in the pool and the current required ED. A pool operator can diligently top up the pool with the deficit in ED or vice versa, withdraw the excess they transferred to the pool. ## Notable changes - New call `adjust_pool_deposit`: Allows to top up the deficit or withdraw the excess deposited funds to the pool. - Uses Fungible trait (instead of Currency trait). Since NP was not doing any locking/reserving previously, no migration is needed for this. - One time migration of freezing ED from each of the existing pools (not very PoV friendly but fine for relay chain).

Derive `RuntimeDebug\Eq\PartialEq` but do not bound any generics. This achieved by using their equivalent no bound versions: `EqNoBound\PartialEqNoBound\RuntimeDebugNoBound`. Deriving with `Debug`, `Eq`, and `PartialEq` for the `Debt` and `Credit` type aliases of `Imbalance` is not feasible due to the `OnDrop` and `OppositeOnDrop` generic types lacking implementations of the same traits. This absence posed challenges in testing and any scenarios that demanded the traits implementations for the type.

Co-authored-by: Bastian Köcher <git@kchr.de>

@kianenigma

What does this PR do? - Introduced the TotalValueLocked storage for nomination-pools. - introduced a slashing api in mock.rs - additional test for tracking a slashing event towards a pool without sub-pools - migration for the nomination-pools (V6 to V7) with `VersionedMigration` Why are these changes needed? this is the continuation of the work by @kianenigma in this [PR](paritytech/substrate#13319) How were these changes implemented and what do they affect? - It's an extra StorageValue that's modified whenever funds flow in or out of staking for any of the `bonded_account` of `BondedPools` - The `PoolSlashed`event is now emitted even when no `SubPools` are found Closes #155 KSM: HHEEgVzcqL3kCXgsxSfJMbsTy8dxoTctuXtpY94n4s8F4pS --------- Co-authored-by: Liam Aharon <liam.aharon@hotmail.com> Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> Co-authored-by: Ankan <10196091+Ank4n@users.noreply.github.com> Co-authored-by: Ankan <ankan.anurag@gmail.com> Co-authored-by: command-bot <>

Moving a few pallets to the latest and greatest `derive_impl` to give it a try. Part of #171 --------- Co-authored-by: Adrian Catangiu <adrian@parity.io> Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>

Closes: #1718

…o CI (#1344) Makes SPs first class citizens along with the relay chains in the context of our CI runtime upgrade checks. ## Code changes - Sets missing current storage version in `uniques` pallet - Adds multisig V1 migration to run where it was missing - Removes executed migration whos pre/post hooks were failing from collectives runtime - Initializes storage versions for SP pallets added after genesis - Originally I was going to wait for #1297 to be merged so this wouldn't need to be done manually, but it doesn't seem like it'll be merged any time soon so I've decided to set them manually to unblock this ## CI changes - Removed dependency of `westend` runtime upgrades being complete prior to other ones running. I assume it is supposed to cache the `try-runtime` build for a performance benefit, but it seems it wasn't working. Maybe someone from the CI team can look into this or explain why it needs to be there? - Adds check-runtime-migration jobs for Parity asset-hubs, bridge-hubs and contract chains - Updated VARIABLES to accomodate the `kusama-runtime` package being renamed to `staging-kusama-runtime` in #1241 - Added `EXTRA_ARGS` variable to `check-runtime-migration`, and set `--no-weight-warnings` to the relay chain runtime upgrade checks (relay chains don't have weight restrictions).

…tem (#1761) re: https://forum.polkadot.network/t/blocknumber-vs-timestamps-should-we-abandon-blocktimes-altogether/4077 This exposes the `LastRelayChainBlockNumber` storage member of `cumulus-pallet-parachain-system` with a getter and alters the behavior of this storage item to only be updated in `on_finalize` to ensure a consistent value throughout `on_initialize` and within transactions. Parachains, especially with features such as asynchronous backing and agile coretime, should not use the parachain block number as a clock. Any feature of Polkadot intended to optimize core utilization and parachain coretime consumption is likely to worsen this clock as it is practically applied.

Since the hash rules of this part of the `pallet_prefix/storage_prefix` are always fixed, we can put the runtime calculation into compile time. --- polkadot address: 15ouFh2SHpGbHtDPsJ6cXQfes9Cx1gEFnJJsJVqPGzBSTudr --------- Co-authored-by: Juan <juangirini@gmail.com> Co-authored-by: command-bot <> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Co-authored-by: Branislav Kontur <bkontur@gmail.com>

## [Updated review bot version](677610b) updated version to version `2.0.1` which contains paritytech/review-bot#90, a fix for the team members not being fetch in its totality. ## [Updated review-bot.yml minApprovals convention](b144683) Renamed `min_approvals` to `minApprovals`. A breaking change in paritytech/review-bot#86 which was done to standarize all the cases (so now everything is camelCase)

Applied changes from the [User Update Guide](https://docs.google.com/document/d/1WQijD3bZTCsudOyPcDvugv659nCa2hEp2b_8eRU0h-Q), diverging in the node side where service.rs is different for `polkadot-parachain` than in the parachain template.

…kadot-sdk into brad-core-time-tests

eskimor

Good work @BradleyOlson64 ! Left a few comments. I think we should untangle tests a bit. It should not be that we need to expose assigner internals to scheduler tests.

polkadot/runtime/parachains/src/assigner_on_demand/mod.rs

eskimor · 2023-10-04T22:17:49Z

polkadot/runtime/parachains/src/assigner_on_demand/mod.rs

@@ -491,6 +507,27 @@ where
 })
 }

+ #[cfg(test)]
+ pub fn add_on_demand_order(


polkadot/runtime/parachains/src/scheduler.rs

polkadot/runtime/parachains/src/scheduler/tests.rs

Might panic at runtime if legacy parachain assignment provider is not configured correctly.

BradleyOlson64 · 2023-10-18T19:46:50Z

Commenting to highlight, I'm greatly shortening availability_predicate_works(). It seems that the predicate doesn't depend at all on registering parachains or scheduling paras entries, as is done in the test. Please review this closely though in case I'm wrong!

…kadot-sdk into brad-core-time-tests

eskimor

Nice! Thanks @BradleyOlson64 !

eskimor · 2023-10-25T09:00:45Z

polkadot/runtime/parachains/src/assigner_parachains.rs

 pub struct ParachainsAssignment {
 pub para_id: ParaId,
 }

 impl ParachainsAssignment {
- fn new(para_id: ParaId) -> Self {
+ pub(super) fn new(para_id: ParaId) -> Self {


If we moved the parachains test parachains_assigner_pop_assignment_is_always_some one level down (to here), then we would not need to break encapsulation and could keep this private.

eskimor · 2023-10-25T09:35:22Z

polkadot/runtime/parachains/src/scheduler/tests.rs


- // cores 0 and 1 are occupied by lease holding parachains. cores 2 and 3 are occupied by
- // on-demand parachain claims. core 4 was free.
+ // cores 0 and 1 are occupied by on-demand claims. core 2 was free.


I think this comment is outdated. (No on-demand here)

eskimor · 2023-10-25T09:40:27Z

polkadot/runtime/parachains/src/scheduler.rs


-  T::AssignmentProvider::report_processed(dropped.assignment);
+ for _ in 0..num_dropped {


Note: I refactored/cleaned up this a bit more.

paritytech-cicd-pr · 2023-10-25T20:43:31Z

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 3/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4088846

paritytech-cicd-pr · 2023-10-25T20:43:31Z

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4088834

Mira Ressel and others added 20 commits September 29, 2023 14:44

Revert "fix(review-bot): pull secrets from master environment" (#1748)

ef3adf9

This reverts commit b749ff2 (#1745).

Move import queue from ChainSync to SyncingEngine (#1736)

0691c91

This PR is part of [Sync 2.0](#534) refactoring aimed at making `ChainSync` a pure state machine. Resolves #501.

Point documentation links to monorepo (#1741)

9485b0b

improve service error (#1734)

8fe947a

Co-authored-by: Bastian Köcher <git@kchr.de>

migrate alliance, fast-unstake and bags list to use derive-impl (#1636)

2ed66a0

Moving a few pallets to the latest and greatest `derive_impl` to give it a try. Part of #171 --------- Co-authored-by: Adrian Catangiu <adrian@parity.io> Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>

no-bound derives: Use absolute path for core (#1763)

c54ea64

Closes: #1718

Update bridges subtree (#1740)

d80171e

Co-authored-by: Branislav Kontur <bkontur@gmail.com>

remove outdated scripts (#1769)

f4827dc

Updating glutton for async backing (#1619)

0a6dfdf

Applied changes from the [User Update Guide](https://docs.google.com/document/d/1WQijD3bZTCsudOyPcDvugv659nCa2hEp2b_8eRU0h-Q), diverging in the node side where service.rs is different for `polkadot-parachain` than in the parachain template.

Fixed test compile errors

2bafc11

Merge branch 'rk-core-time-prep' of https://github.com/paritytech/pol…

4a971d7

…kadot-sdk into brad-core-time-tests

Fixing errors after merge

2a079fa

BradleyOlson64 added the T9-parachains_protocol label Oct 4, 2023

BradleyOlson64 requested a review from eskimor October 4, 2023 21:33

BradleyOlson64 self-assigned this Oct 4, 2023

BradleyOlson64 had a problem deploying to master October 4, 2023 21:33 — with GitHub Actions Failure

eskimor reviewed Oct 4, 2023

View reviewed changes

eskimor had a problem deploying to master October 4, 2023 22:33 — with GitHub Actions Failure

Fix builder compilation.

7ab7e38

Might panic at runtime if legacy parachain assignment provider is not configured correctly.

eskimor had a problem deploying to master October 4, 2023 23:06 — with GitHub Actions Failure

BradleyOlson64 added 6 commits October 14, 2023 08:50

Generic get_assignment_provider_config

495ac04

Simplified mock assigner

b7e6d36

Fixed builder to work with Mock Assigner

c9c4f08

Edited scheduler tests for minimal mock assigner

f4dd55b

Added unified assigner test file

12a2289

fmt

d0c2a9b

the-right-joyce removed the T9-parachains_protocol label Oct 23, 2023

Removed parachain + parathread mentions from tests

41c15e2

BradleyOlson64 had a problem deploying to master October 23, 2023 16:33 — with GitHub Actions Failure

fmt

7a191c8

BradleyOlson64 had a problem deploying to master October 23, 2023 16:34 — with GitHub Actions Failure

Comment fix

41e1d35

BradleyOlson64 added the T8-polkadot This PR/Issue is related to/affects the Polkadot network. label Oct 23, 2023

BradleyOlson64 had a problem deploying to master October 23, 2023 21:17 — with GitHub Actions Failure

Merge branch 'rk-core-time-prep' of https://github.com/paritytech/pol…

c1d2add

…kadot-sdk into brad-core-time-tests

BradleyOlson64 had a problem deploying to master October 24, 2023 18:32 — with GitHub Actions Failure

Cleanup + better logic.

46ef8cd

eskimor had a problem deploying to master October 25, 2023 09:30 — with GitHub Actions Failure

eskimor approved these changes Oct 25, 2023

View reviewed changes

eskimor had a problem deploying to master October 25, 2023 09:39 — with GitHub Actions Failure

eskimor reviewed Oct 25, 2023

View reviewed changes

eskimor had a problem deploying to master October 25, 2023 09:40 — with GitHub Actions Failure

Shored up assigner_parachains encapsulation

3f0b797

BradleyOlson64 had a problem deploying to master October 25, 2023 20:38 — with GitHub Actions Failure

BradleyOlson64 merged commit fc358fd into rk-core-time-prep Oct 26, 2023
17 of 98 checks passed

BradleyOlson64 deleted the brad-core-time-tests branch October 26, 2023 20:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Resolving Compile Errors in Core Time Prep Tests #1793

Resolving Compile Errors in Core Time Prep Tests #1793

BradleyOlson64 commented Oct 4, 2023

eskimor left a comment

eskimor Oct 4, 2023

BradleyOlson64 commented Oct 18, 2023

eskimor left a comment

eskimor Oct 25, 2023

eskimor Oct 25, 2023

eskimor Oct 25, 2023

paritytech-cicd-pr commented Oct 25, 2023

paritytech-cicd-pr commented Oct 25, 2023


		T::AssignmentProvider::report_processed(dropped.assignment);
		for _ in 0..num_dropped {

Resolving Compile Errors in Core Time Prep Tests #1793

Resolving Compile Errors in Core Time Prep Tests #1793

Conversation

BradleyOlson64 commented Oct 4, 2023

eskimor left a comment

Choose a reason for hiding this comment

eskimor Oct 4, 2023

Choose a reason for hiding this comment

BradleyOlson64 commented Oct 18, 2023

eskimor left a comment

Choose a reason for hiding this comment

eskimor Oct 25, 2023

Choose a reason for hiding this comment

eskimor Oct 25, 2023

Choose a reason for hiding this comment

eskimor Oct 25, 2023

Choose a reason for hiding this comment

paritytech-cicd-pr commented Oct 25, 2023

paritytech-cicd-pr commented Oct 25, 2023