Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: gofmt code for adapting go 1.19 #36832

Merged
merged 19 commits into from
Aug 11, 2022
Merged

*: gofmt code for adapting go 1.19 #36832

merged 19 commits into from
Aug 11, 2022

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Aug 3, 2022 •
edited
Loading

Signed-off-by: Weizhen Wang wangweizhen@pingcap.com

What problem does this PR solve?

Issue Number: ref #36879

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    Run gofmt in the go1.19

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@hawkingrei hawkingrei requested a review from a team as a code owner August 3, 2022 01:46
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 3, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 3, 2022
@hawkingrei
Copy link
Member Author

/run-unit-test

@hawkingrei
Copy link
Member Author

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2022
@hawkingrei
Copy link
Member Author

/run-build

@sre-bot
Copy link
Contributor

sre-bot commented Aug 3, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/588bfdf75e2fbfa90138a9d3d5023a5a7d6e9152

@hawkingrei
Copy link
Member Author

/run-check_dev

@hawkingrei
Copy link
Member Author

/run-unit-test

@hawkingrei hawkingrei added the skip-issue-check Indicates that a PR no need to check linked issue. label Aug 3, 2022
@hawkingrei
Copy link
Member Author

/run-all-tests

bb7133
bb7133 reviewed Aug 3, 2022
View reviewed changes
br/pkg/task/stream.go Outdated Show resolved Hide resolved
bb7133
bb7133 reviewed Aug 3, 2022
View reviewed changes
meta/autoid/autoid.go Outdated Show resolved Hide resolved
planner/core/rule_partition_processor.go Outdated Show resolved Hide resolved
planner/core/rule_predicate_push_down.go Outdated Show resolved Hide resolved
planner/funcdep/fd_graph.go Outdated Show resolved Hide resolved
table/tables/mutation_checker.go Outdated Show resolved Hide resolved
@hawkingrei hawkingrei removed the skip-issue-check Indicates that a PR no need to check linked issue. label Aug 4, 2022
@hawkingrei
Copy link
Member Author

/run-mysql-test

1 similar comment
@hawkingrei
Copy link
Member Author

/run-mysql-test

@hawkingrei
*: set go 1.19
3140fa4 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*: set go 1.19
ec7a006 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*: set go 1.19
dca5261 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*: set go 1.19
e30c312 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
6d0f647
@hawkingrei
update
e800a4b
@hawkingrei
*: upgrade golangci-linter
7ceebad 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*: upgrade go1.19
e168ac7 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
build tidb upgrade go119
4bf5687 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
recovery
33b5aae 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
fix
705a9c9 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
fix
4ef3b87 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
fix
219b5c4 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
fix
c8e04e8 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
fix
c575f16 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 11, 2022
@hawkingrei
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c575f16

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 11, 2022
@hawkingrei
Copy link
Member Author

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 11, 2022
@hawkingrei
Copy link
Member Author

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 11, 2022
@ti-chi-bot ti-chi-bot merged commit d6d0ce7 into pingcap:master Aug 11, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Aug 11, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 1, success 16, total 17 17 min Existing failure
idc-jenkins-ci-tidb/common-test 🔴 failed 1, success 10, total 11 13 min Existing failure
idc-jenkins-ci-tidb/integration-ddl-test ✅ all 6 tests passed 7 min 5 sec Fixed
idc-jenkins-ci/integration-cdc-test 🟢 all 36 tests passed 30 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 9 min 32 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 6 min 22 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 5 min 13 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 4 min 34 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@hawkingrei hawkingrei deleted the go119 branch August 11, 2022 05:37
morgo added a commit to morgo/tidb that referenced this pull request Aug 11, 2022
@morgo
Merge remote-tracking branch 'upstream/master' into improve-sysvar-co…
d71b97f 
…verage

* upstream/master: (98 commits)
  planner: provide a unified interface to set and get user variables and types (pingcap#37046)
  *: fix check-2 to bazel (pingcap#37055)
  distsql: revert 37019 (pingcap#37048)
  planner: introduce new functions for the general statement in session interface (pingcap#37024)
  session: make BenchmarkCompileExecutePreparedStmt update to date (pingcap#36960)
  server: Change proxyprotocol to lazy mode (pingcap#36301)
  test: fix `TestDDLSchedulingMultiTimes` and `TestConcurrentDDLSwitch` timeout (pingcap#37043)
  makefile: add bazel realtikvtest (pingcap#37042)
  distsql: make analyze request SI (pingcap#37019)
  *: gofmt code for adapting go 1.19 (pingcap#36832)
  planner: fix data race in the TestInlineProjection4HashJoinIssue15316 (pingcap#37014)
  planner: introduce Session.CacheGeneralStmt for general plan cache (pingcap#37028)
  server: revise scheme code (pingcap#37021)
  planner: fix unstable test TestPushDownSelectionForMPP (pingcap#37038)
  executor: more precise memory tracking (pingcap#35785)
  executor: add privilege check for prepare stmt (pingcap#36933)
  *: optimize temptable.SessionSnapshotInterceptor (pingcap#36999)
  statistics: batch insert topn and buckets to storage to speed up loading stats (pingcap#36948)
  planner: remove keyword `prepared` in plan cache backend (pingcap#37023)
  util: fix unstable test TestCheckCN (pingcap#37016)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox left review comments

@tangenta tangenta tangenta left review comments

@bb7133 bb7133 bb7133 approved these changes

@tiancaiamao tiancaiamao tiancaiamao approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hawkingrei @ti-chi-bot @sre-bot @bb7133 @tiancaiamao @xhebox @tangenta