Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: fix unstable test TestCheckCN #37016

Merged
merged 8 commits into from
Aug 10, 2022
Merged

util: fix unstable test TestCheckCN #37016

merged 8 commits into from
Aug 10, 2022

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Aug 10, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #36866

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@hawkingrei
util: improve TestCheckCN to avoid unstable
f035c28 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
util: improve TestCheckCN to avoid unstable
9ee69b0 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
util: improve TestCheckCN to avoid unstable
e6eb554 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
util: improve TestCheckCN to avoid unstable
41498bf 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 10, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Defined2014
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 10, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Aug 10, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/d5d67e86fca940b058deaa666880db9d4dc24c72

@hawkingrei
Copy link
Member Author

/run-unit-test

@hawkingrei
fix
a1f92c8 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
fix
71a3b07 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
Copy link
Member Author

Try 3 times without any flaky.

@hawkingrei
fix
e728f04 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 10, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 10, 2022
@Defined2014
Copy link
Contributor

Defined2014 commented Aug 10, 2022 •
edited
Loading

Don't understand why it can avoid get error like #36866, the error msg looks like the server are closed.

@hawkingrei
Copy link
Member Author

Don't understand why it can avoid get error like #36866, the error msg looks like the server are closed.

I also don't understand it so I just improve the code style and reference the issue to avoid closing it. it needs to test more times.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 10, 2022
@Defined2014
Copy link
Contributor

/merge

1 similar comment
@hawkingrei
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e728f04

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 10, 2022
@ti-chi-bot ti-chi-bot merged commit c3d14dc into pingcap:master Aug 10, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Aug 10, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [3] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 3, success 14, total 17 12 min Existing failure
idc-jenkins-ci-tidb/common-test 🔴 failed 2, success 9, total 11 10 min Existing failure
idc-jenkins-ci-tidb/sqllogic-test-2 🔴 failed 1, success 27, total 28 5 min 43 sec Existing failure
idc-jenkins-ci-tidb/integration-ddl-test 🔴 failed 1, success 5, total 6 5 min 32 sec Existing failure
idc-jenkins-ci/integration-cdc-test ✅ all 36 tests passed 34 min Fixed
idc-jenkins-ci-tidb/sqllogic-test-1 ✅ all 26 tests passed 4 min 23 sec Fixed
idc-jenkins-ci-tidb/integration-compatibility-test ✅ all 1 tests passed 2 min 31 sec Fixed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 53 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 11 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

morgo added a commit to morgo/tidb that referenced this pull request Aug 11, 2022
@morgo
Merge remote-tracking branch 'upstream/master' into improve-sysvar-co…
d71b97f 
…verage

* upstream/master: (98 commits)
  planner: provide a unified interface to set and get user variables and types (pingcap#37046)
  *: fix check-2 to bazel (pingcap#37055)
  distsql: revert 37019 (pingcap#37048)
  planner: introduce new functions for the general statement in session interface (pingcap#37024)
  session: make BenchmarkCompileExecutePreparedStmt update to date (pingcap#36960)
  server: Change proxyprotocol to lazy mode (pingcap#36301)
  test: fix `TestDDLSchedulingMultiTimes` and `TestConcurrentDDLSwitch` timeout (pingcap#37043)
  makefile: add bazel realtikvtest (pingcap#37042)
  distsql: make analyze request SI (pingcap#37019)
  *: gofmt code for adapting go 1.19 (pingcap#36832)
  planner: fix data race in the TestInlineProjection4HashJoinIssue15316 (pingcap#37014)
  planner: introduce Session.CacheGeneralStmt for general plan cache (pingcap#37028)
  server: revise scheme code (pingcap#37021)
  planner: fix unstable test TestPushDownSelectionForMPP (pingcap#37038)
  executor: more precise memory tracking (pingcap#35785)
  executor: add privilege check for prepare stmt (pingcap#36933)
  *: optimize temptable.SessionSnapshotInterceptor (pingcap#36999)
  statistics: batch insert topn and buckets to storage to speed up loading stats (pingcap#36948)
  planner: remove keyword `prepared` in plan cache backend (pingcap#37023)
  util: fix unstable test TestCheckCN (pingcap#37016)
  ...
@hawkingrei hawkingrei deleted the fix_improve_test branch August 19, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Defined2014 Defined2014 Defined2014 approved these changes

@xhebox xhebox xhebox approved these changes

@tangenta tangenta Awaiting requested review from tangenta

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hawkingrei @ti-chi-bot @sre-bot @Defined2014 @xhebox