planner: provide a unified interface to set and get user variables and types #37046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
do-not-merge/work-in-progress
|
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/b4e10c8849fa2dcbf7a33f2c7561c4fa68076291 |
ti-chi-bot
removed
the
do-not-merge/work-in-progress
|
/cc @qw4990 @Reminiscent |
qw4990
reviewed
Aug 11, 2022
qw4990
reviewed
Aug 11, 2022
sessionctx/variable/session.go
Outdated
Comment on lines
600
to
602
| userVarLock sync.RWMutex | ||
| userVarValues map[string]types.Datum | ||
| userVarTypes map[string]*types.FieldType |
There was a problem hiding this comment.
How about wrapping them as a unified structure:
strauct userVars {
sync.RWMutex
vars map[string]Datum
types map[string]FT
}
qw4990
reviewed
Aug 11, 2022
| @@ -2047,16 +2083,14 @@ func (s *SessionVars) GetTemporaryTable(tblInfo *model.TableInfo) tableutil.Temp | |||
| // EncodeSessionStates saves session states into SessionStates. | |||
| func (s *SessionVars) EncodeSessionStates(ctx context.Context, sessionStates *sessionstates.SessionStates) (err error) { | |||
| // Encode user-defined variables. | |||
| s.UsersLock.RLock() | |||
There was a problem hiding this comment.
Should lock it here since the following operation is accessing the user-var map directly instead of using Getter/Setter.
qw4990
reviewed
Aug 11, 2022
sessionctx/variable/session.go
Outdated
| @@ -1655,18 +1685,20 @@ func (s *SessionVars) GetParseParams() []parser.ParseParam { | |||
| func (s *SessionVars) SetUserVar(varName string, svalue string, collation string) { | |||
There was a problem hiding this comment.
How about renaming this function to SetStringUserVar(name, strVal, collation string)?
Reminiscent
reviewed
Aug 11, 2022
Reminiscent
approved these changes
Aug 11, 2022
|
/run-check_dev_2 |
qw4990
approved these changes
Aug 11, 2022
ti-chi-bot
added
status/LGT2
|
/run-check_dev_2 |
|
/run-check_dev_2 |
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: f5c57b6
|
ti-chi-bot
added
the
status/can-merge
|
/merge |
1 similar comment
|
/merge |
TiDB MergeCI notify🔴 Bad News! [2] CI still failing after this pr merged.
|
morgo
added a commit
to morgo/tidb
that referenced
this pull request
Aug 11, 2022
…verage * upstream/master: (98 commits) planner: provide a unified interface to set and get user variables and types (pingcap#37046) *: fix check-2 to bazel (pingcap#37055) distsql: revert 37019 (pingcap#37048) planner: introduce new functions for the general statement in session interface (pingcap#37024) session: make BenchmarkCompileExecutePreparedStmt update to date (pingcap#36960) server: Change proxyprotocol to lazy mode (pingcap#36301) test: fix `TestDDLSchedulingMultiTimes` and `TestConcurrentDDLSwitch` timeout (pingcap#37043) makefile: add bazel realtikvtest (pingcap#37042) distsql: make analyze request SI (pingcap#37019) *: gofmt code for adapting go 1.19 (pingcap#36832) planner: fix data race in the TestInlineProjection4HashJoinIssue15316 (pingcap#37014) planner: introduce Session.CacheGeneralStmt for general plan cache (pingcap#37028) server: revise scheme code (pingcap#37021) planner: fix unstable test TestPushDownSelectionForMPP (pingcap#37038) executor: more precise memory tracking (pingcap#35785) executor: add privilege check for prepare stmt (pingcap#36933) *: optimize temptable.SessionSnapshotInterceptor (pingcap#36999) statistics: batch insert topn and buckets to storage to speed up loading stats (pingcap#36948) planner: remove keyword `prepared` in plan cache backend (pingcap#37023) util: fix unstable test TestCheckCN (pingcap#37016) ...
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
For user defined variables，we don't have a unidfined interface to set and get. For code clarity and readability, we design some interface to manage these variables.
Issue Number: ref #36598
What is changed and how it works?
Provide some interface and modify the original use way
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.