Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: optimize temptable.SessionSnapshotInterceptor #36999

Merged
merged 2 commits into from
Aug 10, 2022
Merged

*: optimize temptable.SessionSnapshotInterceptor #36999

merged 2 commits into from
Aug 10, 2022

Conversation

lcwangchao
Copy link
Collaborator

@lcwangchao lcwangchao commented Aug 9, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #37000

Problem Summary:
kYePjVdg8o

SessionSnapshotInterceptor will call session.InfoSchema which will introduce some performance cost. We do not need to call session.InfoSchema because it infoschema is present in provider.

What is changed and how it works?

Use provider's infoschema instead of session.InfoSchema

Check List

Tests

  • Unit test

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 9, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Aug 9, 2022
@lcwangchao lcwangchao mentioned this pull request Aug 9, 2022
Closed
@sre-bot
Copy link
Contributor

sre-bot commented Aug 9, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/2d8e0790f9dfd418fafeadcc1f9297f444a189ef

@hawkingrei
Copy link
Member

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 10, 2022
@ti-chi-bot
Copy link
Member

@SpadeA-Tang: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

bb7133
bb7133 approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 10, 2022
@bb7133
Copy link
Member

bb7133 commented Aug 10, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 374ec7e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 10, 2022
@ti-chi-bot ti-chi-bot merged commit b150be8 into pingcap:master Aug 10, 2022
@lcwangchao lcwangchao deleted the optimize_SessionSnapshotInterceptor branch August 10, 2022 12:03
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 10, 2022
@lcwangchao @ti-srebot
cherry pick pingcap#36999 to release-6.2
b854363 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 10, 2022
Merged
1 task
@ti-srebot
Copy link
Contributor

cherry pick to release-6.2 in PR #37031

@sre-bot
Copy link
Contributor

sre-bot commented Aug 10, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/mybatis-test 🟥 failed 1, success 0, total 1 2 min 52 sec New failing
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 3, success 14, total 17 10 min Existing failure
idc-jenkins-ci-tidb/common-test 🔴 failed 2, success 9, total 11 8 min 54 sec Existing failure
idc-jenkins-ci-tidb/integration-ddl-test 🔴 failed 3, success 3, total 6 5 min 13 sec Existing failure
idc-jenkins-ci-tidb/sqllogic-test-2 🔴 failed 2, success 26, total 28 4 min 43 sec Existing failure
idc-jenkins-ci-tidb/sqllogic-test-1 🔴 failed 6, success 20, total 26 4 min 33 sec Existing failure
idc-jenkins-ci/integration-cdc-test ✅ all 36 tests passed 33 min Fixed
idc-jenkins-ci-tidb/integration-compatibility-test ✅ all 1 tests passed 3 min 25 sec Fixed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 8 min 54 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

ti-chi-bot pushed a commit that referenced this pull request Aug 10, 2022
@ti-srebot
*: optimize temptable.SessionSnapshotInterceptor (#36999) (#37031)
93ffafc 
close #37000
morgo added a commit to morgo/tidb that referenced this pull request Aug 11, 2022
@morgo
Merge remote-tracking branch 'upstream/master' into improve-sysvar-co…
d71b97f 
…verage

* upstream/master: (98 commits)
  planner: provide a unified interface to set and get user variables and types (pingcap#37046)
  *: fix check-2 to bazel (pingcap#37055)
  distsql: revert 37019 (pingcap#37048)
  planner: introduce new functions for the general statement in session interface (pingcap#37024)
  session: make BenchmarkCompileExecutePreparedStmt update to date (pingcap#36960)
  server: Change proxyprotocol to lazy mode (pingcap#36301)
  test: fix `TestDDLSchedulingMultiTimes` and `TestConcurrentDDLSwitch` timeout (pingcap#37043)
  makefile: add bazel realtikvtest (pingcap#37042)
  distsql: make analyze request SI (pingcap#37019)
  *: gofmt code for adapting go 1.19 (pingcap#36832)
  planner: fix data race in the TestInlineProjection4HashJoinIssue15316 (pingcap#37014)
  planner: introduce Session.CacheGeneralStmt for general plan cache (pingcap#37028)
  server: revise scheme code (pingcap#37021)
  planner: fix unstable test TestPushDownSelectionForMPP (pingcap#37038)
  executor: more precise memory tracking (pingcap#35785)
  executor: add privilege check for prepare stmt (pingcap#36933)
  *: optimize temptable.SessionSnapshotInterceptor (pingcap#36999)
  statistics: batch insert topn and buckets to storage to speed up loading stats (pingcap#36948)
  planner: remove keyword `prepared` in plan cache backend (pingcap#37023)
  util: fix unstable test TestCheckCN (pingcap#37016)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpadeA-Tang SpadeA-Tang SpadeA-Tang approved these changes

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@bb7133 bb7133 bb7133 approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

optimize temptable.SessionSnapshotInterceptor to reduce cpu cost
8 participants
@lcwangchao @ti-chi-bot @sre-bot @hawkingrei @bb7133 @ti-srebot @tiancaiamao @SpadeA-Tang