Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdc met nil pointer panic in owner scheduler #2980

Closed
amyangfei opened this issue Oct 8, 2021 · 0 comments · Fixed by #4007
Closed

cdc met nil pointer panic in owner scheduler #2980

amyangfei opened this issue Oct 8, 2021 · 0 comments · Fixed by #4007
Assignees
@maxshuang @CharlesCheung96
Labels
affects-4.0 affects-5.0 affects-5.1 affects-5.2 affects-5.3 area/ticdc Issues or PRs related to TiCDC. severity/major type/bug The issue is confirmed as a bug.

Comments

@amyangfei
Copy link
Contributor

amyangfei commented Oct 8, 2021 •
edited
Loading

What did you do?

Run cdc with some truncate table DDLs

What did you expect to see?

No response

What did you see instead?

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x2587b97]

goroutine 377 [running]:
github.com/pingcap/ticdc/cdc/owner.(*scheduler).cleanUpFinishedOperations.func1(0x0, 0x400, 0xc0118fa000, 0xc0109b1480, 0xc03b224000)
        github.com/pingcap/ticdc/cdc/owner/scheduler.go:304 +0x37
github.com/pingcap/ticdc/cdc/model.(*ChangefeedReactorState).PatchTaskStatus.func1(0x0, 0x0, 0x413ec2, 0xc01194d000, 0xf4f630f9, 0xe63b43a8a5dda94e, 0x3e)
        github.com/pingcap/ticdc/cdc/model/reactor_state.go:343 +0xa2
github.com/pingcap/ticdc/cdc/model.(*ChangefeedReactorState).patchAny.func1(0x0, 0x0, 0x0, 0x5f, 0x4c68200, 0x400, 0x1, 0x0, 0x0)
        github.com/pingcap/ticdc/cdc/model/reactor_state.go:389 +0x13a
github.com/pingcap/ticdc/pkg/orchestrator.(*SingleDataPatch).Patch(0xc00cf1e000, 0xc03b0c8390, 0xc03b0c83c0, 0x0, 0x0)
        github.com/pingcap/ticdc/pkg/orchestrator/interfaces.go:55 +0x82
github.com/pingcap/ticdc/pkg/orchestrator.(*EtcdWorker).applyPatches(0xc0001eec40, 0x7ff7f404bab8, 0xc0006220e0, 0xc04e0d8900, 0x9, 0x10, 0x0, 0x0)
        github.com/pingcap/ticdc/pkg/orchestrator/etcd_worker.go:248 +0xcc
github.com/pingcap/ticdc/pkg/orchestrator.(*EtcdWorker).applyPatchGroups(0xc0001eec40, 0x7ff7f404bab8, 0xc0006220e0, 0xc0317f7a00, 0x15, 0x15, 0x0, 0x1, 0x21, 0x31b5a60, ...)
        github.com/pingcap/ticdc/pkg/orchestrator/etcd_worker.go:235 +0xb4
github.com/pingcap/ticdc/pkg/orchestrator.(*EtcdWorker).Run(0xc0001eec40, 0x7ff7f404bab8, 0xc0006220e0, 0xc000718240, 0xbebc200, 0x0, 0x0)
        github.com/pingcap/ticdc/pkg/orchestrator/etcd_worker.go:146 +0x885
github.com/pingcap/ticdc/cdc/capture.(*Capture).runEtcdWorker(0xc0006d8400, 0x3222d78, 0xc0006220e0, 0x31b5e20, 0xc0006c1bc0, 0x31de9d0, 0xc000ca9e30, 0xbebc200, 0x0, 0x0)
        github.com/pingcap/ticdc/cdc/capture/capture.go:261 +0x135
github.com/pingcap/ticdc/cdc/capture.(*Capture).campaignOwner(0xc0006d8400, 0x3222d78, 0xc0006220e0, 0x40dc00, 0x31b73a0)
        github.com/pingcap/ticdc/cdc/capture/capture.go:240 +0x6b5
github.com/pingcap/ticdc/cdc/capture.(*Capture).run.func2(0xc000cb2060, 0xc0006d8400, 0x3222d78, 0xc0006220e0, 0xc000d60040)
        github.com/pingcap/ticdc/cdc/capture/capture.go:169 +0xb5
created by github.com/pingcap/ticdc/cdc/capture.(*Capture).run
        github.com/pingcap/ticdc/cdc/capture/capture.go:163 +0x29e

Versions of the cluster

Upstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):

v5.1.1

TiCDC version (execute cdc version):

v5.1.1
@amyangfei amyangfei added the type/bug The issue is confirmed as a bug. label Oct 8, 2021
@AkiraXie AkiraXie added the area/ticdc Issues or PRs related to TiCDC. label Dec 6, 2021
@overvenus overvenus assigned maxshuang and unassigned liuzix Dec 7, 2021
@maxshuang maxshuang mentioned this issue Dec 13, 2021
Open
25 tasks
@CharlesCheung96 CharlesCheung96 self-assigned this Dec 15, 2021
CharlesCheung96 pushed a commit to CharlesCheung96/tiflow that referenced this issue Dec 21, 2021
@asddongmen
owner,scheduler(cdc): fix nil pointer panic in owner scheduler (pingc…
951b343 
…ap#2980)
@CharlesCheung96 CharlesCheung96 mentioned this issue Dec 21, 2021
Closed
CharlesCheung96 added a commit to CharlesCheung96/tiflow that referenced this issue Dec 21, 2021
@CharlesCheung96
owner,scheduler(cdc): fix nil pointer panic in owner scheduler (pingc…
36698c4 
…ap#2980)
@CharlesCheung96 CharlesCheung96 mentioned this issue Dec 21, 2021
Merged
CharlesCheung96 added a commit to CharlesCheung96/tiflow that referenced this issue Dec 22, 2021
@CharlesCheung96
owner,scheduler(cdc): fix nil pointer panic in owner scheduler (pingc…
ad66686 
…ap#2980)
ti-chi-bot pushed a commit that referenced this issue Dec 22, 2021
@CharlesCheung96
owner,scheduler(cdc): fix nil pointer panic in owner scheduler (#2980) (
5e91bac 
#4007)
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this issue Dec 22, 2021
@CharlesCheung96 @ti-chi-bot
owner,scheduler(cdc): fix nil pointer panic in owner scheduler (pingc…
850d37a 
…ap#2980)
@ti-chi-bot ti-chi-bot mentioned this issue Dec 22, 2021
Merged
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this issue Dec 22, 2021
@CharlesCheung96 @ti-chi-bot
owner,scheduler(cdc): fix nil pointer panic in owner scheduler (pingc…
286bd6b 
…ap#2980)
@ti-chi-bot ti-chi-bot mentioned this issue Dec 22, 2021
Merged
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this issue Dec 22, 2021
@CharlesCheung96 @ti-chi-bot
owner,scheduler(cdc): fix nil pointer panic in owner scheduler (pingc…
26f3b5b 
…ap#2980)
@ti-chi-bot ti-chi-bot mentioned this issue Dec 22, 2021
Merged
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this issue Dec 22, 2021
@CharlesCheung96 @ti-chi-bot
owner,scheduler(cdc): fix nil pointer panic in owner scheduler (pingc…
7037756 
…ap#2980)
@ti-chi-bot ti-chi-bot mentioned this issue Dec 22, 2021
Merged
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this issue Dec 22, 2021
@CharlesCheung96 @ti-chi-bot
owner,scheduler(cdc): fix nil pointer panic in owner scheduler (pingc…
272045b 
…ap#2980)
@ti-chi-bot ti-chi-bot mentioned this issue Dec 22, 2021
Merged
ti-chi-bot added a commit that referenced this issue Dec 24, 2021
@ti-chi-bot
owner,scheduler(cdc): fix nil pointer panic in owner scheduler (#2980) (
a6f2e84 
#4007) (#4012)
ti-chi-bot added a commit that referenced this issue Dec 24, 2021
@ti-chi-bot
owner,scheduler(cdc): fix nil pointer panic in owner scheduler (#2980) (
b075164 
#4007) (#4014)
ti-chi-bot added a commit that referenced this issue Dec 24, 2021
@ti-chi-bot
owner,scheduler(cdc): fix nil pointer panic in owner scheduler (#2980) (
000ba45 
#4007) (#4015)
ti-chi-bot added a commit that referenced this issue Dec 24, 2021
@ti-chi-bot
owner,scheduler(cdc): fix nil pointer panic in owner scheduler (#2980) (
07a7e0e 
#4007) (#4016)
ti-chi-bot added a commit that referenced this issue Dec 24, 2021
@ti-chi-bot
owner,scheduler(cdc): fix nil pointer panic in owner scheduler (#2980) (
71080d5 
#4007) (#4013)
3AceShowHand pushed a commit to ti-chi-bot/tiflow that referenced this issue Dec 25, 2021
@ti-chi-bot @3AceShowHand
owner,scheduler(cdc): fix nil pointer panic in owner scheduler (pingc…
af3c44f 
…ap#2980) (pingcap#4007) (pingcap#4014)
zhaoxinyu pushed a commit to zhaoxinyu/ticdc that referenced this issue Dec 29, 2021
@CharlesCheung96 @zhaoxinyu
owner,scheduler(cdc): fix nil pointer panic in owner scheduler (pingc…
a3a6b23 
…ap#2980) (pingcap#4007)
3AceShowHand pushed a commit to ti-chi-bot/tiflow that referenced this issue Jan 13, 2022
@ti-chi-bot @3AceShowHand
owner,scheduler(cdc): fix nil pointer panic in owner scheduler (pingc…
149f3f4 
…ap#2980) (pingcap#4007) (pingcap#4015)
3AceShowHand pushed a commit to ti-chi-bot/tiflow that referenced this issue Jan 13, 2022
@ti-chi-bot @3AceShowHand
owner,scheduler(cdc): fix nil pointer panic in owner scheduler (pingc…
2290a12 
…ap#2980) (pingcap#4007) (pingcap#4016)
overvenus pushed a commit that referenced this issue Jan 18, 2022
@ti-chi-bot @zhaoxinyu
@amyangfei @asddongmen @3AceShowHand
metrics(cdc): fix mq sink write row count metrics. (#4192) (#4322)
a5ce862 
* fix the txn_batch_size metric inaccuracy bug when the sink target is MQ

* address comments

* add comments for exported functions

* fix the compiling problem

* workerpool: limit the rate to output deadlock warning (#3775) (#3799)

* metrics: add changefeed checkepoint catch-up ETA (#3300) (#3311)

* pkg,cdc: do not use log package (#3902) (#3939)

* *: rename repo from pingcap/ticdc to pingcap/tiflow (#3957)

* kvclient(ticdc): fix kvclient takes too long time to recover (#3612) (#3662)

* tz (ticdc): fix timezone error (#3887) (#3910)

* http_*: add log for http api and refine the err handle logic (#2997) (#3306)

* ticdc/alert: add no owner alert rule (#3809) (#3831)

* etcd_worker: batch etcd patch (#3277) (#3393)

* ticdc/owner: Fix ddl special comment syntax error (#3845) (#3977)

* Clean old owner and old processor in release 5.2 branch (#4019)

* tests(ticdc): set up the sync diff output directory correctly (#3725) (#3745)

* owner,scheduler(cdc): fix nil pointer panic in owner scheduler (#2980) (#4007) (#4015)

* config(ticdc): Fix old value configuration check for maxwell protocol (#3747) (#3782)

* ticdc/processor: Fix backoff base delay misconfiguration (#3992) (#4027)

* sink(ticdc): cherry pick sink bug fix to release 5.2 (#4083) (#4119)

* metrics(ticdc): add resolved ts and add changefeed to dataflow (#4038) (#4103)

* kv(ticdc): reduce eventfeed rate limited log (#4072) (#4110)

close #4006

* This is an automated cherry-pick of #4192

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* http_api (ticdc): fix http api 'get processor' panic. (#4117) (#4122)

close #3840

* cdc/sink: adjust kafka initialization logic (#3192) (#3568)

* This is an automated cherry-pick of #3192

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* fix conflicts.

* This is an automated cherry-pick of #3682

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* fix import.

* fix failpoint path.

* try to fix initialize.

* remove table_sink.

* remove initialization.

* remove owner.

* fix mq.

Co-authored-by: Ling Jin <7138436+3AceShowHand@users.noreply.github.com>
Co-authored-by: 3AceShowHand <jinl1037@hotmail.com>

* sink (ticdc): fix a deadlock due to checkpointTs fall back in sinkNode (#4084) (#4098)

close #4055

* This is an automated cherry-pick of #4192

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* fix conflicts.

* fix conflicts.

* fix conflicts.

Co-authored-by: zhaoxinyu <zhaoxinyu512@gmail.com>
Co-authored-by: amyangfei <yangfei@pingcap.com>
Co-authored-by: dongmen <20351731+asddongmen@users.noreply.github.com>
Co-authored-by: Ling Jin <7138436+3AceShowHand@users.noreply.github.com>
Co-authored-by: 3AceShowHand <jinl1037@hotmail.com>
ti-chi-bot added a commit to ti-chi-bot/tiflow that referenced this issue Jan 18, 2022
@ti-chi-bot @zhaoxinyu
@amyangfei @lance6716 @sdojjy @3AceShowHand
metrics(cdc): fix mq sink write row count metrics. (pingcap#4192) (pi…
ae04769 
…ngcap#4323)

* fix the txn_batch_size metric inaccuracy bug when the sink target is MQ

* address comments

* add comments for exported functions

* fix the compiling problem

* workerpool: limit the rate to output deadlock warning (pingcap#3775) (pingcap#3795)

* tests(ticdc): set up the sync diff output directory correctly (pingcap#3725) (pingcap#3741)

* relay(dm): use binlog name comparison (pingcap#3710) (pingcap#3712)

* dm/load: fix concurrent call Loader.Status (pingcap#3459) (pingcap#3468)

* cdc/sorter: make unified sorter cgroup aware (pingcap#3436) (pingcap#3439)

* tz (ticdc): fix timezone error (pingcap#3887) (pingcap#3906)

* pkg,cdc: do not use log package (pingcap#3902) (pingcap#3940)

* *: rename repo from pingcap/ticdc to pingcap/tiflow (pingcap#3959)

* http_*: add log for http api and refine the err handle logic (pingcap#2997) (pingcap#3307)

* etcd_worker: batch etcd patch (pingcap#3277) (pingcap#3389)

* http_api (ticdc): check --cert-allowed-cn before add server common name (pingcap#3628) (pingcap#3882)

* kvclient(ticdc): fix kvclient takes too long time to recover (pingcap#3612) (pingcap#3663)

* owner: fix owner tick block http request (pingcap#3490) (pingcap#3530)

* dm/syncer: use downstream PK/UK to generate DML (pingcap#3168) (pingcap#3256)

* dep(dm): update go-mysql (pingcap#3914) (pingcap#3934)

* dm/syncer: multiple rows use downstream schema (pingcap#3308) (pingcap#3953)

* errorutil,sink,syncer: add errorutil to handle ignorable error (pingcap#3264) (pingcap#3995)

* dm/worker: don't exit when failed to read checkpoint in relay (pingcap#3345) (pingcap#4005)

* syncer(dm): use an early location to reset binlog and open safemode (pingcap#3860)

* ticdc/owner: Fix ddl special comment syntax error (pingcap#3845) (pingcap#3978)

* dm/scheduler: fix inconsistent of relay status (pingcap#3474) (pingcap#4009)

* owner,scheduler(cdc): fix nil pointer panic in owner scheduler (pingcap#2980) (pingcap#4007) (pingcap#4016)

* config(ticdc): Fix old value configuration check for maxwell protocol (pingcap#3747) (pingcap#3783)

* sink(ticdc): cherry pick sink bug fix to release 5.3 (pingcap#4083)

* master(dm): clean and treat invalid load task (pingcap#4004) (pingcap#4145)

* loader: fix wrong progress in query-status for loader (pingcap#4093) (pingcap#4143)

close pingcap#3252

* ticdc/processor: Fix backoff base delay misconfiguration (pingcap#3992) (pingcap#4028)

* dm: load table structure from dump files (pingcap#3295) (pingcap#4163)

* compactor: fix duplicate entry in safemode (pingcap#3432) (pingcap#3434) (pingcap#4088)

* kv(ticdc): reduce eventfeed rate limited log (pingcap#4072) (pingcap#4111)

close pingcap#4006

* metrics(ticdc): add resolved ts and add changefeed to dataflow (pingcap#4038) (pingcap#4104)

* This is an automated cherry-pick of pingcap#4192

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* retry(dm): align with tidb latest error message (pingcap#4172) (pingcap#4254)

close pingcap#4159, close pingcap#4246

* owner(ticdc): Add bootstrap and try to fix the meta information in it (pingcap#3838) (pingcap#3865)

* redolog: add a precleanup process when s3 enable (pingcap#3525) (pingcap#3878)

* ddl(dm): make skipped ddl pass `SplitDDL()` (pingcap#4176) (pingcap#4227)

close pingcap#4173

* cdc/sink: remove Initialize method from the sink interface (pingcap#3682) (pingcap#3765)

Co-authored-by: Ling Jin <7138436+3AceShowHand@users.noreply.github.com>

* http_api (ticdc): fix http api 'get processor' panic. (pingcap#4117) (pingcap#4123)

close pingcap#3840

* sink (ticdc): fix a deadlock due to checkpointTs fall back in sinkNode (pingcap#4084) (pingcap#4099)

close pingcap#4055

* cdc/sink: adjust kafka initialization logic (pingcap#3192) (pingcap#4162)

* try fix conflicts.

* This is an automated cherry-pick of pingcap#4192

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* fix conflicts.

* fix conflicts.

Co-authored-by: zhaoxinyu <zhaoxinyu512@gmail.com>
Co-authored-by: amyangfei <yangfei@pingcap.com>
Co-authored-by: lance6716 <lance6716@gmail.com>
Co-authored-by: sdojjy <sdojjy@qq.com>
Co-authored-by: Ling Jin <7138436+3AceShowHand@users.noreply.github.com>
Co-authored-by: 3AceShowHand <jinl1037@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxshuang maxshuang

@CharlesCheung96 CharlesCheung96

Labels
affects-4.0 affects-5.0 affects-5.1 affects-5.2 affects-5.3 area/ticdc Issues or PRs related to TiCDC. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
6 participants
@amyangfei @overvenus @maxshuang @liuzix @AkiraXie @CharlesCheung96