owner,scheduler(cdc): fix nil pointer panic in owner scheduler (#2980) #4007

CharlesCheung96 · 2021-12-21T13:58:14Z

What problem does this PR solve?

close #2980

What is changed and how it works?

Tests

Unit test

Related changes

Need to cherry-pick to the release branch

Release note

Fix nil pointer panic encountered when scheduler cleanup finished operations

ti-chi-bot · 2021-12-21T13:58:15Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

amyangfei
liuzix

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

liuzix · 2021-12-21T14:26:27Z

cdc/owner/scheduler_v1.go

@@ -309,6 +309,11 @@ func (s *oldScheduler) handleJobs(jobs []*schedulerJob) {
 func (s *oldScheduler) cleanUpFinishedOperations() {
 	for captureID := range s.state.TaskStatuses {
 		s.state.PatchTaskStatus(captureID, func(status *model.TaskStatus) (*model.TaskStatus, bool, error) {
+			if status == nil {
+				log.Warn("task status of the capture is not found, may be the key in etcd was deleted.")


Please print the captureID and changefeedID.

codecov-commenter · 2021-12-22T02:36:05Z

Codecov Report

Merging #4007 (ce6cb53) into master (3873d39) will decrease coverage by 2.0601%.
The diff coverage is 65.0224%.

Flag	Coverage Δ
cdc	`58.3104% <65.0224%> (+0.0738%)`	⬆️
dm	`52.2490% <ø> (-3.7855%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #4007        +/-   ##
================================================
- Coverage   57.0741%   55.0139%   -2.0602%     
================================================
  Files           478        484         +6     
  Lines         56551      59763      +3212     
================================================
+ Hits          32276      32878       +602     
- Misses        20978      23555      +2577     
- Partials       3297       3330        +33

…ap#2980)

amyangfei

rest lgtm

cdc/owner/scheduler_v1.go

Co-authored-by: amyangfei <amyangfei@gmail.com>

amyangfei · 2021-12-22T03:33:36Z

/merge

ti-chi-bot · 2021-12-22T03:33:38Z

This pull request has been accepted and is ready to merge.

Commit hash: 99e0686

CharlesCheung96 · 2021-12-22T05:42:19Z

/run-kafka-tests
/run-integration-tests

amyangfei · 2021-12-22T05:44:43Z

/run-all-tests /tidb=pr/30773

amyangfei · 2021-12-22T07:50:34Z

/run-integration-test /tidb=pr/30773
/run-kafka-integration-test /tidb=pr/30773

ti-chi-bot · 2021-12-22T08:36:24Z

In response to a cherrypick label: new pull request created: #4012.

ti-chi-bot · 2021-12-22T08:37:00Z

In response to a cherrypick label: new pull request created: #4013.

ti-chi-bot · 2021-12-22T08:37:37Z

In response to a cherrypick label: new pull request created: #4014.

ti-chi-bot · 2021-12-22T08:38:13Z

In response to a cherrypick label: new pull request created: #4015.

ti-chi-bot · 2021-12-22T08:38:49Z

In response to a cherrypick label: new pull request created: #4016.

#4007) (#4012)

#4007) (#4014)

#4007) (#4015)

#4007) (#4016)

#4007) (#4013)

…ap#2980) (pingcap#4007) (pingcap#4014)

…ap#2980) (pingcap#4007)

…ap#2980) (pingcap#4007) (pingcap#4015)

…ap#2980) (pingcap#4007) (pingcap#4016)

* fix the txn_batch_size metric inaccuracy bug when the sink target is MQ * address comments * add comments for exported functions * fix the compiling problem * workerpool: limit the rate to output deadlock warning (#3775) (#3799) * metrics: add changefeed checkepoint catch-up ETA (#3300) (#3311) * pkg,cdc: do not use log package (#3902) (#3939) * *: rename repo from pingcap/ticdc to pingcap/tiflow (#3957) * kvclient(ticdc): fix kvclient takes too long time to recover (#3612) (#3662) * tz (ticdc): fix timezone error (#3887) (#3910) * http_*: add log for http api and refine the err handle logic (#2997) (#3306) * ticdc/alert: add no owner alert rule (#3809) (#3831) * etcd_worker: batch etcd patch (#3277) (#3393) * ticdc/owner: Fix ddl special comment syntax error (#3845) (#3977) * Clean old owner and old processor in release 5.2 branch (#4019) * tests(ticdc): set up the sync diff output directory correctly (#3725) (#3745) * owner,scheduler(cdc): fix nil pointer panic in owner scheduler (#2980) (#4007) (#4015) * config(ticdc): Fix old value configuration check for maxwell protocol (#3747) (#3782) * ticdc/processor: Fix backoff base delay misconfiguration (#3992) (#4027) * sink(ticdc): cherry pick sink bug fix to release 5.2 (#4083) (#4119) * metrics(ticdc): add resolved ts and add changefeed to dataflow (#4038) (#4103) * kv(ticdc): reduce eventfeed rate limited log (#4072) (#4110) close #4006 * This is an automated cherry-pick of #4192 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> * http_api (ticdc): fix http api 'get processor' panic. (#4117) (#4122) close #3840 * cdc/sink: adjust kafka initialization logic (#3192) (#3568) * This is an automated cherry-pick of #3192 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> * fix conflicts. * This is an automated cherry-pick of #3682 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> * fix import. * fix failpoint path. * try to fix initialize. * remove table_sink. * remove initialization. * remove owner. * fix mq. Co-authored-by: Ling Jin <7138436+3AceShowHand@users.noreply.github.com> Co-authored-by: 3AceShowHand <jinl1037@hotmail.com> * sink (ticdc): fix a deadlock due to checkpointTs fall back in sinkNode (#4084) (#4098) close #4055 * This is an automated cherry-pick of #4192 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> * fix conflicts. * fix conflicts. * fix conflicts. Co-authored-by: zhaoxinyu <zhaoxinyu512@gmail.com> Co-authored-by: amyangfei <yangfei@pingcap.com> Co-authored-by: dongmen <20351731+asddongmen@users.noreply.github.com> Co-authored-by: Ling Jin <7138436+3AceShowHand@users.noreply.github.com> Co-authored-by: 3AceShowHand <jinl1037@hotmail.com>

* fix the txn_batch_size metric inaccuracy bug when the sink target is MQ * address comments * add comments for exported functions * fix the compiling problem * workerpool: limit the rate to output deadlock warning (#3775) (#3795) * tests(ticdc): set up the sync diff output directory correctly (#3725) (#3741) * relay(dm): use binlog name comparison (#3710) (#3712) * dm/load: fix concurrent call Loader.Status (#3459) (#3468) * cdc/sorter: make unified sorter cgroup aware (#3436) (#3439) * tz (ticdc): fix timezone error (#3887) (#3906) * pkg,cdc: do not use log package (#3902) (#3940) * *: rename repo from pingcap/ticdc to pingcap/tiflow (#3959) * http_*: add log for http api and refine the err handle logic (#2997) (#3307) * etcd_worker: batch etcd patch (#3277) (#3389) * http_api (ticdc): check --cert-allowed-cn before add server common name (#3628) (#3882) * kvclient(ticdc): fix kvclient takes too long time to recover (#3612) (#3663) * owner: fix owner tick block http request (#3490) (#3530) * dm/syncer: use downstream PK/UK to generate DML (#3168) (#3256) * dep(dm): update go-mysql (#3914) (#3934) * dm/syncer: multiple rows use downstream schema (#3308) (#3953) * errorutil,sink,syncer: add errorutil to handle ignorable error (#3264) (#3995) * dm/worker: don't exit when failed to read checkpoint in relay (#3345) (#4005) * syncer(dm): use an early location to reset binlog and open safemode (#3860) * ticdc/owner: Fix ddl special comment syntax error (#3845) (#3978) * dm/scheduler: fix inconsistent of relay status (#3474) (#4009) * owner,scheduler(cdc): fix nil pointer panic in owner scheduler (#2980) (#4007) (#4016) * config(ticdc): Fix old value configuration check for maxwell protocol (#3747) (#3783) * sink(ticdc): cherry pick sink bug fix to release 5.3 (#4083) * master(dm): clean and treat invalid load task (#4004) (#4145) * loader: fix wrong progress in query-status for loader (#4093) (#4143) close #3252 * ticdc/processor: Fix backoff base delay misconfiguration (#3992) (#4028) * dm: load table structure from dump files (#3295) (#4163) * compactor: fix duplicate entry in safemode (#3432) (#3434) (#4088) * kv(ticdc): reduce eventfeed rate limited log (#4072) (#4111) close #4006 * metrics(ticdc): add resolved ts and add changefeed to dataflow (#4038) (#4104) * This is an automated cherry-pick of #4192 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> * retry(dm): align with tidb latest error message (#4172) (#4254) close #4159, close #4246 * owner(ticdc): Add bootstrap and try to fix the meta information in it (#3838) (#3865) * redolog: add a precleanup process when s3 enable (#3525) (#3878) * ddl(dm): make skipped ddl pass `SplitDDL()` (#4176) (#4227) close #4173 * cdc/sink: remove Initialize method from the sink interface (#3682) (#3765) Co-authored-by: Ling Jin <7138436+3AceShowHand@users.noreply.github.com> * http_api (ticdc): fix http api 'get processor' panic. (#4117) (#4123) close #3840 * sink (ticdc): fix a deadlock due to checkpointTs fall back in sinkNode (#4084) (#4099) close #4055 * cdc/sink: adjust kafka initialization logic (#3192) (#4162) * try fix conflicts. * This is an automated cherry-pick of #4192 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> * fix conflicts. * fix conflicts. Co-authored-by: zhaoxinyu <zhaoxinyu512@gmail.com> Co-authored-by: amyangfei <yangfei@pingcap.com> Co-authored-by: lance6716 <lance6716@gmail.com> Co-authored-by: sdojjy <sdojjy@qq.com> Co-authored-by: Ling Jin <7138436+3AceShowHand@users.noreply.github.com> Co-authored-by: 3AceShowHand <jinl1037@hotmail.com>

ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 21, 2021

CharlesCheung96 requested a review from amyangfei December 21, 2021 14:12

liuzix reviewed Dec 21, 2021

View reviewed changes

CharlesCheung96 added 2 commits December 22, 2021 10:41

owner,scheduler(cdc): fix nil pointer panic in owner scheduler (pingc…

ad66686

…ap#2980)

add captureID and changefeedID fields to warn log

8024b79

CharlesCheung96 force-pushed the fix_2980_nil_panic branch from ce6cb53 to 8024b79 Compare December 22, 2021 02:42

amyangfei reviewed Dec 22, 2021

View reviewed changes

cdc/owner/scheduler_v1.go Outdated Show resolved Hide resolved

handle comment

99e0686

Co-authored-by: amyangfei <amyangfei@gmail.com>

amyangfei approved these changes Dec 22, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 22, 2021

liuzix approved these changes Dec 22, 2021

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 22, 2021

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 22, 2021

Merge branch 'master' into fix_2980_nil_panic

e310967

ti-chi-bot merged commit 5e91bac into pingcap:master Dec 22, 2021

ti-chi-bot mentioned this pull request Dec 22, 2021

owner,scheduler(cdc): fix nil pointer panic in owner scheduler (#2980) (#4007) #4012

Merged

ti-chi-bot mentioned this pull request Dec 22, 2021

owner,scheduler(cdc): fix nil pointer panic in owner scheduler (#2980) (#4007) #4013

Merged

ti-chi-bot mentioned this pull request Dec 22, 2021

owner,scheduler(cdc): fix nil pointer panic in owner scheduler (#2980) (#4007) #4014

Merged

ti-chi-bot mentioned this pull request Dec 22, 2021

owner,scheduler(cdc): fix nil pointer panic in owner scheduler (#2980) (#4007) #4015

Merged

ti-chi-bot mentioned this pull request Dec 22, 2021

owner,scheduler(cdc): fix nil pointer panic in owner scheduler (#2980) (#4007) #4016

Merged

ti-chi-bot added a commit that referenced this pull request Dec 24, 2021

owner,scheduler(cdc): fix nil pointer panic in owner scheduler (#2980) (

a6f2e84

#4007) (#4012)

ti-chi-bot added a commit that referenced this pull request Dec 24, 2021

owner,scheduler(cdc): fix nil pointer panic in owner scheduler (#2980) (

b075164

#4007) (#4014)

ti-chi-bot added a commit that referenced this pull request Dec 24, 2021

owner,scheduler(cdc): fix nil pointer panic in owner scheduler (#2980) (

000ba45

#4007) (#4015)

ti-chi-bot added a commit that referenced this pull request Dec 24, 2021

owner,scheduler(cdc): fix nil pointer panic in owner scheduler (#2980) (

07a7e0e

#4007) (#4016)

ti-chi-bot added a commit that referenced this pull request Dec 24, 2021

owner,scheduler(cdc): fix nil pointer panic in owner scheduler (#2980) (

71080d5

#4007) (#4013)

3AceShowHand pushed a commit to ti-chi-bot/tiflow that referenced this pull request Dec 25, 2021

owner,scheduler(cdc): fix nil pointer panic in owner scheduler (pingc…

af3c44f

…ap#2980) (pingcap#4007) (pingcap#4014)

zhaoxinyu pushed a commit to zhaoxinyu/ticdc that referenced this pull request Dec 29, 2021

owner,scheduler(cdc): fix nil pointer panic in owner scheduler (pingc…

a3a6b23

…ap#2980) (pingcap#4007)

3AceShowHand pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jan 13, 2022

owner,scheduler(cdc): fix nil pointer panic in owner scheduler (pingc…

149f3f4

…ap#2980) (pingcap#4007) (pingcap#4015)

3AceShowHand pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jan 13, 2022

owner,scheduler(cdc): fix nil pointer panic in owner scheduler (pingc…

2290a12

…ap#2980) (pingcap#4007) (pingcap#4016)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

owner,scheduler(cdc): fix nil pointer panic in owner scheduler (#2980) #4007

owner,scheduler(cdc): fix nil pointer panic in owner scheduler (#2980) #4007

CharlesCheung96 commented Dec 21, 2021

ti-chi-bot commented Dec 21, 2021 •

edited

Loading

liuzix Dec 21, 2021

CharlesCheung96 Dec 22, 2021

codecov-commenter commented Dec 22, 2021 •

edited

Loading

amyangfei left a comment

amyangfei commented Dec 22, 2021

ti-chi-bot commented Dec 22, 2021

CharlesCheung96 commented Dec 22, 2021

amyangfei commented Dec 22, 2021

amyangfei commented Dec 22, 2021

ti-chi-bot commented Dec 22, 2021

ti-chi-bot commented Dec 22, 2021

ti-chi-bot commented Dec 22, 2021

ti-chi-bot commented Dec 22, 2021

ti-chi-bot commented Dec 22, 2021

owner,scheduler(cdc): fix nil pointer panic in owner scheduler (#2980) #4007

owner,scheduler(cdc): fix nil pointer panic in owner scheduler (#2980) #4007

Conversation

CharlesCheung96 commented Dec 21, 2021

What problem does this PR solve?

What is changed and how it works?

Release note

ti-chi-bot commented Dec 21, 2021 • edited Loading

liuzix Dec 21, 2021

Choose a reason for hiding this comment

CharlesCheung96 Dec 22, 2021

Choose a reason for hiding this comment

codecov-commenter commented Dec 22, 2021 • edited Loading

Codecov Report

amyangfei left a comment

Choose a reason for hiding this comment

amyangfei commented Dec 22, 2021

ti-chi-bot commented Dec 22, 2021

CharlesCheung96 commented Dec 22, 2021

amyangfei commented Dec 22, 2021

amyangfei commented Dec 22, 2021

ti-chi-bot commented Dec 22, 2021

ti-chi-bot commented Dec 22, 2021

ti-chi-bot commented Dec 22, 2021

ti-chi-bot commented Dec 22, 2021

ti-chi-bot commented Dec 22, 2021

ti-chi-bot commented Dec 21, 2021 •

edited

Loading

codecov-commenter commented Dec 22, 2021 •

edited

Loading