redolog: add a precleanup process when s3 enable (#3525) #3878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
do-not-merge/cherry-pick-not-approved
release-note
ti-chi-bot
added
area/ticdc
ben1009
approved these changes
Dec 14, 2021
ti-chi-bot
added
the
needs-rebase
ben1009
added
the
needs-cherry-pick-release-5.3
Codecov Report
@@ Coverage Diff @@
## release-5.3 #3878 +/- ##
================================================
Coverage ? 56.8966%
================================================
Files ? 217
Lines ? 23149
Branches ? 0
================================================
Hits ? 13171
Misses ? 8639
Partials ? 1339 |
nongfushanquan
added
cherry-pick-approved
ti-chi-bot
removed
the
needs-rebase
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 37055ba
|
ti-chi-bot
added
the
status/can-merge
|
/run-dm-integration-test /run-kafka-integration-test |
|
/run-dm-integration-test |
|
@ti-chi-bot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
In response to a cherrypick label: base branch (release-5.3) needs to differ from target branch (release-5.3). |
3AceShowHand
pushed a commit
to ti-chi-bot/tiflow
that referenced
this pull request
Jan 13, 2022
ti-chi-bot
added a commit
to ti-chi-bot/tiflow
that referenced
this pull request
Jan 18, 2022
…ngcap#4323) * fix the txn_batch_size metric inaccuracy bug when the sink target is MQ * address comments * add comments for exported functions * fix the compiling problem * workerpool: limit the rate to output deadlock warning (pingcap#3775) (pingcap#3795) * tests(ticdc): set up the sync diff output directory correctly (pingcap#3725) (pingcap#3741) * relay(dm): use binlog name comparison (pingcap#3710) (pingcap#3712) * dm/load: fix concurrent call Loader.Status (pingcap#3459) (pingcap#3468) * cdc/sorter: make unified sorter cgroup aware (pingcap#3436) (pingcap#3439) * tz (ticdc): fix timezone error (pingcap#3887) (pingcap#3906) * pkg,cdc: do not use log package (pingcap#3902) (pingcap#3940) * *: rename repo from pingcap/ticdc to pingcap/tiflow (pingcap#3959) * http_*: add log for http api and refine the err handle logic (pingcap#2997) (pingcap#3307) * etcd_worker: batch etcd patch (pingcap#3277) (pingcap#3389) * http_api (ticdc): check --cert-allowed-cn before add server common name (pingcap#3628) (pingcap#3882) * kvclient(ticdc): fix kvclient takes too long time to recover (pingcap#3612) (pingcap#3663) * owner: fix owner tick block http request (pingcap#3490) (pingcap#3530) * dm/syncer: use downstream PK/UK to generate DML (pingcap#3168) (pingcap#3256) * dep(dm): update go-mysql (pingcap#3914) (pingcap#3934) * dm/syncer: multiple rows use downstream schema (pingcap#3308) (pingcap#3953) * errorutil,sink,syncer: add errorutil to handle ignorable error (pingcap#3264) (pingcap#3995) * dm/worker: don't exit when failed to read checkpoint in relay (pingcap#3345) (pingcap#4005) * syncer(dm): use an early location to reset binlog and open safemode (pingcap#3860) * ticdc/owner: Fix ddl special comment syntax error (pingcap#3845) (pingcap#3978) * dm/scheduler: fix inconsistent of relay status (pingcap#3474) (pingcap#4009) * owner,scheduler(cdc): fix nil pointer panic in owner scheduler (pingcap#2980) (pingcap#4007) (pingcap#4016) * config(ticdc): Fix old value configuration check for maxwell protocol (pingcap#3747) (pingcap#3783) * sink(ticdc): cherry pick sink bug fix to release 5.3 (pingcap#4083) * master(dm): clean and treat invalid load task (pingcap#4004) (pingcap#4145) * loader: fix wrong progress in query-status for loader (pingcap#4093) (pingcap#4143) close pingcap#3252 * ticdc/processor: Fix backoff base delay misconfiguration (pingcap#3992) (pingcap#4028) * dm: load table structure from dump files (pingcap#3295) (pingcap#4163) * compactor: fix duplicate entry in safemode (pingcap#3432) (pingcap#3434) (pingcap#4088) * kv(ticdc): reduce eventfeed rate limited log (pingcap#4072) (pingcap#4111) close pingcap#4006 * metrics(ticdc): add resolved ts and add changefeed to dataflow (pingcap#4038) (pingcap#4104) * This is an automated cherry-pick of pingcap#4192 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> * retry(dm): align with tidb latest error message (pingcap#4172) (pingcap#4254) close pingcap#4159, close pingcap#4246 * owner(ticdc): Add bootstrap and try to fix the meta information in it (pingcap#3838) (pingcap#3865) * redolog: add a precleanup process when s3 enable (pingcap#3525) (pingcap#3878) * ddl(dm): make skipped ddl pass `SplitDDL()` (pingcap#4176) (pingcap#4227) close pingcap#4173 * cdc/sink: remove Initialize method from the sink interface (pingcap#3682) (pingcap#3765) Co-authored-by: Ling Jin <7138436+3AceShowHand@users.noreply.github.com> * http_api (ticdc): fix http api 'get processor' panic. (pingcap#4117) (pingcap#4123) close pingcap#3840 * sink (ticdc): fix a deadlock due to checkpointTs fall back in sinkNode (pingcap#4084) (pingcap#4099) close pingcap#4055 * cdc/sink: adjust kafka initialization logic (pingcap#3192) (pingcap#4162) * try fix conflicts. * This is an automated cherry-pick of pingcap#4192 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> * fix conflicts. * fix conflicts. Co-authored-by: zhaoxinyu <zhaoxinyu512@gmail.com> Co-authored-by: amyangfei <yangfei@pingcap.com> Co-authored-by: lance6716 <lance6716@gmail.com> Co-authored-by: sdojjy <sdojjy@qq.com> Co-authored-by: Ling Jin <7138436+3AceShowHand@users.noreply.github.com> Co-authored-by: 3AceShowHand <jinl1037@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #3525
What problem does this PR solve?
What is changed and how it works?
set a delete marker when delete logs in s3, since the process got the remove changefeed job async, may continue write logs after owner remove the logs. if have the changefeed with the same name created later, pre cleanup the log just in case.
when gc if the dir is not exist, just log instead of return err
Check List
Tests
Code changes
Side effects
Related changes
Release note