kv(ticdc): reduce eventfeed rate limited log #4072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neil Shen <overvenus@gmail.com>
overvenus
added
type/bugfix
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #4072 +/- ##
================================================
- Coverage 57.0741% 55.2459% -1.8283%
================================================
Files 478 489 +11
Lines 56551 60361 +3810
================================================
+ Hits 32276 33347 +1071
- Misses 20978 23651 +2673
- Partials 3297 3363 +66 |
ben1009
reviewed
Dec 27, 2021
| @@ -782,12 +819,8 @@ func (s *eventFeedSession) requestRegionToStore( | |||
| continue | |||
| } | |||
|
|
|||
| // Wait for a while and retry sending the request | |||
| time.Sleep(time.Millisecond * time.Duration(rand.Intn(100))) | |||
There was a problem hiding this comment.
do not need sleep in the new change ?
There was a problem hiding this comment.
Yes, it will be rate-limited in onRegionFail.
amyangfei
reviewed
Dec 27, 2021
amyangfei
reviewed
Dec 27, 2021
Comment on lines
+3622
to
+3623
| require.True(t, errInfo.logRateLimitedHint()) | ||
| require.False(t, errInfo.logRateLimitedHint()) |
There was a problem hiding this comment.
Could it happen L3623 executes 200ms after L3622 executes, and logRateLimitedHint returns true
There was a problem hiding this comment.
Maybe, although I think it's very rare.
There was a problem hiding this comment.
t.Parallel() makes it possible
Signed-off-by: Neil Shen <overvenus@gmail.com>
asddongmen
reviewed
Dec 27, 2021
Signed-off-by: Neil Shen <overvenus@gmail.com>
asddongmen
approved these changes
Dec 28, 2021
Signed-off-by: Neil Shen <overvenus@gmail.com>
amyangfei
approved these changes
Dec 28, 2021
ti-chi-bot
added
status/LGT2
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflow
that referenced
this pull request
Dec 28, 2021
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created: #4110. |
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflow
that referenced
this pull request
Dec 28, 2021
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created: #4111. |
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflow
that referenced
this pull request
Dec 28, 2021
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created: #4112. |
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflow
that referenced
this pull request
Dec 28, 2021
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created: #4113. |
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflow
that referenced
this pull request
Dec 28, 2021
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created: #4114. |
overvenus
added a commit
to ti-chi-bot/tiflow
that referenced
this pull request
Dec 28, 2021
overvenus
added a commit
to ti-chi-bot/tiflow
that referenced
this pull request
Dec 28, 2021
overvenus
added a commit
to ti-chi-bot/tiflow
that referenced
this pull request
Dec 28, 2021
overvenus
added a commit
to ti-chi-bot/tiflow
that referenced
this pull request
Dec 28, 2021
overvenus
added a commit
to ti-chi-bot/tiflow
that referenced
this pull request
Dec 28, 2021
zhaoxinyu
pushed a commit
to zhaoxinyu/ticdc
that referenced
this pull request
Dec 29, 2021
ti-chi-bot
added a commit
that referenced
this pull request
Dec 30, 2021
ti-chi-bot
added a commit
that referenced
this pull request
Dec 30, 2021
ti-chi-bot
added a commit
that referenced
this pull request
Dec 30, 2021
ti-chi-bot
added a commit
that referenced
this pull request
Dec 30, 2021
3AceShowHand
pushed a commit
to ti-chi-bot/tiflow
that referenced
this pull request
Jan 13, 2022
3AceShowHand
pushed a commit
to ti-chi-bot/tiflow
that referenced
this pull request
Jan 13, 2022
overvenus
pushed a commit
that referenced
this pull request
Jan 18, 2022
* fix the txn_batch_size metric inaccuracy bug when the sink target is MQ * address comments * add comments for exported functions * fix the compiling problem * workerpool: limit the rate to output deadlock warning (#3775) (#3799) * metrics: add changefeed checkepoint catch-up ETA (#3300) (#3311) * pkg,cdc: do not use log package (#3902) (#3939) * *: rename repo from pingcap/ticdc to pingcap/tiflow (#3957) * kvclient(ticdc): fix kvclient takes too long time to recover (#3612) (#3662) * tz (ticdc): fix timezone error (#3887) (#3910) * http_*: add log for http api and refine the err handle logic (#2997) (#3306) * ticdc/alert: add no owner alert rule (#3809) (#3831) * etcd_worker: batch etcd patch (#3277) (#3393) * ticdc/owner: Fix ddl special comment syntax error (#3845) (#3977) * Clean old owner and old processor in release 5.2 branch (#4019) * tests(ticdc): set up the sync diff output directory correctly (#3725) (#3745) * owner,scheduler(cdc): fix nil pointer panic in owner scheduler (#2980) (#4007) (#4015) * config(ticdc): Fix old value configuration check for maxwell protocol (#3747) (#3782) * ticdc/processor: Fix backoff base delay misconfiguration (#3992) (#4027) * sink(ticdc): cherry pick sink bug fix to release 5.2 (#4083) (#4119) * metrics(ticdc): add resolved ts and add changefeed to dataflow (#4038) (#4103) * kv(ticdc): reduce eventfeed rate limited log (#4072) (#4110) close #4006 * This is an automated cherry-pick of #4192 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> * http_api (ticdc): fix http api 'get processor' panic. (#4117) (#4122) close #3840 * cdc/sink: adjust kafka initialization logic (#3192) (#3568) * This is an automated cherry-pick of #3192 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> * fix conflicts. * This is an automated cherry-pick of #3682 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> * fix import. * fix failpoint path. * try to fix initialize. * remove table_sink. * remove initialization. * remove owner. * fix mq. Co-authored-by: Ling Jin <7138436+3AceShowHand@users.noreply.github.com> Co-authored-by: 3AceShowHand <jinl1037@hotmail.com> * sink (ticdc): fix a deadlock due to checkpointTs fall back in sinkNode (#4084) (#4098) close #4055 * This is an automated cherry-pick of #4192 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> * fix conflicts. * fix conflicts. * fix conflicts. Co-authored-by: zhaoxinyu <zhaoxinyu512@gmail.com> Co-authored-by: amyangfei <yangfei@pingcap.com> Co-authored-by: dongmen <20351731+asddongmen@users.noreply.github.com> Co-authored-by: Ling Jin <7138436+3AceShowHand@users.noreply.github.com> Co-authored-by: 3AceShowHand <jinl1037@hotmail.com>
ti-chi-bot
added a commit
to ti-chi-bot/tiflow
that referenced
this pull request
Jan 18, 2022
…ngcap#4323) * fix the txn_batch_size metric inaccuracy bug when the sink target is MQ * address comments * add comments for exported functions * fix the compiling problem * workerpool: limit the rate to output deadlock warning (pingcap#3775) (pingcap#3795) * tests(ticdc): set up the sync diff output directory correctly (pingcap#3725) (pingcap#3741) * relay(dm): use binlog name comparison (pingcap#3710) (pingcap#3712) * dm/load: fix concurrent call Loader.Status (pingcap#3459) (pingcap#3468) * cdc/sorter: make unified sorter cgroup aware (pingcap#3436) (pingcap#3439) * tz (ticdc): fix timezone error (pingcap#3887) (pingcap#3906) * pkg,cdc: do not use log package (pingcap#3902) (pingcap#3940) * *: rename repo from pingcap/ticdc to pingcap/tiflow (pingcap#3959) * http_*: add log for http api and refine the err handle logic (pingcap#2997) (pingcap#3307) * etcd_worker: batch etcd patch (pingcap#3277) (pingcap#3389) * http_api (ticdc): check --cert-allowed-cn before add server common name (pingcap#3628) (pingcap#3882) * kvclient(ticdc): fix kvclient takes too long time to recover (pingcap#3612) (pingcap#3663) * owner: fix owner tick block http request (pingcap#3490) (pingcap#3530) * dm/syncer: use downstream PK/UK to generate DML (pingcap#3168) (pingcap#3256) * dep(dm): update go-mysql (pingcap#3914) (pingcap#3934) * dm/syncer: multiple rows use downstream schema (pingcap#3308) (pingcap#3953) * errorutil,sink,syncer: add errorutil to handle ignorable error (pingcap#3264) (pingcap#3995) * dm/worker: don't exit when failed to read checkpoint in relay (pingcap#3345) (pingcap#4005) * syncer(dm): use an early location to reset binlog and open safemode (pingcap#3860) * ticdc/owner: Fix ddl special comment syntax error (pingcap#3845) (pingcap#3978) * dm/scheduler: fix inconsistent of relay status (pingcap#3474) (pingcap#4009) * owner,scheduler(cdc): fix nil pointer panic in owner scheduler (pingcap#2980) (pingcap#4007) (pingcap#4016) * config(ticdc): Fix old value configuration check for maxwell protocol (pingcap#3747) (pingcap#3783) * sink(ticdc): cherry pick sink bug fix to release 5.3 (pingcap#4083) * master(dm): clean and treat invalid load task (pingcap#4004) (pingcap#4145) * loader: fix wrong progress in query-status for loader (pingcap#4093) (pingcap#4143) close pingcap#3252 * ticdc/processor: Fix backoff base delay misconfiguration (pingcap#3992) (pingcap#4028) * dm: load table structure from dump files (pingcap#3295) (pingcap#4163) * compactor: fix duplicate entry in safemode (pingcap#3432) (pingcap#3434) (pingcap#4088) * kv(ticdc): reduce eventfeed rate limited log (pingcap#4072) (pingcap#4111) close pingcap#4006 * metrics(ticdc): add resolved ts and add changefeed to dataflow (pingcap#4038) (pingcap#4104) * This is an automated cherry-pick of pingcap#4192 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> * retry(dm): align with tidb latest error message (pingcap#4172) (pingcap#4254) close pingcap#4159, close pingcap#4246 * owner(ticdc): Add bootstrap and try to fix the meta information in it (pingcap#3838) (pingcap#3865) * redolog: add a precleanup process when s3 enable (pingcap#3525) (pingcap#3878) * ddl(dm): make skipped ddl pass `SplitDDL()` (pingcap#4176) (pingcap#4227) close pingcap#4173 * cdc/sink: remove Initialize method from the sink interface (pingcap#3682) (pingcap#3765) Co-authored-by: Ling Jin <7138436+3AceShowHand@users.noreply.github.com> * http_api (ticdc): fix http api 'get processor' panic. (pingcap#4117) (pingcap#4123) close pingcap#3840 * sink (ticdc): fix a deadlock due to checkpointTs fall back in sinkNode (pingcap#4084) (pingcap#4099) close pingcap#4055 * cdc/sink: adjust kafka initialization logic (pingcap#3192) (pingcap#4162) * try fix conflicts. * This is an automated cherry-pick of pingcap#4192 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> * fix conflicts. * fix conflicts. Co-authored-by: zhaoxinyu <zhaoxinyu512@gmail.com> Co-authored-by: amyangfei <yangfei@pingcap.com> Co-authored-by: lance6716 <lance6716@gmail.com> Co-authored-by: sdojjy <sdojjy@qq.com> Co-authored-by: Ling Jin <7138436+3AceShowHand@users.noreply.github.com> Co-authored-by: 3AceShowHand <jinl1037@hotmail.com>
ti-chi-bot
added a commit
that referenced
this pull request
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed and how it works?
Issue Number: close #4006
Check List
Tests
Related changes
Release note