Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable jest to test ts and tsx files #4785

Merged

Conversation

ninanoleto
Copy link
Contributor

@ninanoleto ninanoleto commented May 18, 2023

  • Integrate TypeScript to the Jest testing workflow with ts-jest. It compiles TS/TSX code into JavaScript, performs type checking, supports source maps for better debugging, and transforms TypeScript modules for Jest compatibility.

    • Create a <TsTest /> component to ensure successful implementation
  • Fix re-exports of components that have default export.

@mister-roboto
Copy link

@ninanoleto you need to sign the Plone Contributor Agreement to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

@netlify
Copy link

netlify bot commented May 18, 2023

Deploy Preview for volto canceled.

Name Link
🔨 Latest commit c0a4ec2
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/64691e432b740a0008cae9f6

@ninanoleto ninanoleto changed the title Typescript fix jest chore: enable jest to test ts and tsx files May 18, 2023
@mister-roboto
Copy link

@ninanoleto you need to sign the Plone Contributor Agreement to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

@sneridagh
Copy link
Member

@ninanoleto crap I've pushed and messed the history a bit, I will fix it later. Sorry!

@sneridagh sneridagh force-pushed the typescript-fix-jest branch from 24d43f2 to beb6a7b Compare May 20, 2023 15:51
sneridagh added 4 commits May 20, 2023 17:52
* typescript-support-in-core: (29 commits)
  Remove max_line_length from .editorconfig (plone#4776)
  Fix bug showing logs at the browsers when richtext widget is use (plone#4780)
  Show expired and future content in contents view (plone#4764)
  Fix reducing expanders loaded in a subrequest (plone#4761)
  Update release notes for 16.20.5 and 16.20.6 (plone#4759)
  Release 17.0.0-alpha.7
  Try to sort out volto's use of language codes (plone#4741)
  Improve .npmignore to not include not needed files/folders (plone#4746)
  Release 17.0.0-alpha.6
  Control panel list SSR (plone#3749)
  Open all accordion'd content in InlineForm by default, allow arbitrarily close any number of them (plone#4178)
  Upgrade to Plone 6.0.4 (plone#4743)
  fix: unresponsive add page (plone#4507)
  Apply suggestion from browser for password field (plone#4524)
  (fix):Object.normaliseMail: Cannot read properties of null (plone#4558)
  Fix link in Volto, remove from linkcheck ignore in Documentation v6.0 (plone#4742)
  added documentation regarding the static middleware plone#4518 (plone#4736)
  Closes issue plone#4567 (plone#4570)
  Fix whitespace in locales created by the generator (plone#4737)
  Tidy up from synch with 16.x.x (plone#4728)
  ...
* typescript-support-in-core:
  Fix unannounced breaking change in cypress-io/github-action (plone#4795)
@sneridagh
Copy link
Member

@ninanoleto green! merging, thanks for working on this!

@sneridagh sneridagh merged commit 55e3421 into plone:typescript-support-in-core May 21, 2023
@cypress cypress bot mentioned this pull request May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants