January 2025 Diffcalc/PP release #31595

stanriders · 2025-01-20T15:37:42Z

This PR includes all changes listed in the diffcalc project marked as Ready for deploy. Some changes were already merged to master before pp-dev branch was created

Deployment considerations:

Includes 3 rulesets: osu, taiko and catch. Mania only has a small refactor change that doesn't affect values
All rulesets have difficulty changes, catch doesn't have performance changes
1 new difficulty attribute for osu: AimDifficultSliderCount
5 difficulty attributes have been removed: ApproachRate, OverallDifficulty, GreatHitWindow, OkHitWindow, ScoreMultiplier
New taiko attributes are NOT to be databased

osu! changes: https://pp.huismetbenen.nl/rankings/players/master
Taiko changes: https://pp.huismetbenen.nl/rankings/players/master_taiko
Newspost: ppy/osu-wiki#12699

…o being too inflated (#31067) * low sr * merge two line * update decimal * fix formatting --------- Co-authored-by: StanR <hi@stanr.info>

…utes (#31191) * refactor + countdifficultstrain * norm in utils * adjust scaling shift * fix comment * revert all value changes * add the else back * remove cds comments

…31195) * revert acc scaling shift to previous values * increase variance in accuracy values across od * move return values, move nullcheck into return --------- Co-authored-by: James Wilson <tsunyoku@gmail.com>

Co-authored-by: James Wilson <tsunyoku@gmail.com>

* Simplify osu! high-bpm acute angle jumps bonus * Add aim wiggle bonus * Add hitwindow-based aim velocity decrease * Revert "Add hitwindow-based aim velocity decrease" This reverts commit bcebe96. * Move wiggle multiplier to a const, slightly decrease acute bonus multiplier * Make sure the previous object in the wiggle bonus is also part of the wiggle * Scale the wiggle bonus multiplayer down * Increase the acute angle jump bonus multiplier * Make wiggle bonus only apply on >150 bpm streams, make repetitive angle penalty * Reduce wiggle bonus multiplier to not break velocity>difficulty relation * Adjust wiggle falloff function to fix stability issues * Adjust wiggle consts * Update tests

… fix slider drop penalty being too lenient (#31055) * Change slider drop penalty to use actual number of difficult sliders, fix slider nerf being too lenient * Move cubing to performance calculation * Add separate list for slider strains * Rename difficulty atttribute * Rename attribute in perfcalc * Check if AimDifficultSliderCount is more than 0, code quality fixes * Add `AimDifficultSliderCount` to the list of databased attributes * Code quality --------- Co-authored-by: James Wilson <tsunyoku@gmail.com>

* Use `lastAngle` when nerfing repeated angles on acute bonus * Bump acute multiplier * Correct outdated wiggle bonus comment * Update test --------- Co-authored-by: StanR <hi@stanr.info>

* implement bell curve into diffcalcutils * remove unneeded attributes * implement new rhythm skill * change dho variables * update dho rhythm * interval interface * implement rhythmevaluator * evenhitobjects * evenpatterns * evenrhythm * change attribute ordering * initial balancing * change naming to Same instead of Even * remove attribute bump for display * Fix diffcalc tests --------- Co-authored-by: StanR <hi@stanr.info>

…su! ruleset (#21211) * Set speed distance to 0 * Reduce speed & flashlight, remove aim * Remove speed AR bonus * cleanup autopilot mod check in `SpeedEvaluator` * further decrease speed rating for extra hand availability * Pass all mods to the speed evaluator, zero out distance bonus instead of distance --------- Co-authored-by: tsunyoku <mbruhyo@gmail.com> Co-authored-by: StanR <hi@stanr.info>

…scaling to wide bonus (#31320) * Fix angle bonuses calculating repetition incorrectly, apply distance scaling to wide bonus * Buff speed to compensate for streams losing pp * Adjust speed multiplier * Adjust wide scaling * Fix tests

* fix colour * review fix Co-authored-by: StanR <castl@inbox.ru> * remove cancelled out operand * increase nerf, adjust tests * fix automated spacing issues * up penalty * adjust tests * apply review changes * fix nullable hell --------- Co-authored-by: StanR <castl@inbox.ru>

…1447) Co-authored-by: James Wilson <tsunyoku@gmail.com>

* Simplify angle bonus formula * Simplify further * Simplify acute too * Tests

* Apply a bunch of balancing changes to aim * Update tests --------- Co-authored-by: James Wilson <tsunyoku@gmail.com>

* Make aim accuracy scaling harsher * Use deviation-based scaling * Bring the balancing multiplier down * Adjust multipliers, fix incorrect deviation when using slider accuracy * Adjust multipliers * Update osu.Game.Rulesets.Osu/Difficulty/OsuPerformanceAttributes.cs Co-authored-by: James Wilson <tsunyoku@gmail.com> * Change high speed deviation threshold to 22-27 instead of 20-24 * Update tests --------- Co-authored-by: James Wilson <tsunyoku@gmail.com>

* Remove problematic total deviation scaling, rebalance aim * Fix tests

Co-authored-by: StanR <hi@stanr.info>

* stamina considerations * remove consecutive note count * adjust multiplier * add back comment * adjust tests * adjusts tests post merge * use diffcalcutils --------- Co-authored-by: StanR <hi@stanr.info>

Code quality CI runs have suddenly started failing out of nowhere: - Passing run: https://github.com/ppy/osu/actions/runs/12806242929/job/35704267944#step:10:1 - Failing run: https://github.com/ppy/osu/actions/runs/12807108792/job/35707131634#step:10:1 In classic github fashion, they began rolling out another runner change wherein `ubuntu-latest` has started meaning `ubuntu-24.04` rather than `ubuntu-22.04`. `ubuntu-24.04` no longer has .NET 6 bundled. Therefore, upgrade NVika to 4.0.0 because that version is compatible with .NET 8.

* rebalance * revert pp scaling change * further rebalancing * comment * adjust tests

* further considerations for rhythm * new rhythm balancing * fix license header * use isNormal to validate ratio * adjust tests --------- Co-authored-by: StanR <hi@stanr.info>

…ty.Utils (#31520) * Move error function implementation to osu.Game.Rulesets.Difficulty.Utils * Rename ErrorFunction.cs to DifficultyCalculationUtils_ErrorFunction.cs

…nsity" (#31512) * Penalise reading difficulty of high velocity notes at high densities * Use System for math functions * Lawtrohux changes * Clean up density penalty comment * Swap midVelocity and highVelocity back around * code quality pass --------- Co-authored-by: Jay Lawton <jaime@merkids.com> Co-authored-by: StanR <hi@stanr.info>

* Implement fix for catch buzz sliders SR abuse * Run formatting --------- Co-authored-by: StanR <hi@stanr.info>

BabySnakes101

Taiko looks good, some code and magic could be clearer but hopefully some refactoring can be done in the near future.

…un-settable

…ributes.AimDifficultSliderCount` (#31736)

…difficulty attributes (#31735) * Calculate hit windows in performance calculator instead of databased difficulty attributes * Apply mods to beatmap difficulty in osu! performance calculator * Remove `GreatHitWindow` difficulty attribute for osu!mania * Remove use of approach rate and overall difficulty attributes for osu! * Remove use of hit window difficulty attributes in osu!taiko * Remove use of approach rate attribute in osu!catch * Remove unused attribute IDs * Code quality * Fix `computeDeviationUpperBound` being called before `greatHitWindow` is set

peppy · 2025-02-10T09:06:53Z

I've glossed over a lot of implementation details here, but I think this is about as good to go as it's going to get in my eyes. @smoogipoo do you want to do another pass before we get this going?

Also I think we want to try and synchronise a client release of this better this time around, so I am not going to merge for the upcoming lazer release. We will delay one release cycle (or even do an interim release) so server updates can be prepared and we can have everything go out roughly-together. Sound good?

smoogipoo

Have done a rough pass and everything seems okay.

…ations showing hundreds of pp points awarded (#31741) See https://discord.com/channels/188630481301012481/1097318920991559880/1334716356582572074. On `master` this is actually worse and shows thousands of pp points, so I guess `pp-dev` is a comparable improvement, but still flagrantly wrong. The reason why `pp-dev` is better is the `speedDeviation == null` guard at the start of `computeSpeedValue()` which turns off the rest of the calculation, therefore not exposing the bug where `relevantTotalDiff` can go negative. I still guarded it in this commit just for safety's sake given it is clear it can do very wrong stuff.

Lawtrohux and others added 30 commits December 18, 2024 18:16

Implement considerations for Relax within osu!taiko diffcalc (#30591)

79a3afe

Adjust DifficultyValue curve to avoid lower star rating of osu!taik…

0f2f25d

…o being too inflated (#31067) * low sr * merge two line * update decimal * fix formatting --------- Co-authored-by: StanR <hi@stanr.info>

Refactor TaikoDifficultyCalculator and add DifficultStrain attrib…

4ca88ae

…utes (#31191) * refactor + countdifficultstrain * norm in utils * adjust scaling shift * fix comment * revert all value changes * add the else back * remove cds comments

Increase accscalingshift and include countok in hit proportion (#…

ecd6b41

…31195) * revert acc scaling shift to previous values * increase variance in accuracy values across od * move return values, move nullcheck into return --------- Co-authored-by: James Wilson <tsunyoku@gmail.com>

remove particular condition on convert nerf (#31196)

d8c3d89

Co-authored-by: James Wilson <tsunyoku@gmail.com>

Implement Reading Skill into osu!taiko (#31208)

f6a36f7

Use lastAngle when nerfing repeated angles on acute bonus (#31245)

3ddeaf8

* Use `lastAngle` when nerfing repeated angles on acute bonus * Bump acute multiplier * Correct outdated wiggle bonus comment * Update test --------- Co-authored-by: StanR <hi@stanr.info>

Clamp OD in performance calculation to fix negative OD gaining pp (#3…

3b58d5e

…1447) Co-authored-by: James Wilson <tsunyoku@gmail.com>

Simplify angle bonus formula (#31449)

392bb57

* Simplify angle bonus formula * Simplify further * Simplify acute too * Tests

Apply a bunch of balancing changes to aim (#31456)

db58ec8

* Apply a bunch of balancing changes to aim * Update tests --------- Co-authored-by: James Wilson <tsunyoku@gmail.com>

Punish speed PP for scores with high deviation (#30907)

b21c645

Remove problematic total deviation scaling, rebalance aim (#31515)

6cf15e3

* Remove problematic total deviation scaling, rebalance aim * Fix tests

Remove lower cap on deviation without misses (#31499)

5bed7c2

reading mono nerf (#31510)

0a21183

fix spinners not increasing cumulative strain time (#31525)

974fa76

Co-authored-by: StanR <hi@stanr.info>

osu!taiko stamina balancing (#31337)

9da8dcd

* stamina considerations * remove consecutive note count * adjust multiplier * add back comment * adjust tests * adjusts tests post merge * use diffcalcutils --------- Co-authored-by: StanR <hi@stanr.info>

osu!taiko star rating and performance points rebalance (#31338)

a83f917

* rebalance * revert pp scaling change * further rebalancing * comment * adjust tests

osu!taiko further considerations for rhythm (#31339)

a42c03c

* further considerations for rhythm * new rhythm balancing * fix license header * use isNormal to validate ratio * adjust tests --------- Co-authored-by: StanR <hi@stanr.info>

Move error function from osu.Game.Utils to osu.Game.Rulesets.Difficul…

5b4ba92

…ty.Utils (#31520) * Move error function implementation to osu.Game.Rulesets.Difficulty.Utils * Rename ErrorFunction.cs to DifficultyCalculationUtils_ErrorFunction.cs

Fix osu!catch "buzz slider" SR abuse (#31126)

67723b3

* Implement fix for catch buzz sliders SR abuse * Run formatting --------- Co-authored-by: StanR <hi@stanr.info>

Remove redundant angle check (#31566)

e320f17

BabySnakes101 approved these changes Jan 24, 2025

View reviewed changes

tsunyoku and others added 5 commits January 26, 2025 16:21

Fix incorrect startTime calculation

a7aa553

Account for floating point errors

13c956c

Rename class, rename children to hit objects and groups, make fields …

71b89c3

…un-settable

Use correct English

f3c17f1

Remove unnecessary strain sorting in difficult slider count (#31724)

4614496

tsunyoku and others added 14 commits January 30, 2025 13:58

Clamp estimateImproperlyFollowedDifficultSliders between 0 and `att…

2ee480c

…ributes.AimDifficultSliderCount` (#31736)

Rename Colour / Rhythm related fields and classes

fa844b0

Simplify TaikoRhythmData's ratio computation

709ad02

Remove unused HitObjectInterval

fc93390

Tidy up xmldoc and remove another unused field

3254831

Initial tidy-up pass on IntervalGroupingUtils

8447679

Add better documentation for interval change code

40ea7ff

Merge pull request #31636 from tsunyoku/taiko-cleanup

2593946

Fix inspections

4f6fd68

Merge branch 'master' into pp-dev

6c069b3

Merge branch 'master' into pp-dev

b07d7e8

Add note about weird taiko iteration

d4ce712

Rename buzz variable per review

340e081

Merge branch 'master' into pp-dev

afdcf40

smoogipoo previously approved these changes Feb 11, 2025

View reviewed changes

peppy added the next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! label Feb 12, 2025

tsunyoku dismissed smoogipoo’s stale review via 4e66536 February 14, 2025 14:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

January 2025 Diffcalc/PP release #31595

January 2025 Diffcalc/PP release #31595

stanriders commented Jan 20, 2025 •

edited

Loading

BabySnakes101 left a comment

peppy commented Feb 10, 2025 •

edited

Loading

smoogipoo left a comment

January 2025 Diffcalc/PP release #31595

Are you sure you want to change the base?

January 2025 Diffcalc/PP release #31595

Conversation

stanriders commented Jan 20, 2025 • edited Loading

BabySnakes101 left a comment

Choose a reason for hiding this comment

peppy commented Feb 10, 2025 • edited Loading

smoogipoo left a comment

Choose a reason for hiding this comment

stanriders commented Jan 20, 2025 •

edited

Loading

peppy commented Feb 10, 2025 •

edited

Loading