Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoBid Bid Adapter: Support for GPP 1.1 #10287

Merged
merged 45 commits into from
Aug 22, 2023

Conversation

redaguermas
Copy link
Contributor

@redaguermas redaguermas commented Jul 28, 2023

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Added support for GPP string and GPP applicable sections for Bid and user sync.

Other information

prebid/prebid.github.io#4771

redaguermas and others added 30 commits March 4, 2020 15:39
* 'master' of https://github.com/prebid/Prebid.js: (49 commits)
  Submitting Clicktripz bid adapter (prebid#4929)
  add UNICORN bid adapter (prebid#4917)
  3.12.0-pre
  3.11.0 release
  Eids liveintent ext fix (prebid#4944)
  add mediaforce bid adapter (prebid#4933)
  update logic in adpod module for playersize (prebid#4953)
  Module - Size Mapping V2 (prebid#4690)
  Lifestreet adapter 3.0 (prebid#4927)
  IX Adapter - Increase banner TTL to 300s (prebid#4957)
  assert string returned not that we break things (prebid#4962)
  added option to url parser to ignore decoding entire url (prebid#4938)
  adding user-id support in medianet adapter (prebid#4925)
  removing the log (prebid#4960)
  add import extensions (prebid#4959)
  Add 7xbid adapter to compatible with prebid 3.0 (prebid#4908)
  Fix failing code-coverage command (prebid#4892)
  enable no-console eslint rule for project (prebid#4802)
  update audigent tests to fix larger test suite issue (prebid#4952)
  use bidId or bidIds in the payload (prebid#4903)
  ...
* 'master' of https://github.com/prebid/Prebid.js: (102 commits)
  Marsmedia - Add vastXml and fix id response (prebid#5067)
  PubMatic adapter to support image sync (prebid#5104)
  minor consentManagement fix (prebid#5050)
  fix circle ci failing tests (prebid#5113)
  Add Relaido Adapter (prebid#5101)
  Add new bid adapter for ConnectAd (prebid#4806)
  change payload (prebid#5105)
  Utils updates (prebid#5092)
  Read OpenRTB app objects if set in config + bug fix for when ad units are reloaded (prebid#5086)
  Criteo : added first party data mapping to bidder request (prebid#4954)
  updateAdGenerationManual (prebid#5032)
  New bid adapter: Wipes (prebid#5051)
  Prebid manager analytics utm tags (prebid#4998)
  CRITEO RTUS Integration with Yieldmo Prebid (prebid#5075)
  isSafariBrowser update  (prebid#5077)
  Support min &max duration for onevideo (prebid#5079)
  increment pre version
  Prebid 3.15.0 release
  prebid#5011 Fix to set Secure attribute on cookie when SameSite=none (prebid#5064)
  Prebid adapter for windtalker (prebid#5040)
  ...
# Conflicts:
#	test/spec/modules/nobidBidAdapter_spec.js
@ChrisHuie
Copy link
Collaborator

@redaguermas can you please remove the changes to the package-lock file from this pr

@redaguermas
Copy link
Contributor Author

@ChrisHuie,
The build failed because it's missing the package-lock file

@ChrisHuie
Copy link
Collaborator

@redaguermas yes. Looks like you removed the file. I meant to undo the changes. Sorry. I probably should have said untrack the changes to the package-lock instead. Just add back in the current one on master and should we should be good.

@ChrisHuie ChrisHuie self-requested a review August 4, 2023 20:38
@ChrisHuie ChrisHuie self-assigned this Aug 4, 2023
@redaguermas
Copy link
Contributor Author

@ChrisHuie , do you know what the issue is?

@redaguermas
Copy link
Contributor Author

@ChrisHuie
Even when I run the tests from my local it fails with an error "Username is required". This is the command I am running:
gulp test --browserstack --nolintfix

Please advise. Thank you

@redaguermas
Copy link
Contributor Author

redaguermas commented Aug 9, 2023

Can anyone help with this PR please? Other updates are blocked because of this one.

@redaguermas
Copy link
Contributor Author

Hello @ChrisHuie ,
The error cleared after we merged the master branch. Please review.
Thank you

@redaguermas
Copy link
Contributor Author

Hello @ChrisHuie
Any update on this PR?

@redaguermas
Copy link
Contributor Author

@ChrisHuie @dangoldin @naffis @bborn ,
Any update on this PR? I am not seeing any comments. We want to be able to unblock this PR to work on the next feature. Please look into it.

THanks

@ChrisHuie ChrisHuie merged commit ddd6a3b into prebid:master Aug 22, 2023
2 checks passed
@redaguermas
Copy link
Contributor Author

Thank you @ChrisHuie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants