ucfunnel adapter support CCPA and remove utils.js in adapter #4541

ucfunnel · 2019-12-06T01:27:14Z

Type of change

Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other

Description of change

test parameters for validating bids

{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

contact email of the adapter’s maintainer
official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

A link to a PR on the docs repo at https://github.com/prebid/prebid.github.io/

Other information

2. Replace var with let 3. Put JSON.parse(JSON.stringify()) into try catch block

Merge the latest changes 9/25/2017

ucfunnel · 2019-12-12T08:52:01Z

documentation PR linked for support ccpa prebid/prebid.github.io#1677

ucfunnel · 2019-12-18T02:55:05Z

@idettman documentation PR linked for support ccpa prebid/prebid.github.io#1677 and I update the test case. What I need to do next?

stale · 2020-01-01T03:29:46Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

ucfunnel · 2020-01-02T02:12:32Z

@idettman @jsnellbaker documentation PR linked for support ccpa prebid/prebid.github.io#1677 and I update the test case. What I need to do next?

jsnellbaker

Hi @ucfunnel

I took a look through the code and found a few items that should be addressed. Can you please take a look?

jsnellbaker · 2020-01-03T19:16:52Z

modules/ucfunnelBidAdapter.js

+ return bids.map(bid => {
+ return {
+ method: 'GET',
+ url: location.protocol + spec.ENDPOINT,


As part of the 3.0 changes, requests always need to be https instead of being dynamic. Can you please hard-code the protocol here (and in the related unit tests)?

jsnellbaker · 2020-01-03T19:21:02Z

modules/ucfunnelBidAdapter.js

+ }
+
+ if (isVideoMediaType && videoContext === 'outstream') {
+ utils.logWarn('Warning: outstream video is not supported yet');


This utils reference is still present, even though the import is gone. Can you either remove this message or re-add the import?

jsnellbaker · 2020-01-03T19:21:34Z

modules/ucfunnelBidAdapter.js

+ /*
+ if (utils.isArray(requestSizes) && requestSizes.length === 2 && !utils.isArray(requestSizes[0])) {
+ return [parseInt(requestSizes[0], 10), parseInt(requestSizes[1], 10)];
+ } else
+ */


If this code is no longer needed, can you please remove it?

ucfunnel · 2020-01-04T05:21:45Z

@jsnellbaker I fixed the problem that should be addressed.

jsnellbaker

Thanks for making the updates; LGTM now.

…idVersion1.2.0 * 'master' of https://github.com/prebid/Prebid.js: (22 commits) fix lint errors in unit test file (prebid#4702) Add Revcontent Adapter (prebid#4654) Changed data structure in Platform One Analytic Adapter (prebid#4647) increment pre version Prebid 3.2.0 Release Add static API option to the consentManagementUsp module. (prebid#4685) replace all xhr stubs with global xhr stub to prevent all requests (prebid#4687) Add CCPA us_privacy support to spotxBidAdapter (prebid#4689) ucfunnel adapter support CCPA and remove utils.js in adapter (prebid#4541) freewheelSSPBidAdapter (prebid#4645) Add CCPA support to Beachfront adapter (prebid#4673) add seedingAlliance Adapter (prebid#4614) Changed analytics data structure in YuktaMedia Analytic Adapter (prebid#4659) Add eplanning adapter for prebid 3.0 compliant and CCPA and GDPR support (prebid#4643) Bidder schain support (prebid#4551) Added CCPA support and GDPR compliance to Cedato adapter (prebid#4683) pass us privacy consent string to request (prebid#4581) Prebid 3 Admixer (prebid#4615) Pass uspConsent in bidRequest (prebid#4675) Advertly: New Bidder Adapter Submission (prebid#4496) ...

…4541) * Add a new ucfunnel Adapter and test page * Add a new ucfunnel Adapter and test page * 1. Use prebid lib in the repo to keep updated 2. Replace var with let 3. Put JSON.parse(JSON.stringify()) into try catch block * utils.getTopWindowLocation is a function * Change to modules from adapters * Migrate to module design * [Dev Fix] Remove width and height which can be got from ad unit id * Update ucfunnelBidAdapter to fit into new spec * Correct the endpoint. Fix the error of query string * Add test case for ucfunnelBidAdapter * Fix lint error * Update version number * Combine all checks on bid request * Add GDPR support for ucfunnel adapter * Add in-stream video and native support for ucfunnel adapter * Remove demo page. Add more test cases. * Change request method from POST to GET * Remove unnecessary comment * Support vastXml and vastUrl for video request * update TTL to 30 mins * Avoid using arrow function which is not discuraged in mocha * ucfunnel tdid support * ucfunnel fix error message in debug mode * ucfunnel adapter support CCPA Co-authored-by: Ryan Chou <ryanchou0210@gmail.com>

root and others added 30 commits June 5, 2017 05:43

Add a new ucfunnel Adapter and test page

d18db95

Add a new ucfunnel Adapter and test page

f82a4b7

1. Use prebid lib in the repo to keep updated

4c91775

2. Replace var with let 3. Put JSON.parse(JSON.stringify()) into try catch block

Merge branch 'master' into master

52eaecb

utils.getTopWindowLocation is a function

96a70a4

Merge branch 'master' of https://github.com/prebid/Prebid.js

7202a62

Change to modules from adapters

858b833

Migrate to module design

8b46932

[Dev Fix] Remove width and height which can be got from ad unit id

d7e043b

Merge branch 'master' of https://github.com/prebid/Prebid.js

badfa53

Merge pull request #1 from prebid/master

8d81704

Merge the latest changes 9/25/2017

Merge branch 'master' of https://github.com/prebid/Prebid.js

8e7fe31

Update ucfunnelBidAdapter to fit into new spec

5dc00f3

Correct the endpoint. Fix the error of query string

66c3a06

Add test case for ucfunnelBidAdapter

0328e97

Merge branch 'master' of https://github.com/prebid/Prebid.js

c2c5eb0

Fix lint error

86fdd23

Update version number

c331f57

Combine all checks on bid request

28acb40

Merge branch 'master' of https://github.com/prebid/Prebid.js

93621b8

Add GDPR support for ucfunnel adapter

f7f2515

Merge branch 'master' of https://github.com/prebid/Prebid.js

d4f3467

Add in-stream video and native support for ucfunnel adapter

1f79c44

Remove demo page. Add more test cases.

7d8dc52

Change request method from POST to GET

99fa86e

Remove unnecessary comment

03e37e6

Support vastXml and vastUrl for video request

aabfdd4

Merge branch 'master' of https://github.com/prebid/Prebid.js

2177c15

update TTL to 30 mins

af05d07

Avoid using arrow function which is not discuraged in mocha

45614c9

idettman added needs update reviewed and removed needs review labels Dec 11, 2019

idettman assigned ucfunnel Dec 11, 2019

ucfunnel adapter support CCPA

fee3803

ucfunnel force-pushed the ccpa branch from 311aa2f to fee3803 Compare December 12, 2019 06:16

ucfunnel changed the title ~~ucfunnel adapter support CCPA~~ ucfunnel adapter support CCPA and remove utils.js in adapter Dec 12, 2019

ucfunnel force-pushed the ccpa branch 4 times, most recently from 193e6b5 to 2864ddd Compare December 13, 2019 09:23

stale bot added the stale label Jan 1, 2020

stale bot removed the stale label Jan 2, 2020

jsnellbaker requested changes Jan 3, 2020

View reviewed changes

ucfunnel force-pushed the ccpa branch from 2864ddd to c5c75ae Compare January 4, 2020 04:38

ucfunnel adapter fix prebid 3.0 problem

0f9b6c8

ucfunnel force-pushed the ccpa branch from c5c75ae to 0f9b6c8 Compare January 4, 2020 04:55

jsnellbaker removed the request for review from sumit116 January 6, 2020 18:03

jsnellbaker assigned jsnellbaker and unassigned sumit116 Jan 6, 2020

jsnellbaker approved these changes Jan 6, 2020

View reviewed changes

jsnellbaker merged commit 41a8350 into prebid:master Jan 6, 2020

ucfunnel removed their assignment Jan 21, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ucfunnel adapter support CCPA and remove utils.js in adapter #4541

ucfunnel adapter support CCPA and remove utils.js in adapter #4541

ucfunnel commented Dec 6, 2019 •

edited

Loading

ucfunnel commented Dec 12, 2019

ucfunnel commented Dec 18, 2019

stale bot commented Jan 1, 2020

ucfunnel commented Jan 2, 2020

jsnellbaker left a comment

jsnellbaker Jan 3, 2020

jsnellbaker Jan 3, 2020

jsnellbaker Jan 3, 2020

ucfunnel commented Jan 4, 2020

jsnellbaker left a comment

ucfunnel adapter support CCPA and remove utils.js in adapter #4541

ucfunnel adapter support CCPA and remove utils.js in adapter #4541

Conversation

ucfunnel commented Dec 6, 2019 • edited Loading

Type of change

Description of change

Other information

ucfunnel commented Dec 12, 2019

ucfunnel commented Dec 18, 2019

stale bot commented Jan 1, 2020

ucfunnel commented Jan 2, 2020

jsnellbaker left a comment

Choose a reason for hiding this comment

jsnellbaker Jan 3, 2020

Choose a reason for hiding this comment

jsnellbaker Jan 3, 2020

Choose a reason for hiding this comment

jsnellbaker Jan 3, 2020

Choose a reason for hiding this comment

ucfunnel commented Jan 4, 2020

jsnellbaker left a comment

Choose a reason for hiding this comment

ucfunnel commented Dec 6, 2019 •

edited

Loading