Bidder schain support #4551
Merged
Bidder schain support #4551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harpere
added
the
needs 2nd review
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@msm0504 @robertrmartinez Could either of you please take a look at this PR when you have the chance? Just need one more review to get it merged. Thanks! |
redaguermas
added a commit
to redaguermas/Prebid.js
that referenced
this pull request
Jan 8, 2020
…idVersion1.2.0 * 'master' of https://github.com/prebid/Prebid.js: (22 commits) fix lint errors in unit test file (prebid#4702) Add Revcontent Adapter (prebid#4654) Changed data structure in Platform One Analytic Adapter (prebid#4647) increment pre version Prebid 3.2.0 Release Add static API option to the consentManagementUsp module. (prebid#4685) replace all xhr stubs with global xhr stub to prevent all requests (prebid#4687) Add CCPA us_privacy support to spotxBidAdapter (prebid#4689) ucfunnel adapter support CCPA and remove utils.js in adapter (prebid#4541) freewheelSSPBidAdapter (prebid#4645) Add CCPA support to Beachfront adapter (prebid#4673) add seedingAlliance Adapter (prebid#4614) Changed analytics data structure in YuktaMedia Analytic Adapter (prebid#4659) Add eplanning adapter for prebid 3.0 compliant and CCPA and GDPR support (prebid#4643) Bidder schain support (prebid#4551) Added CCPA support and GDPR compliance to Cedato adapter (prebid#4683) pass us privacy consent string to request (prebid#4581) Prebid 3 Admixer (prebid#4615) Pass uspConsent in bidRequest (prebid#4675) Advertly: New Bidder Adapter Submission (prebid#4496) ...
tadam75
pushed a commit
to smartadserver/Prebid.js
that referenced
this pull request
Jan 9, 2020
* iniital update for bidder schain support * finished code updates for bidder schain support * remove commented code * remove test file comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
PR for feature described here: #4465
Through using the
config.setBidderConfig(), publishers can setup specific schain configs for particular bidders to override the global schain config.These changes are backwards compatible to publishers. Adapters don't have to worry about updating their implementation in the
BidAdapter.jsfiles to read the schain data.To also note - I made some changes to how the errors/warnings are logged when evaluating the schain config (to mainly group them together and show the bad config in-line in the message; since many configs could be bad simultaneously).
Other information
See #4334 for details on the
setBidderConfigimplementation if needed.I will review the prebid.org docs (and possibly the
modules/schain.mdfile in this repo) about any documentation updates needed.