Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add seedingAlliance Adapter #4614

Merged
merged 1 commit into from
Jan 3, 2020

Conversation

SeedingAllianceTech
Copy link
Contributor

@SeedingAllianceTech SeedingAllianceTech commented Dec 17, 2019

Type of change

  • New bidder adapter

Description of change

  • test parameters for validating bids
{
	bidder: 'seedingAlliance',
	params: {
		url  : "https://mockup.seeding-alliance.de/ssp-testing/native.html",
		adUnitId: "2sq2o"
	}
}

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SeedingAllianceTech

Thanks for submitting this adapter.

When I tried to test the adapter with the provided test params, I was getting a CORS error against the endpoint. I have copied it below for reference:
Access to XMLHttpRequest at 'https://b.nativendo.de/cds/rtb/bid?format=openrtb2.5&ssp=nativendo' from origin 'http://test.localhost:9999' has been blocked by CORS policy: The 'Access-Control-Allow-Origin' header has a value 'http://test.localhost' that is not equal to the supplied origin.

Can you please take a look into this error?

Thanks.

@SeedingAllianceTech
Copy link
Contributor Author

Hi @jsnellbaker

i have solved the problem on the server side, can you check again please?

@jsnellbaker
Copy link
Collaborator

Hi @SeedingAllianceTech

I just checked again. While I'm not getting the CORS error anymore, I don't seem to be getting an actual response. The request to the endpoint is completing as a 204 response. Is that expected?

Below is a copy of the request payload for reference:

{"id":"c0cda811-e41f-487b-a76a-11387a5cdeb4","site":{"page":"https://mockup.seeding-alliance.de/ssp-testing/native.html"},"device":{"ua":"Mozilla/5.0 (iPhone; CPU iPhone OS 11_0 like Mac OS X) AppleWebKit/604.1.38 (KHTML, like Gecko) Version/11.0 Mobile/15A372 Safari/604.1"},"cur":["EUR"],"imp":[{"id":"1","tagid":"2sq2o","tid":"5e206b51-d637-438b-aa4f-5d7651047257","pt":"net","native":{"request":{"assets":[{"required":1,"id":0,"title":{"len":50}},{"required":1,"id":1,"data":{"len":350,"type":2}},{"required":1,"id":3,"img":{"type":3,"w":300,"h":175}},{"required":1,"id":2,"data":{"type":1}}]}}}],"user":{"buyeruid":"5dff3779-43ee-45b0-b242-8264bda55fc3"}}

@SeedingAllianceTech
Copy link
Contributor Author

Hi @jsnellbaker

not really, there was no line items for your country, i have add some.

now you should see correct bids.

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SeedingAllianceTech

Thanks for making the update for the test bid. I checked again and saw a bid was returning.

LGTM

@jsnellbaker jsnellbaker merged commit c5460d9 into prebid:master Jan 3, 2020
redaguermas added a commit to redaguermas/Prebid.js that referenced this pull request Jan 8, 2020
…idVersion1.2.0

* 'master' of https://github.com/prebid/Prebid.js: (22 commits)
  fix lint errors in unit test file (prebid#4702)
  Add Revcontent Adapter (prebid#4654)
  Changed data structure in Platform One Analytic Adapter (prebid#4647)
  increment pre version
  Prebid 3.2.0 Release
  Add static API option to the consentManagementUsp module. (prebid#4685)
  replace all xhr stubs with global xhr stub to prevent all requests (prebid#4687)
  Add CCPA us_privacy support to spotxBidAdapter (prebid#4689)
  ucfunnel adapter support CCPA and remove utils.js in adapter (prebid#4541)
  freewheelSSPBidAdapter  (prebid#4645)
  Add CCPA support to Beachfront adapter (prebid#4673)
  add seedingAlliance Adapter (prebid#4614)
  Changed analytics data structure in YuktaMedia Analytic Adapter (prebid#4659)
  Add eplanning adapter for prebid 3.0 compliant and CCPA and GDPR support (prebid#4643)
  Bidder schain support (prebid#4551)
  Added CCPA support and GDPR compliance to Cedato adapter (prebid#4683)
  pass us privacy consent string to request (prebid#4581)
  Prebid 3 Admixer (prebid#4615)
  Pass uspConsent in bidRequest (prebid#4675)
  Advertly: New Bidder Adapter Submission (prebid#4496)
  ...
tadam75 pushed a commit to smartadserver/Prebid.js that referenced this pull request Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants