replace all xhr stubs with global xhr stub to prevent all requests #4687
Conversation
There was a problem hiding this comment.
@snapwich Thanks for putting this all together.
I think the setup looks fine, though when I checked out this PR and checked the project, there appear to be a handful of other files that are using their own XHR mocks. Can you resync with master (if needed) and update these other references?
To help out, I put together a list of the files that I found:
adagioAnalyticsAdapter_spec.js
invisiblyAnalyticsAdapter_spec.js
liveIntentIdSystem_spec.js
prebidServerBidAdapter_spec.js (there's a set of tests around line 1632 that still uses it)
ucfunnelAnalyticsAdapter_spec.js
userId_spec.js
yuktamediaAnalyticsAdaptor_spec.js
jsnellbaker
added
the
needs 2nd review
snapwich
removed
the
needs 2nd review
|
thanks @jsnellbaker, just pushed a fix for those. this isn't quite ready for review yet, still in progress. hoping to find some fixes for the other issues listed in #4348 as well (script includes, pixels firing, etc). |
|
should be ready for review. fixes all external requests other than pixels (which are low priority because they don't load executable code, but should probably be fixed at some point). |
There was a problem hiding this comment.
Hi @snapwich
Thanks for making the extra updates. When you have the chance could you make two additional changes?
- update the
yuktamediaAnalyticsAdaptor_spec.jstest file as part of this clean-up. - add a small blurb to the
CONTRIBUTING.mdaround the Test Guidelines about the XHR mock (not sure how often people look at this, but it'll still be good to have it documented).
Thanks!
jsnellbaker
added
needs 2nd review
|
@jsnellbaker updated |
…idVersion1.2.0 * 'master' of https://github.com/prebid/Prebid.js: (22 commits) fix lint errors in unit test file (prebid#4702) Add Revcontent Adapter (prebid#4654) Changed data structure in Platform One Analytic Adapter (prebid#4647) increment pre version Prebid 3.2.0 Release Add static API option to the consentManagementUsp module. (prebid#4685) replace all xhr stubs with global xhr stub to prevent all requests (prebid#4687) Add CCPA us_privacy support to spotxBidAdapter (prebid#4689) ucfunnel adapter support CCPA and remove utils.js in adapter (prebid#4541) freewheelSSPBidAdapter (prebid#4645) Add CCPA support to Beachfront adapter (prebid#4673) add seedingAlliance Adapter (prebid#4614) Changed analytics data structure in YuktaMedia Analytic Adapter (prebid#4659) Add eplanning adapter for prebid 3.0 compliant and CCPA and GDPR support (prebid#4643) Bidder schain support (prebid#4551) Added CCPA support and GDPR compliance to Cedato adapter (prebid#4683) pass us privacy consent string to request (prebid#4581) Prebid 3 Admixer (prebid#4615) Pass uspConsent in bidRequest (prebid#4675) Advertly: New Bidder Adapter Submission (prebid#4496) ...
…rebid#4687) * replace all xhr stubs with global xhr stub to prevent all requests * fix test failures after conflict resolution * removed rest of custom XMLHttpRequest stubs * update adloader stub to be present even inbetween tests * remove unnecessary console.log in tests * third-party scripts loaded with loadExternalScript * update new test files to use mocked xhr server * add blurb about using global xhr stub for contributors * stub videoNow external requests * update all pixels to use utils.triggerPixel and stub tests * remove console.log out of freewheel test * simplify userId test setup and teardown
Type of change
Description of change
Replaces all sinon fake xhr and fake server stubbing with global stub to prevent any XMLHttpRequests from happening.
Update all pixels to use utils.triggerPixel and properly stub in tests.
Other information
Work related to #4348