Set bid response ID to bid request ID for triplelift. #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Facebook Audience Network adapter * 🐛 Adding required dependency for testing. * 🐛 Size check was incorrect and not required. * ✅ Adding error hanlding tests. * MOL specific builds. * FAN doesn't exist yet. * Adding a URL helper * Using custom ajax helper for FAN * 🐛 Avoid empty query strings * 🐛 Preflight ajax issues. * Using Array::includes instead of Array::indexOf * Keeping to naming conventions * Example * 🐛 Removing MOL specific build scripts * Building FAN ads
* Add UT endpoint adapter Make one request to /ut for all adslots on page * Build minimal request object * Correctly format size object * Implement inital response handler function * Create bid based on response status * Test response handling function * Extend base adapter to allow for alias bidding * Handle nobid response * Check for required parameters * Validate bid parameters * Store bid reference in request-response map * Configure XHR options * Add NO_BID to each placement for response error * Update adapter name * Update endpoint to /prebid and to use protocol-relative scheme
Currently, the load time events are passed through to GA as follows: 0-200ms 200-300ms 300-400ms 400-500ms 500-600ms 600-800ms 800-1000ms 1000-1200ms 1200-1500ms 1500-2000ms 2000ms above Unfortunately, this means they are sorted like this in the GA sheet: 0-200ms 1000-1200ms 1200-1500ms 1500-2000ms 2000ms above 200-300ms 300-400ms 400-500ms 500-600ms 600-800ms 800-1000ms This makes the Load Time Distribution chart difficult to read. I've fixed this within my own prebid.js file by adding a leading 0 to the 200-1000ms ranges, e.g. '0200-300ms'. It appears as though in the past the 1000ms+ ranges were entered as follows solving for this issue as well: t2:1000-1200ms t2:1200-1500ms t2:1500-2000ms t2:2000ms above
* Save bidWon adObject to _winningBids * Add test case fir getAllWinningBids * Add more unit tests
* gather bidders without responses during timeout callback. Fixes #489 - fixes bidders not being recorded as timed out if there is never a response - fixes `getTimedOutBidders()` always returning an empty array when only one bidder is used That happened because the function returned `slots requested - slots that replied`, but was called after timed out slots were marked as having replied before timeout - fixes `bidManager` ignoring the timeout override passed to `$$PREBID_GLOBAL$$.requestBids` * remove timeout triggering public function This is not necessary anymore as bidder timeouts are now handled automatically * remove unused event * rewrite timeout test to be async * handle responses arrived after timeout - mitigates #311 * notify the callback of timeout and delegate its event triggering * bid timeout must be executed BEFORE `_bidsReceived.push` This ensures that `getTimedOutBidders` recognises the current response as timed out
* Set bid response ID to bid request ID * Refactor
* JSCS fixes * queue bid requests * close over auction instance data when queuing a request for bids * review notes * mark bid requests and responses complete when the ad for a given auction and placement renders * call markComplete on renderAd and removeComplete on requestBids * test presence before accessing properties, add tests, ignore selenium files
* iterate over adUnits backwards to prevent errors with in-place array mutation * add unit test for removeAdUnit
* Memeglobal initial commit * Bid Request changes * Bid Request changes * Update memeglobal.js * add unit test * fix for continuous integration * fix bid floor to number * fix bid floor to number * fix bid floor to number
* Add tests for triplelift adapter. * Add whitespace.
|
Thanks for the contribution, can we get a review from @prebid/triplelift? |
protonate
force-pushed
the
master
branch
2 times, most recently
from
fc91b58
to
b2c617a
Compare
|
On Friday it was necessary to remove a commit from Prebid.js, and a force push of master branch has rewritten history. As a committer with an open PR this event impacts you, and we regret the inconvenience. We will need to close your PR and ask that you reapply your changes to a current fork of master, then open a new PR. This will align your history with the main project and your PR will show only your changes. Committers are referred to the Apache License (https://github.com/prebid/Prebid.js/blob/master/LICENSE) for details on submitting code to the Prebid.js project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates triplelift for #509