-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No bid version 1.2.8 #5630
No bid version 1.2.8 #5630
Conversation
* 'master' of https://github.com/prebid/Prebid.js: (49 commits) Submitting Clicktripz bid adapter (prebid#4929) add UNICORN bid adapter (prebid#4917) 3.12.0-pre 3.11.0 release Eids liveintent ext fix (prebid#4944) add mediaforce bid adapter (prebid#4933) update logic in adpod module for playersize (prebid#4953) Module - Size Mapping V2 (prebid#4690) Lifestreet adapter 3.0 (prebid#4927) IX Adapter - Increase banner TTL to 300s (prebid#4957) assert string returned not that we break things (prebid#4962) added option to url parser to ignore decoding entire url (prebid#4938) adding user-id support in medianet adapter (prebid#4925) removing the log (prebid#4960) add import extensions (prebid#4959) Add 7xbid adapter to compatible with prebid 3.0 (prebid#4908) Fix failing code-coverage command (prebid#4892) enable no-console eslint rule for project (prebid#4802) update audigent tests to fix larger test suite issue (prebid#4952) use bidId or bidIds in the payload (prebid#4903) ...
* 'master' of https://github.com/prebid/Prebid.js: (102 commits) Marsmedia - Add vastXml and fix id response (prebid#5067) PubMatic adapter to support image sync (prebid#5104) minor consentManagement fix (prebid#5050) fix circle ci failing tests (prebid#5113) Add Relaido Adapter (prebid#5101) Add new bid adapter for ConnectAd (prebid#4806) change payload (prebid#5105) Utils updates (prebid#5092) Read OpenRTB app objects if set in config + bug fix for when ad units are reloaded (prebid#5086) Criteo : added first party data mapping to bidder request (prebid#4954) updateAdGenerationManual (prebid#5032) New bid adapter: Wipes (prebid#5051) Prebid manager analytics utm tags (prebid#4998) CRITEO RTUS Integration with Yieldmo Prebid (prebid#5075) isSafariBrowser update (prebid#5077) Support min &max duration for onevideo (prebid#5079) increment pre version Prebid 3.15.0 release prebid#5011 Fix to set Secure attribute on cookie when SameSite=none (prebid#5064) Prebid adapter for windtalker (prebid#5040) ...
This error is unrelated to our code. Can you double-check please? |
@redaguermas Please add unit tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as said in another comment, please add unit tests to keep the code coverage greater than 80%, but I encourage to test as much as you can. Thank you
The test-coverage does not work. Is it working for you?
START: Error: Cannot find module "src/adloader.js" Error: Cannot find module "src/adloader.js" Finished in 2.032 secs / 0 secs @ 16:58:50 GMT-0700 (Pacific Daylight Time) SUMMARY: |
@musikele , -Thanks |
Hi @redaguermas , I can run tests just fine. You may need to delete node_modules folder and do npm install again. Also, currently there is anoter module that has failing tests. To get around this issue, you can comment out or skip the offending tests. Small add after few days: check the nodejs version. The latest LTS release (v12.x) is the one I'm currently using. |
@musikele |
@robertrmartinez , I added unit tests and the coverage is >80%. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Type of change
Description of change
Added support for GDPR/TCF 2.0
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide: