Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[smart_holder] git merge master (attempt 3) #4504

Merged
merged 16 commits into from
Feb 8, 2023

Conversation

rwgk
Copy link
Collaborator

@rwgk rwgk commented Feb 8, 2023

Description

Helper/scratch PR for testing.

Note: Temporarily remove pip.yml, to avoid GHA failures while waiting for a fix on master.

Google-internal global testing ID: OCL:508009603:BASE:508134481:1675884196262:8f5643a2 (passed)

Global testing was run after this PR was merged.

Suggested changelog entry:

Ralf W. Grosse-Kunstleve and others added 16 commits January 12, 2023 17:50
…4461)

* Make sure to properly untrack gc objects before freeing them

* style: pre-commit fixes

* Fix lint

* Add comment about where the original track comes from

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Resolve flake8 error by replacing `pytest.raises(Exception)` with `SystemError`

* Also remove the obsolete comment.

* Tweak comment instead of removing it.
…ybind#4473)

* Use PyConfig_InitPythonConfig instead of PyConfig_InitIsolatedConfig

* add unit test for default python configuration

---------

Co-authored-by: Daniel Jacobs <daniel.jacobs@is4s.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
)

Bumps [ilammy/msvc-dev-cmd](https://github.com/ilammy/msvc-dev-cmd) from 1.12.0 to 1.12.1.
- [Release notes](https://github.com/ilammy/msvc-dev-cmd/releases)
- [Commits](ilammy/msvc-dev-cmd@v1.12.0...v1.12.1)

---
updated-dependencies:
- dependency-name: ilammy/msvc-dev-cmd
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 (pybind#4486)

* Keep registered types until after Py_Finalize(). Fix pybind#4459

* Address reviewer comments
updates:
- [github.com/PyCQA/pylint: v2.16.0 → v2.16.1](pylint-dev/pylint@v2.16.0...v2.16.1)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@rwgk
Copy link
Collaborator Author

rwgk commented Feb 8, 2023

Not globally tested, but tested interactively with all sanitizers using the Google toolchain.

@rwgk rwgk merged commit 3cef809 into pybind:smart_holder Feb 8, 2023
@rwgk rwgk deleted the sh_merge_master3 branch February 8, 2023 10:07
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Feb 8, 2023
@rwgk rwgk removed the needs changelog Possibly needs a changelog entry label Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants