Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for the Split Common I2C code's SCL_CLOCK issue #3474

Merged
merged 3 commits into from
Jul 25, 2018
Merged

Fix for the Split Common I2C code's SCL_CLOCK issue #3474

merged 3 commits into from
Jul 25, 2018

Conversation

drashna
Copy link
Member

@drashna drashna commented Jul 23, 2018

Sets up the SCL_CLOCK speed to be configurable, per keyboard. And adds documentation for the setting.

@That-Canadian and @nooges Did this look good? Or did we want to handle this in a different way, or use a different default?

@drashna
Fix the SLC_CLOCK setting for the Split Common code
1d4da86 
Make the SCL_CLOCK setting configurable per board, since some use different settings
And change the Iris  to use 100000L instead of 400000L
@drashna
Add SCL_CLOCK variable to documentation
f987a47
@nooges
Copy link
Member

nooges commented Jul 23, 2018

I'm thinking we should set the default at 100kHz for better compatibility.

@drashna
Copy link
Member Author

drashna commented Jul 23, 2018

Updated to use 100000L, looks better now?

@nooges
Copy link
Member

nooges commented Jul 24, 2018

👍

@nooges nooges mentioned this pull request Jul 24, 2018
Closed
@drashna
Copy link
Member Author

drashna commented Jul 25, 2018

@jackhumbert or @skullydazed if this could be merged soon?

@skullydazed skullydazed merged commit 4df6b7b into qmk:master Jul 25, 2018
@skullydazed
Copy link
Member

Thanks!

@drashna drashna deleted the split_common_i2c_fix branch July 25, 2018 15:38
mattfluder pushed a commit to mattfluder/qmk_firmware that referenced this pull request Jul 30, 2018
@drashna @Matt662
Fix for the Split Common I2C code's SCL_CLOCK issue (qmk#3474)
54f868f 
* Fix the SLC_CLOCK setting for the Split Common code

Make the SCL_CLOCK setting configurable per board, since some use different settings
And change the Iris  to use 100000L instead of 400000L

* Add SCL_CLOCK variable to documentation

* Change SCL_CLOCK default to 100000L
alexey-danilov pushed a commit to alexey-danilov/qmk_firmware that referenced this pull request Aug 3, 2018
@drashna
Fix for the Split Common I2C code's SCL_CLOCK issue (qmk#3474)
832a87f 
* Fix the SLC_CLOCK setting for the Split Common code

Make the SCL_CLOCK setting configurable per board, since some use different settings
And change the Iris  to use 100000L instead of 400000L

* Add SCL_CLOCK variable to documentation

* Change SCL_CLOCK default to 100000L
tenderlove added a commit to tenderlove/qmk_firmware that referenced this pull request Aug 5, 2018
@tenderlove
Merge branch 'master' into merging
985eec2 
* master: (184 commits)
  Docs: Clarify "right" -> "right-handed" (qmk#3507)
  Docs: Fixed the link to the advanced keycodes wiki (qmk#3505)
  Keyboard: Update KEYMAP to LAYOUT for ckeys obelus (qmk#3495)
  Keyboard: Hide JC65 directory in QMK Configurator (qmk#3491)
  Keymap: jennetters iris keymap (qmk#3488)
  Keymap: jennetters fourier split 40% keymap (qmk#3487)
  Keymap: Add LAYOUT_planck_grid to planck/dshields keymap. (qmk#3484)
  Keyboard: Add HelixPico keyboard (qmk#3502)
  Keymap: Ergodox Dvorak 42 key layout changes (qmk#3500)
  Keyboard: E6V2 Layout Fix (qmk#3490)
  Keymap: UT47:nordic - A couple of tweaks (qmk#3489)
  Keyboard: E6V2 LE Improvements (qmk#3486)
  redox: convert to use SPLIT_KEYBOARD feature (qmk#3478)
  Keymap: Bocaj Ergodox Updates (qmk#3364)
  keymap: Update khord let's split keymap and add chocopad keymap (qmk#3482)
  Keymap: Add smt keymap for TKC1800 (qmk#3481)
  Fix for the Split Common I2C code's SCL_CLOCK issue (qmk#3474)
  keymap: UT47:nordic - fixed typo (qmk#3477)
  Keyboard: Add QC60 (qmk#3472)
  Keyboard: Base for the nicekey keyboard (qmk#3475)
  ...
filoxo pushed a commit to filoxo/qmk_firmware that referenced this pull request Aug 27, 2018
@drashna
Fix for the Split Common I2C code's SCL_CLOCK issue (qmk#3474)
26b8e9b 
* Fix the SLC_CLOCK setting for the Split Common code

Make the SCL_CLOCK setting configurable per board, since some use different settings
And change the Iris  to use 100000L instead of 400000L

* Add SCL_CLOCK variable to documentation

* Change SCL_CLOCK default to 100000L
ChrissiQ pushed a commit to ChrissiQ/qmk_firmware that referenced this pull request Sep 25, 2018
@drashna @ChrissiQ
Fix for the Split Common I2C code's SCL_CLOCK issue (qmk#3474)
fac83ae 
* Fix the SLC_CLOCK setting for the Split Common code

Make the SCL_CLOCK setting configurable per board, since some use different settings
And change the Iris  to use 100000L instead of 400000L

* Add SCL_CLOCK variable to documentation

* Change SCL_CLOCK default to 100000L
yamad pushed a commit to yamad/qmk_firmware that referenced this pull request Apr 10, 2019
@drashna @yamad
Fix for the Split Common I2C code's SCL_CLOCK issue (qmk#3474)
0edfab0 
* Fix the SLC_CLOCK setting for the Split Common code

Make the SCL_CLOCK setting configurable per board, since some use different settings
And change the Iris  to use 100000L instead of 400000L

* Add SCL_CLOCK variable to documentation

* Change SCL_CLOCK default to 100000L
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackhumbert jackhumbert Awaiting requested review from jackhumbert

@skullydazed skullydazed Awaiting requested review from skullydazed

Assignees
No one assigned
Labels
bug optimization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drashna @nooges @skullydazed