Add QC60 #3472

coarse · 2018-07-23T14:39:34Z

Added files for my split staggered 60%, QC60. Commit includes:

Config files for QC60
Config for all supported layouts
Default keymap and my friend's keymap

Todo:

Setup I2C RGB Underglow
Link files for case design
Link pictures of finished builds

drashna · 2018-07-23T18:56:10Z

keyboards/handwired/qc60/keymaps/default/config.h

+along with this program.  If not, see <http://www.gnu.org/licenses/>.
+*/
+
+#ifndef CONFIG_USER_H


Could you replace the boilerplate with #pragma once?

Eg, the file should look like:

#pragma once #define USE_I2C #define MASTER_LEFT

drashna · 2018-07-23T18:56:54Z

keyboards/handwired/qc60/keymaps/default/keymap.c

+#define XXXXXXX KC_NO
+
+const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
+  [_BASE] = LAYOUT_ANSI_DEFAULT(


The Layout macro should be LAYOUT_ansi_default.

Eg, everything but LAYOUT should be lowercase.

drashna · 2018-07-23T18:57:20Z

keyboards/handwired/qc60/keymaps/default/rules.mk

@@ -0,0 +1,3 @@
+ifndef QUANTUM_DIR


This block isn't needed.

Either remove the contents of the file, or remove the file.

drashna · 2018-07-23T18:57:36Z

keyboards/handwired/qc60/keymaps/wntrmln/config.h

+You should have received a copy of the GNU General Public License
+along with this program.  If not, see <http://www.gnu.org/licenses/>.
+*/
+


Could you replace the boilerplate with #pragma once?

Eg, the file should look like:

#pragma once #define USE_SERIAL #define MASTER_LEFT

drashna · 2018-07-23T18:58:05Z

keyboards/handwired/qc60/keymaps/wntrmln/keymap.c

+#define FN MO(_FN)
+
+const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
+  [_BASE] = LAYOUT_HHKB_SPLIT_LSHIFT(


The layout macros should be lowercase.

Eg LAYOUT_hhkb_split_lshift

drashna · 2018-07-23T19:03:05Z

keyboards/handwired/qc60/proto/proto.h

+    {R47, R46, R45, R44, R43, R42, XXX, XXX}, \
+}
+
+#define LAYOUT_ISO_ALT( \


This should be LAYOUT_iso_alt

drashna · 2018-07-23T19:06:22Z

keyboards/handwired/qc60/proto/proto.h

+    {R47, R46, R45, R44, R43, XXX, XXX, XXX}, \
+}
+
+#define LAYOUT_HHKB_DEFAULT( \


This should be LAYOUT_hhkb_default

Does this match the actual HHKB layout?

Because it's a split keyboard, the bottom row doesn't 100% follow the HHKB layout. The layout macro, along with splitting backspace and right shift, does not include the leftmost and rightmost keys on the bottom row which is the same behavior with HHKB layouts.

drashna · 2018-07-23T19:06:56Z

keyboards/handwired/qc60/proto/proto.h

+    {XXX, R46, R45, R44, R43, XXX, XXX, XXX}, \
+}
+
+#define LAYOUT_HHKB_SPLIT_LSHIFT( \


This should be LAYOUT_hhkb_split_shift (or lshift)

@noroadsleft?

I opted to go with "split_lshift" to avoid confusion. HHKB layout, by default, comes with a split right shift.

drashna · 2018-07-23T19:08:51Z

keyboards/handwired/qc60/proto/proto.h

+    {XXX, R46, R45, R44, R43, XXX, XXX, XXX}, \
+}
+
+#define LAYOUT_WKL_DEFAULT( \


This should be LAYOUT_wkl_default

drashna · 2018-07-23T19:09:35Z

keyboards/handwired/qc60/rules.mk

+# Do not enable SLEEP_LED_ENABLE. it uses the same timer as BACKLIGHT_ENABLE
+SLEEP_LED_ENABLE = no    # Breathing sleep LED during USB suspend
+
+DEFAULT_FOLDER = qc60/rev1


Is there a rev1 folder here?

Sorry, forgot to change this to qc60/proto. Initially used rev1 but then opted to go proto instead.

Not a problem. Just wanted to make sure, so that it will compile correctly.

…description

drashna · 2018-07-24T01:02:08Z

keyboards/handwired/qc60/README.md

+
+Make example for this keyboard (after setting up your build environment):
+
+    make qc60/rev1:default


This should be make handwired/qc60/proto:default then.

drashna · 2018-07-25T15:18:27Z

Awesome, thanks!

* Added initial files for QC60 prototype * renamed all 'keymap' to 'layout' * renamed layout macros to suggested naming convention of LAYOUT_macro_description * replaced boilerplate * removed rules.mk from keymap folders * replaced 'qc60/rev1' with 'qc60/proto' * replaced more boilerplate * renamed DEFAULT_FOLDER to point at the correct folder * updated readme

* master: (184 commits) Docs: Clarify "right" -> "right-handed" (qmk#3507) Docs: Fixed the link to the advanced keycodes wiki (qmk#3505) Keyboard: Update KEYMAP to LAYOUT for ckeys obelus (qmk#3495) Keyboard: Hide JC65 directory in QMK Configurator (qmk#3491) Keymap: jennetters iris keymap (qmk#3488) Keymap: jennetters fourier split 40% keymap (qmk#3487) Keymap: Add LAYOUT_planck_grid to planck/dshields keymap. (qmk#3484) Keyboard: Add HelixPico keyboard (qmk#3502) Keymap: Ergodox Dvorak 42 key layout changes (qmk#3500) Keyboard: E6V2 Layout Fix (qmk#3490) Keymap: UT47:nordic - A couple of tweaks (qmk#3489) Keyboard: E6V2 LE Improvements (qmk#3486) redox: convert to use SPLIT_KEYBOARD feature (qmk#3478) Keymap: Bocaj Ergodox Updates (qmk#3364) keymap: Update khord let's split keymap and add chocopad keymap (qmk#3482) Keymap: Add smt keymap for TKC1800 (qmk#3481) Fix for the Split Common I2C code's SCL_CLOCK issue (qmk#3474) keymap: UT47:nordic - fixed typo (qmk#3477) Keyboard: Add QC60 (qmk#3472) Keyboard: Base for the nicekey keyboard (qmk#3475) ...

* Added initial files for QC60 prototype * renamed all 'keymap' to 'layout' * renamed layout macros to suggested naming convention of LAYOUT_macro_description * replaced boilerplate * removed rules.mk from keymap folders * replaced 'qc60/rev1' with 'qc60/proto' * replaced more boilerplate * renamed DEFAULT_FOLDER to point at the correct folder * updated readme

coarse added 2 commits July 23, 2018 22:17

Added initial files for QC60 prototype

210cc46

renamed all 'keymap' to 'layout'

ab78ca6

drashna added the keyboard label Jul 23, 2018

drashna requested changes Jul 23, 2018

View reviewed changes

drashna added in progress awaiting changes labels Jul 23, 2018

coarse added 6 commits July 24, 2018 06:49

renamed layout macros to suggested naming convention of LAYOUT_macro_…

b739991

…description

replaced boilerplate

f9548b5

removed rules.mk from keymap folders

4985e50

replaced 'qc60/rev1' with 'qc60/proto'

546ba91

replaced more boilerplate

8a068b2

renamed DEFAULT_FOLDER to point at the correct folder

a6d3adf

drashna reviewed Jul 24, 2018

View reviewed changes

updated readme

e177212

drashna approved these changes Jul 25, 2018

View reviewed changes

drashna removed the awaiting changes label Jul 25, 2018

drashna merged commit c14e297 into qmk:master Jul 25, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add QC60 #3472

Add QC60 #3472

coarse commented Jul 23, 2018 •

edited

Loading

drashna Jul 23, 2018

drashna Jul 23, 2018

drashna Jul 23, 2018

drashna Jul 23, 2018

drashna Jul 23, 2018

drashna Jul 23, 2018

drashna Jul 23, 2018

coarse Jul 23, 2018

drashna Jul 23, 2018

coarse Jul 23, 2018

drashna Jul 23, 2018

drashna Jul 23, 2018

coarse Jul 23, 2018

drashna Jul 23, 2018

drashna Jul 24, 2018

drashna commented Jul 25, 2018


		Make example for this keyboard (after setting up your build environment):

		make qc60/rev1:default

Add QC60 #3472

Add QC60 #3472

Conversation

coarse commented Jul 23, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

drashna commented Jul 25, 2018

coarse commented Jul 23, 2018 •

edited

Loading