Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HelixPico keyboard #3502

Merged
merged 1 commit into from
Jul 26, 2018
Merged

Add HelixPico keyboard #3502

merged 1 commit into from
Jul 26, 2018

Conversation

MakotoKurauchi
Copy link
Contributor

I added a new HelixPico keyboard

@drashna
Copy link
Member

drashna commented Jul 26, 2018

Thanks!

@drashna drashna merged commit 07e0558 into qmk:master Jul 26, 2018
@drashna
Copy link
Member

drashna commented Jul 26, 2018

Also, don't know if you saw it, but a "split common" feature was added recently. Where all of the split code is maintained as part of the core code.

https://docs.qmk.fm/#/config_options?id=feature-options

@MakotoKurauchi
Copy link
Contributor Author

I did not know that option. Thank you.

@MakotoKurauchi MakotoKurauchi deleted the helixpico branch July 26, 2018 23:44
@mtei
Copy link
Contributor

mtei commented Jul 28, 2018

Hi,
There was a bug in serial.c of let's split and serial.c of helix before commitID 1038bbe.
Therefore, quantum/split_common/serial.c also has a bug.

In Helix keyboard(include HelixPico, I think), left and right hand communication was unstable when long cable was used.
The reason is that sync_send () and sync_recv () are improperly used when sending data from master to slave and can not be synchronized.

I think that you can be convinced by looking at the image of the third piece of this tweet.
https://twitter.com/mtei/status/1010807503024619520

Helix keyboard is transmitting 5 bytes from master to slave, so the effect of this bug was significant.

@mtei
Copy link
Contributor

mtei commented Jul 28, 2018

Previously, I fixed a bug in helix serial.c and contributed it to Makoto Kurauchi.
( 1038bbe )

And now I am sending a new pull-request to Makoto Kurauchi.
( MakotoKurauchi#14 )

I hope that this latest serial.c will be used on other keyboards as well.

mattfluder pushed a commit to mattfluder/qmk_firmware that referenced this pull request Jul 30, 2018
alexey-danilov pushed a commit to alexey-danilov/qmk_firmware that referenced this pull request Aug 3, 2018
tenderlove added a commit to tenderlove/qmk_firmware that referenced this pull request Aug 5, 2018
* master: (184 commits)
  Docs: Clarify "right" -> "right-handed" (qmk#3507)
  Docs: Fixed the link to the advanced keycodes wiki (qmk#3505)
  Keyboard: Update KEYMAP to LAYOUT for ckeys obelus (qmk#3495)
  Keyboard: Hide JC65 directory in QMK Configurator (qmk#3491)
  Keymap: jennetters iris keymap (qmk#3488)
  Keymap: jennetters fourier split 40% keymap (qmk#3487)
  Keymap: Add LAYOUT_planck_grid to planck/dshields keymap. (qmk#3484)
  Keyboard: Add HelixPico keyboard (qmk#3502)
  Keymap: Ergodox Dvorak 42 key layout changes (qmk#3500)
  Keyboard: E6V2 Layout Fix (qmk#3490)
  Keymap: UT47:nordic - A couple of tweaks (qmk#3489)
  Keyboard: E6V2 LE Improvements (qmk#3486)
  redox: convert to use SPLIT_KEYBOARD feature (qmk#3478)
  Keymap: Bocaj Ergodox Updates (qmk#3364)
  keymap: Update khord let's split keymap and add chocopad keymap (qmk#3482)
  Keymap: Add smt keymap for TKC1800 (qmk#3481)
  Fix for the Split Common I2C code's SCL_CLOCK issue (qmk#3474)
  keymap: UT47:nordic - fixed typo (qmk#3477)
  Keyboard: Add QC60 (qmk#3472)
  Keyboard: Base for the nicekey keyboard (qmk#3475)
  ...
filoxo pushed a commit to filoxo/qmk_firmware that referenced this pull request Aug 27, 2018
ChrissiQ pushed a commit to ChrissiQ/qmk_firmware that referenced this pull request Sep 25, 2018
yamad pushed a commit to yamad/qmk_firmware that referenced this pull request Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants