-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flow transitions #691
flow transitions #691
Conversation
Here's the packed extension for this build: |
Here's the packed extension for this build: |
Here's the packed extension for this build: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 💅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. I really like the transitions. I left a couple comments.
Here's the packed extension for this build: |
Here's the packed extension for this build: |
Here's the packed extension for this build: |
Here's the packed extension for this build: |
Here's the packed extension for this build: |
Here's the packed extension for this build: |
Here's the packed extension for this build: |
Here's the packed extension for this build: |
Fixes BX-####
Figma link (if any):
What changed (plus any additional context for devs)
Screen recordings / screenshots
Screen.Recording.2023-06-23.at.21.50.35.mov
What to test
TEST PERFORMANCE
some runs are smooth other drop some frames and I couldn't figure out whats the root yet would love more eyes on it
it should animate and work the same on fullscreen too
thats why I added a context provider for the container on animated route, so we don't rely on the whole window scroll and only on the container element instead
Final checklist
yarn build
).