Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flow transitions #691

Merged
merged 43 commits into from
Jul 2, 2023
Merged

flow transitions #691

merged 43 commits into from
Jul 2, 2023

Conversation

greg-schrammel
Copy link
Contributor

@greg-schrammel greg-schrammel commented Jun 24, 2023

Fixes BX-####
Figma link (if any):

What changed (plus any additional context for devs)

Screen recordings / screenshots

Screen.Recording.2023-06-23.at.21.50.35.mov

What to test

  • TEST PERFORMANCE
    some runs are smooth other drop some frames and I couldn't figure out whats the root yet would love more eyes on it

  • it should animate and work the same on fullscreen too
    thats why I added a context provider for the container on animated route, so we don't rely on the whole window scroll and only on the container element instead

Final checklist

  • I have tested my changes in a LavaMoat bundle (yarn build).
  • I have tested my changes in Chrome & Brave.
  • If your changes are visual, did you check both the light and dark themes?

@greg-schrammel greg-schrammel marked this pull request as draft June 24, 2023 00:54
@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz

@greg-schrammel greg-schrammel marked this pull request as ready for review June 26, 2023 15:41
@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz

Copy link
Contributor

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 💅

Copy link
Member

@derHowie derHowie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I really like the transitions. I left a couple comments.

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz

@github-actions
Copy link

github-actions bot commented Jul 1, 2023

Here's the packed extension for this build:
node_modules.tar.gz

@github-actions
Copy link

github-actions bot commented Jul 2, 2023

Here's the packed extension for this build:
node_modules.tar.gz

@github-actions
Copy link

github-actions bot commented Jul 2, 2023

Here's the packed extension for this build:
rainbowbx-60196b22ff9f72d37a33afadccc563e5b58cf551.zip

@greg-schrammel greg-schrammel merged commit 33f0ab8 into master Jul 2, 2023
@greg-schrammel greg-schrammel deleted the scroll-header-transition branch July 2, 2023 02:15
@github-actions
Copy link

github-actions bot commented Jul 2, 2023

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-33f0ab80a532f9793fe044f078324ee8eadbaef7.zip

BrodyHughes pushed a commit that referenced this pull request Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants