Add ShouldCompactOnLaunch to the PCL RealmConfig #1768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmunkholm
reviewed
Sep 4, 2018
| @@ -9,7 +9,8 @@ for most certificates. Notably, it will now work out of the box for Realm Cloud | |||
|
|
|||
| ### Bug fixes | |||
| - When constructing queries that compare an invalid/unmanaged RealmObject (e.g. `realm.All<Foo>().Where(f => f.Bar == someBar)`), | |||
| a meaningful exception will now be thrown rather than an obscure ArgumentNullException. | |||
| a meaningful exception will now be thrown rather than an obscure ArgumentNullException. | |||
There was a problem hiding this comment.
Please refer to the issues numbers.
There was a problem hiding this comment.
I believe that entry belongs to en earlier PR.
There was a problem hiding this comment.
We've stopped including issue/PR numbers in the .NET changelog a few versions ago. Let's discuss the pros/cons offline.
|
@kneth we have tests for the functionality, but not for the existence of the API in a PCL project. This is somewhat similar to the React support library that realm-js has. |
kneth
approved these changes
Sep 4, 2018
nirinchev
added a commit
that referenced
this pull request
Jul 10, 2019
* master: (89 commits) Prepare for 4.0.1 (#1876) Fix iOS device builds (#1875) Prepare for 4.0.0 (#1868) Refactor packaging (#1849) Update CHANGELOG.md (#1828) Add session.stop/start methods (#1839) Prepare for 3.4.0 (#1826) Ensure GetInstanceAsync works with QBS config (#1827) Add ability to define custom log function (#1824) Add support for user agents (#1819) Bump Sync to 3.10.1 (#1772) Update ISSUE_TEMPLATE.md Release 3.3.0 (#1808) Expose SyncConfiguration.OnProgress (#1807) Throw an error when trying to call async subscription methods on background threads (#1783) Update CHANGELOG.md (#1777) Prepare for 3.2.1 (#1775) Fix subscription state size (#1774) Release 3.2.0 (#1769) Add ShouldCompactOnLaunch to the PCL RealmConfig (#1768) ... # Conflicts: # Platform.PCL/Realm.PCL/Extensions/CollectionNotificationsExtensionsPCL.cs # Tests/Tests.Shared/CollectionTests.cs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://github.com/realm/realm-dotnet-private/issues/125
TODO